XBMC Community Forum
New MythTV add-on using libcmyth - Printable Version

+- XBMC Community Forum (http://forum.xbmc.org)
+-- Forum: Development (/forumdisplay.php?fid=32)
+--- Forum: PVR Development (/forumdisplay.php?fid=136)
+--- Thread: New MythTV add-on using libcmyth (/showthread.php?tid=110694)



- grad - 2012-01-06 20:52

Hi there,

I'm interested in trying out this new addon, however I'm sitting on the xvba version of xbmc. Against which branch can I diff your git master to get all parts of your addon? I tried to manually copy over addons/pvr.mythtv.cmyth, lib/cmyth and xbmc/pvrclients/mythtv-cmyth/ but apparently that wasn't enough. Could also be that the xvba git is a bit newer, but I got quite disturbing compiler errors in addons/library.xbmc.gui/. The xvba guys tell me that they are pretty much up to date with the opdenkamp pvr branch, which I thought was your reference as well. So what do you think - do I stand a chance in trying this? TIA!


- tsp42 - 2012-01-07 02:21

grad: Does the xvba version of xbmc contains the PVR code? if so you could try to diff opdenkamps master branch and my master branch and use it on the xvba version.

neuroGeek: The autoskipping of commercials and mark watched is on the TODO list so it will eventually be included.


Is this the myth add-on included in eden? - askvictor - 2012-01-08 07:45

I'm new to xbmc, have just installed the eden beta to use as a frontend to myth 0.24. Is the add-on that is included in eden, or is there another one?


- dubstar_04 - 2012-01-08 09:39

askvictor Wrote:I'm new to xbmc, have just installed the eden beta to use as a frontend to myth 0.24. Is the add-on that is included in eden, or is there another one?


Welcome to XBMC,

All the information you require is in the first post.

At this present moment the add-on cannot be built separately, ie. outside xbmc, therefore you will need to compile tsp's branch and install. This really is very simple and instructions can be found in the first post.

Tsp's branch is sync'd regularly, so its pretty up to date.

I hope this helps,

dubstar_04


- askvictor - 2012-01-08 10:37

dubstar_04 Wrote:All the information you require is in the first post.

At this present moment the add-on cannot be built separately, ie. outside xbmc, therefore you will need to compile tsp's branch and install. This really is very simple and instructions can be found in the first post.

Tsp's branch is sync'd regularly, so its pretty up to date.

I hope this helps,

dubstar_04

Thanks, but I still don't quite understand - is the myth:// handler built into eden the sane as this add-on or is it a separate project?


- tsp42 - 2012-01-08 12:15

askvictor: Myth:// is the build-in support in XBMC for LiveTV and viewing of recordings from a MythTV backend. My add-on is something different. It is a MythTV add-on for the xbmc PVR version of xbmc that should hopeful should be included in the version of xbmc after eden. The addon support scheduling of recordings while the build-in Myth:// support does not.


- grad - 2012-01-09 09:39

tsp42 Wrote:grad: Does the xvba version of xbmc contains the PVR code? if so you could try to diff opdenkamps master branch and my master branch and use it on the xvba version.

Thanks - I have tried to extract a patch. It applies cleanly to the xvba git and compiles. I can also activate it a Live-TV PVR and it does fetch EPG all right. However when I want to watch a recording, it crashes with an arithmetic error. Just to be sure I got everything, could I bother you to quickly review the patch? I've put it here: http://minus.com/mOZIvM6ry#1

I don't know a lot about git. I used git blame to see if a diff came from you or not. Maybe I missed something. Besides the obvious changes in *cmyth* I ran into some changes in the common GUI library right? I skipped everything related to VDPAU, as I'm on AMD graphics. Anything else you know I'll definitely be needing?

Also, don't you think it would be a good idea if you were developing on a branch instead of rebasing your master? Again, I don't know the first thing about git but it appears to be easier to isolate your diffs if you used a branch. Also, if you ever want to submit to upstream you'll be needing that too, right?


- tsp42 - 2012-01-09 21:20

grad: There are some changes to the PVR code but it looks like your diff caught those too. It might be easier for you to create a github account, fork the xvba branch and merge tsp/master with it. For pushing my changes upstream I use a branch based on xbmc or dushmaniacs PVR branch and cherry pick the commits to them.


- grad - 2012-01-09 23:22

tsp42 Wrote:grad: There are some changes to the PVR code but it looks like your diff caught those too.

It works now. I removed some apparently unrelated diffs in the libavcodec and one in atomic.h and (that was probably most important) wiped ~/.xbmc. I'll now start playing and testing the PVR a bit.


- cfetzer - 2012-01-10 23:27

tsp42 Wrote:I've added the LiveTV priority setting to the addon ...

Thanks, it seems to work nice! :-)