[RELEASE] Artwork Downloader - Skin support - Printable Version
+- XBMC Community Forum (http://forum.xbmc.org)
+-- Forum: Development (/forumdisplay.php?fid=32)
+--- Forum: Skin Development (/forumdisplay.php?fid=12)
+--- Thread: [RELEASE] Artwork Downloader - Skin support (/showthread.php?tid=115682)
[RELEASE] Artwork Downloader - Skin support - Martijn - 2011-11-28 13:22
Artwork Downloader has some build-in script command functionality that can be used by skinners.
Version 1.0.0 and higher.
Version 12.0.0 and higher.
Changes in Frodo needed:
This thread is meant question from skinners only!
To see what features are possible see the included readme or the official user thread.
If any changes are made i will make sure to let you know through this thread.
If you have any issues please let me know.
how to use in skins
Offcial user thread:
- Martijn - 2011-11-28 13:25
I still have some issues concerning the correct way of file naming the artwork. So i would like some input from skinners if there are some incorrect file names used.
My question is what are the correct namin conventions used for seasonposters and where to store them? I used the ones from the wiki http://wiki.xbmc.org/index.php?title=Thumbnails
Are these still correct?
- `Black - 2011-11-28 13:39
I had one issue with the latest version concerning the settings... if the user runs the addon for the first time it's impossible to cancel unless you edit 1 setting and 'save' it. Otherwise the script will reopen the settings if you hit esc or click the cancel button. Script should use default settings so the user does not have to set something first.
The season poster naming conventions are still correct.
- Martijn - 2011-11-28 13:48
`Black Wrote:I had one issue with the latest version concerning the settings... if the user runs the addon for the first time it's impossible to cancel unless you edit 1 setting and 'save' it. Otherwise the script will reopen the settings if you hit esc or click the cancel button. Script should use default settings so the user does not have to set something first.
It was intentional so they had to choose first what they want.
If they hit OK it should just save the default values.
Will look into it some more. I am open for suggestion for better way to handle it
So for exmpample season01.tbn is still the one to go?
It could be that
Quote:<tvshow>/<season>/poster.jpgis used so that why i asked. Maybe the same way for seasonbanners?
and the specials?
- Mudislander - 2011-11-28 14:13
Quote:So for exmpample season01.tbn is still the one to go?
I keep all my artwork in the TVShows directory & not in "<tvshow>/<season>/poster.jpg" so therefore "<tvshow>/season01.tbn" works for me
Obvious exceptions are the "extra*" folders.
- `Black - 2011-11-28 14:38
<tvshow>/season01.tbn is correct and the way it should be.
To the settings:
If I run RunScript(script.artwork.downloader, mediatype=movie, medianame=$INFO[ListItem.Title]) for the first time, I can't simply press ok, settings will reopen... I have to enable downloading for movies, then select one of the options, otherwise it won't work. If I change any other setting first, hit ok, I have to kill XBMC because the dialog won't close anymore.
Edit (what I would like to do):
Skin setting for extra fanart and button for downloading all fanarts for movies & tvshows. Then I would like to add a button for downloading extra fanarts for a movie or tv show in the movie/tv show information dialog. All this should work out of the box so that the user doesn't have to set anything in the settings, I would like to add specific settings via attributes (which types to download, background yes/no etc.).
- Big_Noid - 2011-11-28 16:13
Is it intentional that the script forces a reload skin after fanart download? Solo mode btw.
- `Black - 2011-11-28 16:25
I think that is because otherwise a multiimage control wouldn't display the new images.
- Big_Noid - 2011-11-28 16:44
Well, I don't know if that is a real nice solution. DialogVideoInfo closes on a reload skin and there is no option to download extrafanart in solo mode, only fanart.jpg, so I don't think there is a need for reloadskin in solo mode.
- Martijn - 2011-11-28 19:15
When used like
Quote:RunScript(script.artwork.downloader, mediatype=movie, medianame=$INFO[ListItem.Title])it will use the add-on settings so it expects a valid user settings file before continuing. This way the user can chose what is automaticly downloaded and set his limits before continuing. We can set defaults however what are good ones?
I can bypass the settings check when using the GUI mode because they have nothing to do with the settings.
Why do you need the separate buttons when the user can use this dialog?
Quote:RunScript(script.artwork.downloader, mode=gui, mediatype=movie, medianame=$INFO[ListItem.Title])It is DialogSelect.xml the same as Logo-Downloader uses.
BigNoid made a very nice yes/no option for it. If NO you get the dialog and when YES it will auto download.
About the extrafanart/extrathumbs. I left it out because i needed to figure out a good way to handle this using the GUI mode. It is a bit tricky (because i'm quite new to coding). It will be downloaded when it is enabled in settings and use it like the code above.
I just tried it and when only enabled tvshow posters it continued. The problem you might have is that it found some faulty setting from the previous time you installed it. So cleaning out the userdata file can help.
I agree agree it maybe better to use a yes/no button.
The settings check was added because apperently some user were not able to understand that they needed to enable something and they complained that it didn't do anything.
Will look at adding the attributes because they will be needed anyway.