(2012-03-20, 05:15)Balinus Wrote: Hello!

I've added support for Artwork Downloader in Shade and there's some strange behavior. I wouldn't be surprised the problem is my implementation but who knows..! The script works, but strangely.

Here's what happen : in the info screen (DialogVideoInfo.xml), I've added the following code :

PHP Code:

<control type="button" id="13">
               <description>Get Artwork</description>
               <include>ButtonInfoDialogsCommonValues</include>
        <onclick condition="Container.Content(tvshows)">XBMC.RunScript(script.artwork.downloader, mode=gui, mediatype=tvshow, medianame=$INFO[ListItem.TVShowTitle])</onclick>
        <onclick condition="Container.Content(movies)">XBMC.RunScript(script.artwork.downloader, mode=gui, mediatype=movie, medianame=$INFO[ListItem.Title],mediapath=$INFO[ListItem.Path])</onclick>
        <visible>[Container.Content(tvshows)|Container.Content(movies)]+system.hasaddon(script.artwork.downloader)</visible>
              <label>Get Artwork</label>                                                    
 </control> 


Now, when I click Get Artwork for a movie, I have a dialog where i choose the movie, but then, it's just like the "information screen" is loaded again and the window where I could chose the type of artwork is behind the information screen. It's just when I escape from the information screen and go back to movie selection that the window to chose the type of media is shown.

Thanks for any help!

edit - Skin is available here in case someone would like to test it out : here or here

(2012-03-20, 12:48)jfcarroll Wrote: Please let me know if this fixes the problem. If so, I'll submit a PR:

https://github.com/jimfcarroll/xbmc/commit/eb2bfb619ccc2d7e72737a9586e0ee31b6b2ede0

EDIT: This is meant to only fix the progress dialog deadlock. Please let me know if it does that.
EDIT2: If someone isn't sure how to apply this, let me know, I'll post instructions.

It's OK for me.
I tested 10 times and no freeze append.
I will retested later, but actually work perfectly.

If any guys want testing... http://passion-xbmc.org/gros_fichiers/frost/XBMC.exe




thanks again jfcarroll

frost

(2012-03-20, 06:25)giftie Wrote: ID 13 is a built in function, try using a higher ID number.

(2012-03-20, 13:59)FrostBox Wrote:

It's OK for me.
I tested 10 times and no freeze append.
I will retested later, but actually work perfectly.

If any guys want testing... http://passion-xbmc.org/gros_fichiers/frost/XBMC.exe

frost

(2012-03-20, 14:23)mikebzh44 Wrote: Bas news.

Using xbmc.exe from Frostbox + Glass + Artwork downloader : freeze each time I call addon

Maybe I will be able to produce traceback file on my PC with VC++ this evening (France time).

(2012-03-20, 15:25)Balinus Wrote:

(2012-03-20, 06:25)giftie Wrote: ID 13 is a built in function, try using a higher ID number.

Thanks! Using ID 14 solved the problem.

edit - Where could I see a list of ID associated with built-in functions? Is is here? : http://wiki.xbmc.org/index.php?title=Window_IDs
This would mean that ID 14 is also associated with a built-in function? In this case "weathersettings" ?

(2012-03-20, 18:49)mikebzh44 Wrote: For exemple, when using Artwork Downloader in GUI mode on Avatar movie, you can only download 3 items for the moment (1 clearlogo and 2 cdart) so items list should be :

Logo
Disc art

(2012-03-20, 15:50)Wanilton Wrote: Update translate for portuguese (Brazil)
link for download here:
http://dl.dropbox.com/u/25170804/Artwork/Portuguese%20%28brazil%29/Portuguese%20%28brazil%29/strings.xml

Addon run fine for me with new xbmc.exe, don´t crash..

(2012-03-20, 17:49)butchabay Wrote:

(2012-03-20, 15:25)Balinus Wrote:

(2012-03-20, 06:25)giftie Wrote: ID 13 is a built in function, try using a higher ID number.

Thanks! Using ID 14 solved the problem.

edit - Where could I see a list of ID associated with built-in functions? Is is here? : http://wiki.xbmc.org/index.php?title=Window_IDs
This would mean that ID 14 is also associated with a built-in function? In this case "weathersettings" ?

Great, thanks a lot!

No these are window id's ...

here a list of built in controls ... in your case DialogVideoInfo.xml

http://wiki.xbmc.org/index.php?title=List_of_Built_In_Controls