Kodi Community Forum
[RELEASE] Artwork Downloader - Skin support - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+---- Forum: Skin helper addons (https://forum.kodi.tv/forumdisplay.php?fid=300)
+---- Thread: [RELEASE] Artwork Downloader - Skin support (/showthread.php?tid=115682)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31

RE: [RELEASE] Artwork Downloader - Skin support - jfcarroll - 2012-03-20

Sorry guys. JMarshall just pointed out that my fix wasn't quite right. Here it is again. This one might prove better:

https://github.com/jimfcarroll/xbmc/commit/ed9cc6cc920f61cf1070394d356fc4488fcf599d

It's also now the PR: https://github.com/xbmc/xbmc/pull/790

RE: [RELEASE] Artwork Downloader - Skin support - mikebzh44 - 2012-03-20

Script some times abort :

http://paste.ubuntu.com/892740/

Due to movie french name ?

RE: [RELEASE] Artwork Downloader - Skin support - Martijn - 2012-03-20

(2012-03-20, 22:12)mikebzh44 Wrote: Script some times abort :

http://paste.ubuntu.com/892740/

Due to movie french name ?

Well that shouldn't matter.

can you change line 311 of default.py from:
PHP Code:
if itemname in currentitem["name"]: 
to
PHP Code:
if normalize_string(itemname) == normalize_string(currentitem["name"]): 
and see if that helps?

RE: [RELEASE] Artwork Downloader - Skin support - Wanilton - 2012-03-20

Now strings ok portuguese (Brazil), sorry, download here:
http://dl.dropbox.com/u/25170804/Artwork/Portuguese%20%28brazil%29/Portuguese%20%28brazil%29/strings.xml

thanks.

RE: [RELEASE] Artwork Downloader - Skin support - mikebzh44 - 2012-03-21

(2012-03-20, 22:24)Martijn Wrote: Well that shouldn't matter.

can you change line 311 of default.py from:
PHP Code:
if itemname in currentitem["name"]: 
to
PHP Code:
if normalize_string(itemname) == normalize_string(currentitem["name"]): 
and see if that helps?
Everything work fine with this modification.

RE: [RELEASE] Artwork Downloader - Skin support - Martijn - 2012-03-21

(2012-03-21, 00:10)mikebzh44 Wrote:
(2012-03-20, 22:24)Martijn Wrote: Well that shouldn't matter.

can you change line 311 of default.py from:
PHP Code:
if itemname in currentitem["name"]: 
to
PHP Code:
if normalize_string(itemname) == normalize_string(currentitem["name"]): 
and see if that helps?
Everything work fine with this modification.

Thanks. Thought so.
And I just did a repo update. Now they're gonna kill me if I do another.... Sad
So I'll wait some more days before doing that

RE: [RELEASE] Artwork Downloader - Skin support - Martijn - 2012-03-21

(2012-03-20, 18:49)mikebzh44 Wrote: 2 - When using mode=gui, is it possible to display only valid items for the movie instead of default list :

Poster
Fanart
Logo
Clearart
Disc art

For exemple, when using Artwork Downloader in GUI mode on Avatar movie, you can only download 3 items for the moment (1 clearlogo and 2 cdart) so items list should be :

Logo
Disc art

That was actually much easier than I thought

Could you try it?
https://github.com/paddycarey/script.artwork.downloader/downloads


RE: [RELEASE] Artwork Downloader - Skin support - mikebzh44 - 2012-03-21

It's OK, for Avatar, list items display only 2 items and for movies with only 1 item ("King's speech" or "Driven"), no more list and item is directly shown.

Great job.

RE: [RELEASE] Artwork Downloader - Skin support - BigNoid - 2012-03-21

Works great. Much better now that you know what's available. Did not notice any slowdowns compared to previous version either.
So can we expect an update in the repo tonight Big Grin

RE: [RELEASE] Artwork Downloader - Skin support - Martijn - 2012-03-21

(2012-03-21, 15:14)Big_Noid Wrote: Works great. Much better now that you know what's available. Did not notice any slowdowns compared to previous version either.
So can we expect an update in the repo tonight Big Grin

hehe no. probably this weekend Wink
Need to make sure there are no other issues popping up.

RE: [RELEASE] Artwork Downloader - Skin support - Ghostdivision - 2012-03-22

So after i raised the limiter to 4, it seems to go in according to the log and deleting fanart rated to low? So is this an easy way to remove that art which was below the limiter...the program automatically does it?


Just an example in the log


Artwork Downloader: [Goodfellas] Deleted (Rating too low: 3.5): M:\Blu-Ray\Goodfellas.bluray\BDMV/extrafanart/6wPqONb9wMDeEwTHYLbnxuUU1eA.jpg
15:59:00 T:3980 NOTICE: Artwork Downloader: [Goodfellas] Deleted (Rating too low: 0.5): M:\Blu-Ray\Goodfellas.bluray\BDMV/extrafanart/uwKvcYsxAkJZm3gKgYrFodoRJyP.jpg

Theres only a few of these entries though...
Also i went in and deleted all the fan art and put the limiter back to 4... yet im seeing it is still grabbing artwork that is rated 0 or has no votes?



RE: [RELEASE] Artwork Downloader - Skin support - Martijn - 2012-03-22

(2012-03-22, 00:03)Ghostdivision Wrote: So after i raised the limiter to 4, it seems to go in according to the log and deleting fanart rated to low? So is this an easy way to remove that art which was below the limiter...the program automatically does it?


Just an example in the log


Artwork Downloader: [Goodfellas] Deleted (Rating too low: 3.5): M:\Blu-Ray\Goodfellas.bluray\BDMV/extrafanart/6wPqONb9wMDeEwTHYLbnxuUU1eA.jpg
15:59:00 T:3980 NOTICE: Artwork Downloader: [Goodfellas] Deleted (Rating too low: 0.5): M:\Blu-Ray\Goodfellas.bluray\BDMV/extrafanart/uwKvcYsxAkJZm3gKgYrFodoRJyP.jpg

Theres only a few of these entries though...
Also i went in and deleted all the fan art and put the limiter back to 4... yet im seeing it is still grabbing artwork that is rated 0 or has no votes?
Same answer as before...


That's a reason to go voting on artwork..
If the none rated aren't included you wouldn't get anything


RE: [RELEASE] Artwork Downloader - Skin support - Martijn - 2012-03-22

(2012-03-21, 15:45)Martijn Wrote:
(2012-03-21, 15:14)Big_Noid Wrote: Works great. Much better now that you know what's available. Did not notice any slowdowns compared to previous version either.
So can we expect an update in the repo tonight Big Grin

hehe no. probably this weekend Wink
Need to make sure there are no other issues popping up.

Had to push the new version to repo because it took the http://fanart.tv server offline because of the API calls it made.
API data is now cached 96 hours and API calls to the fanart site have 2 second interval.
Hopefully when things are sorted this will be brought back to an acceptable minimum.

The smart dialog is added.

The reason why you can't download anything...... - Martijn - 2012-03-25

The reason why you can't download anything from http://fanart.tv:

http://forum.xbmc.org/showthread.php?tid=87577&pid=1053539#pid1053539

or read their newsletter

RE: [RELEASE] Artwork Downloader - Skin support - Ghostdivision - 2012-03-28

(2012-03-22, 00:15)Martijn Wrote:
(2012-03-22, 00:03)Ghostdivision Wrote: So after i raised the limiter to 4, it seems to go in according to the log and deleting fanart rated to low? So is this an easy way to remove that art which was below the limiter...the program automatically does it?


Just an example in the log


Artwork Downloader: [Goodfellas] Deleted (Rating too low: 3.5): M:\Blu-Ray\Goodfellas.bluray\BDMV/extrafanart/6wPqONb9wMDeEwTHYLbnxuUU1eA.jpg
15:59:00 T:3980 NOTICE: Artwork Downloader: [Goodfellas] Deleted (Rating too low: 0.5): M:\Blu-Ray\Goodfellas.bluray\BDMV/extrafanart/uwKvcYsxAkJZm3gKgYrFodoRJyP.jpg

Theres only a few of these entries though...
Also i went in and deleted all the fan art and put the limiter back to 4... yet im seeing it is still grabbing artwork that is rated 0 or has no votes?
Same answer as before...


That's a reason to go voting on artwork..
If the none rated aren't included you wouldn't get anything

Just curious what you mean if the none rated arent included you wouldnt get anything?

I see lots of artwork for various movies that are rated.