+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+---- Forum: Skin helper addons (https://forum.kodi.tv/forumdisplay.php?fid=300)
+---- Thread: [RELEASE] Artwork Downloader - Skin support (/showthread.php?tid=115682)
RE: [RELEASE] Artwork Downloader - Skin support - `Black - 2012-11-08
On Windows (latest nightly) I ran the same command I posted earlier, AD said "Downloaded 211" which is obviously wrong (or does it download all images? scan is somewhat slow) because there were only 20 landscape images missing. Download worked correctly but I can't access ListItem.Art(landscape), it's empty.
Also I'm unable to change a landscape image, if I select another in the gui mode, nothing changes. And if I ran the command again, it's "Downloaded 211" where it should be 0 because everything is stored locally... something is not working correctly, I will check the logs if I have the time.
RE: [RELEASE] Artwork Downloader - Skin support - MassIV - 2012-11-08
And if you run it with the ID?
Code:
XBMC.RunScript(script.artwork.downloader,mode=custom,mediatype=tvshow,dbid=$INFO[ListItem.DBID],landscape)btw, is it possible to run this just for 1 container? And would that be faster on a small container?
Code:
XBMC.RunScript(script.artwork.downloader,mode=custom,mediatype=tvshow,dbid=$INFO[Container(8000).ListItem.DBID],clearlogo)Code:
XBMC.RunScript(script.artwork.downloader,mode=custom,mediatype=tvshow, mediatype=movie,clearlogo)[RELEASE] Artwork Downloader - Skin support - `Black - 2012-11-08
No because id is for 1 item only. I want to update/add everything but that doesn't seem to work properly at the moment.
RE: [RELEASE] Artwork Downloader - Skin support - MassIV - 2012-11-08
Yeah i meant, if that works you can rule out everything besides the bulk part.
Was just double checking, not knowing what you had and had not tried.
RE: [RELEASE] Artwork Downloader - Skin support - Martijn - 2012-11-08
(2012-11-08, 02:38)`Black Wrote: On Windows (latest nightly) I ran the same command I posted earlier, AD said "Downloaded 211" which is obviously wrong (or does it download all images? scan is somewhat slow) because there were only 20 landscape images missing. Download worked correctly but I can't access ListItem.Art(landscape), it's empty.
Also I'm unable to change a landscape image, if I select another in the gui mode, nothing changes. And if I ran the command again, it's "Downloaded 211" where it should be 0 because everything is stored locally... something is not working correctly, I will check the logs if I have the time.
Possible that there is some old cached data that needs refreshing after the changes in the code.
Delete commoncache.db from userdata folder and try again. When i have some time i will do some more extensive tests
RE: [RELEASE] Artwork Downloader - Skin support - Hitcher - 2012-11-08
Deleted commoncache.db and re-run, still didn't pick-up local files -
Overwriting files -
So if there's nothing listed to download local files will never be used?
RE: [RELEASE] Artwork Downloader - Skin support - Martijn - 2012-11-08
(2012-11-08, 10:49)Hitcher Wrote: So if there's nothing listed to download local files will never be used?
correct. too much code to change for this
RE: [RELEASE] Artwork Downloader - Skin support - Hitcher - 2012-11-08
No worries, I'll just use a variable so if ListItem.Art(landscape) is empty it'll use the path + landscape.jpg.
RE: [RELEASE] Artwork Downloader - Skin support - Martijn - 2012-11-08
(2012-11-08, 15:19)Hitcher Wrote: No worries, I'll just use a variable so if ListItem.Art(landscape) is empty it'll use the path + landscape.png.
ideally it won't be empty. just file a request or make one/upload it
RE: [RELEASE] Artwork Downloader - Skin support - `Black - 2012-11-08
Code:
JSONRPC: Failed to parse '{"jsonrpc": "2.0", "method": "VideoLibrary.SetTVShowDetails", "params": { "tvshowid": 2, "art": { "landscape": "D:\Serien\Arrow/landscape.jpg" }}, "id": 1 }'That's whats happening for me.
To the other problem.. I think we should be able to choose local images in the gui as well as AD should pick them up also if nothing is found online. I think it shouldn't even look online if a local image is available.
RE: [RELEASE] Artwork Downloader - Skin support - Martijn - 2012-11-08
(2012-11-08, 15:38)`Black Wrote:Code:JSONRPC: Failed to parse '{"jsonrpc": "2.0", "method": "VideoLibrary.SetTVShowDetails", "params": { "tvshowid": 2, "art": { "landscape": "D:\Serien\Arrow/landscape.jpg" }}, "id": 1 }'
That's whats happening for me.
Will fix
Quote:To the other problem.. I think we should be able to choose local images in the gui as well as AD should pick them up also if nothing is found online. I think it shouldn't even look online if a local image is available.
(2012-11-08, 15:03)Martijn Wrote:(2012-11-08, 10:49)Hitcher Wrote: So if there's nothing listed to download local files will never be used?
correct. too much code to change for this
RE: [RELEASE] Artwork Downloader - Skin support - Hitcher - 2012-11-08
Also, when using the default 'Get Images' button in DialogVideoInfo at season level sets the TV Show image instead of the Season image.
RE: [RELEASE] Artwork Downloader - Skin support - Martijn - 2012-11-08
(2012-11-08, 16:08)Hitcher Wrote: Also, when using the default 'Get Images' button in DialogVideoInfo at season level sets the TV Show image instead of the Season image.
This cannot be done.
Frodo+1
RE: [RELEASE] Artwork Downloader - Skin support - Martijn - 2012-11-08
@Black
Try to replace
https://github.com/XBMC-Addons/script.artwork.downloader/blob/master/default.py#L599
with
PHP Code:
item['url'] = item['localfilename'].replace('\\','\\\\')
RE: [RELEASE] Artwork Downloader - Skin support - Hitcher - 2012-11-08
OK, but season art (banner and landscape in my case) isn't getting added to the library when doing a full run+overwrite even though the images are saved to the tv show folders.