+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+---- Forum: Skin helper addons (https://forum.kodi.tv/forumdisplay.php?fid=300)
+---- Thread: [RELEASE] Artwork Downloader - Skin support (/showthread.php?tid=115682)
- Jeroen - 2011-12-11
Martijn Wrote:@Jeroen (and others)
Could you try this one?
script.artwork.downloader-Eden(1.0.2)-RC5.zip
Do only notify on finished custom/gui mode
Excellent, works like a charm
Cheers!
- fmronan - 2011-12-12
Like many french users I use http://passion-xbmc.org/scraper/index2.php?Page=Home
http://passion-xbmc.org/addons/?Page=View&ID=metadata.cine.passion-xbmc.org
- `Black - 2011-12-12
They seem to cut off tt from the ID which is necessary for TMDB.
@Martijn
I would add a simple check if the ID starts with tt and add it if not. If it's not working then, user has to switch the scraper.
- Martijn - 2011-12-12
`Black Wrote:They seem to cut off tt from the ID which is necessary for TMDB.
@Martijn
I would add a simple check if the ID starts with tt and add it if not. If it's not working then, user has to switch the scraper.
I'm not happy that we have to fix scraper flaws so i would urge them just do like all other scraper and keep the real IMDB Id.
Will see what can be done but I stand by my point it has to be fixed in the scraper anyway!
Edit:
They don't even have a fixed lenght. So it has to be several lines of code to get the correct Id again.
Can't imagine we are the only add-on that they have problems with. The rating update script won't work either because it also needs the full Id.
Not only TMDB will require a tt.... Id also http://fanart.tv will need it on the new site.
version update - Martijn - 2011-12-13
1.0.2
- Added: Log summary on failed/missing items
- Added: Support the providers message on finished
- Added: Custom mode pops-up a image selection when run on single tvshow/movie
- Added: First retrieve image list(s) and then do batch download
- Changed: Run add-on on specified time of day instead on interval
- Fixed: Problems caused with UTF-8 characters in titles
- Fixed: Some images didn't show in GUI because of spaces in image URL
- Fixed: Show correct download count in log
- Fixed: Don't show dialog.OK when finished run in silent mode
- fmronan - 2011-12-13
perhaps it's possible to add something like that?
Code:
Add prefix tt on request ( true | false )- Martijn - 2011-12-13
fmronan Wrote:perhaps it's possible to add something like that?
Code:Add prefix tt on request ( true | false )
I am sorry but we discussed this internally with the fellow coders and we decided that we are not going to solve scraper problems in our script.
It can be done however if cine-passion doesn't store the correct IMDB Id it's not our problem. Every other scraper does it correctly.
They should fix it in the scraper and then maybe we can think of an in between solution for the ones already scraped into the xbmc library.
- fmronan - 2011-12-13
a little patch for your script
Team Passion
"tt%07d" % int( id.strip( "t" ) )
test
Code:
id = "82945"
print id
print "tt%07d" % int( id.strip( "t" ) )
print
id = "tt1318514"
print id
print "tt%07d" % int( id.strip( "t" ) )- Martijn - 2011-12-13
fmronan Wrote:a little patch for your script
Team Passion
"tt%07d" % int( id.strip( "t" ) )
test
Code:id = "82945"
print id
print "tt%07d" % int( id.strip( "t" ) )
id = "tt1318514"
print id
print "tt%07d" % int( id.strip( "t" ) )
Yes i know how to fix but that's not the point. They can apply that patch as easily to their scraper.
Like i explained it should be fixed in the scraper and not in our script. So if they make sure from now on they are storing the ID like it should we can apply the patch below.
This will be our patch:
cine-passion fix
- fmronan - 2011-12-13
Thank you kindly add the patch in the script, the team passion will correct Id , but we can not force users to recreate their base, so we need the script with the patch.
- Martijn - 2011-12-13
fmronan Wrote:Thank you kindly add the patch in the script, the team passion will correct Id , but we can not force users to recreate their base, so we need the script with the patch.
That is understandable that users won't recreate their database and we won't expect them to
I would like to ask you if you could test the patch to make sure it works?
I'll send you a PM will the patched version.
- fmronan - 2011-12-13
no problem for make every test, thanks
bug release - Martijn - 2011-12-13
Small bugfix release:
script.artwork.downloader-Eden(1.0.3)-RC1.zip
1.0.3 RC1
- Fixed: Error below limit check
- Added: Try conversion of non standard IMDB Id
- ekim232 - 2011-12-16
I am on 1.0.2 and I am trying to add buttons to my videoinfo screen for extrafanart and extrathumbs. They are two seperate buttons and extrafanart works as expected, but I cannot get extrathumbs to download any. My button codes are below. If I run the script as an addon it, all extrathumbs will download.
<onclick>RunScript(script.artwork.downloader,mode=custom,mediatype=movie,medianame=$INFO[ListItem.Title],extrafanart)</onclick>
<onclick>RunScript(script.artwork.downloader,mode=custom,mediatype=movie,medianame=$INFO[ListItem.Title],extrathumbs)</onclick>
Any one got any ideas will the extrathumbs will not download with this?
- Martijn - 2011-12-16
ekim232 Wrote:Any one got any ideas will the extrathumbs will not download with this?
Yes i know
Please try this one:
script.artwork.downloader-Eden(1.0.3)-RC2.zip
Fixes:
- downloading artwork specific for movies