Kodi Community Forum
Release OzWeather - Australian Weather Addon using BOM data inc. animated radar support - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Weather Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=155)
+---- Thread: Release OzWeather - Australian Weather Addon using BOM data inc. animated radar support (/showthread.php?tid=116905)



RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - bossanova808 - 2021-04-22

Yeah so I'd need a full debug log (from startup to running the patcher) to have a chance with that...

It's complaining about

Code:

...
2021-04-22 14:51:54.679 T:2762 WARNING <general>: Skin has invalid include: BottomMenuLayout
2021-04-22 14:51:54.685 T:2762 ERROR <general>: Misplaced [
2021-04-22 14:51:54.686 T:2762 ERROR <general>: Error parsing boolean expression [weather.isfetched] + [!string.isempty($info[window.property(current.pressure)])>]

...and I presume the issue is somewhere there but that isn't in any file included with the skin patcher, so not sure really.  Doesn't OSMC use its own skin?  If so it shouldn't patch it at all.

But yeah, without the debug log stuff I can't really tell much.


RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - DavidFW1960 - 2021-04-22

(2021-04-22, 05:26)bossanova808 Wrote: Hmm, might do a round one of changes with the new BOM data, and the old radar, then look at that - considerably more complicated....but would be nice....

I look in the MyWeather.xml file after I run the script and it doesn't seem to contain the 'OzWeather Stuff' section. IF I manually copy the files and restart it all works again. (I use Estuary)


RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - DavidFW1960 - 2021-04-22

(2021-04-22, 07:29)bossanova808 Wrote: Yeah so I'd need a full debug log (from startup to running the patcher) to have a chance with that...
That was a full debug log from startup including running the patcher and then going to the radar screen.
I am using Estuary not the OSMC skin


RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - bossanova808 - 2021-04-22

Full debug log....can't do anything without it...if you don't won't to link it here or something, just DM me the link.


RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - bossanova808 - 2021-04-22

The first line in that log is

2021-04-22 14:51:41.767 T:11454 INFO <general>: ### OzWeather Skin Patcher 0.0.6 - Starting...

....that's definitely not a full debug log....


RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - DavidFW1960 - 2021-04-22

(2021-04-22, 07:55)bossanova808 Wrote: The first line in that log is

2021-04-22 14:51:41.767 T:11454 INFO <general>: ### OzWeather Skin Patcher 0.0.6 - Starting...

....that's definitely not a full debug log....



RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - DavidFW1960 - 2021-04-22

(2021-04-22, 08:17)DavidFW1960 Wrote:
(2021-04-22, 07:55)bossanova808 Wrote: The first line in that log is

2021-04-22 14:51:41.767 T:11454 INFO <general>: ### OzWeather Skin Patcher 0.0.6 - Starting...

....that's definitely not a full debug log....
First 8000 lines https://paste.kodi.tv/edudimelam.kodi
Last 8000 https://paste.kodi.tv/pulepipila.kodi


RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - bossanova808 - 2021-04-22

Thanks

So everything looks fine to me....can you actually see this file:

/usr/share/kodi/addons/skin.estuary/xml/MyWeather.xml.original

?

That should be created if things are working.  I presume that is there as it's not trying to make a backup again.

It seems to think it succeeded, but my guess is maybe the folder isn't writeable by Kodi?   But then I'd expect an error, and am not sure why it would not raise one if it had an issue with the copy.

The code is trivial

python:

        log(f'Copying OzWeather MyWeather.xml to {config.xml_destination_folder}')
        success = xbmcvfs.copy(config.new_myweather_xml, config.current_myweather_xml)
        if success:
            log("...done")
        else:
            log("...failed!  Is the skin folder writeable?")
            notify('Exiting - as error when copying OzWeather MyWeather.xml - is skin folder writeable?')
            sys.exit(1)

and it writes `...done` so we can assume Kodi thinks the file copied.  It _should_ then reload the skin and be ok. 

Just can't see why a manual copy would work and this wouldn't to be honest....when it does do the skin reload, it hits a bunch of issues I don't understand:

Code:

2021-04-22 16:12:37.957 T:2762 WARNING <general>: Skin has invalid include: CommonBackground
2021-04-22 16:12:37.957 T:2762 WARNING <general>: Skin has invalid include: Header
2021-04-22 16:12:37.957 T:2762 WARNING <general>: Skin has invalid include: CommonNowPlaying
2021-04-22 16:12:37.957 T:2762 WARNING <general>: Skin has invalid include: Footer
2021-04-22 16:12:37.957 T:2762 WARNING <general>: Skin has invalid include: MediaWindowTitleCommons
2021-04-22 16:12:37.962 T:2762 WARNING <general>: Skin has invalid include: VisibleFadeEffect
2021-04-22 16:12:37.962 T:2762 WARNING <general>: Skin has invalid include: BottomMenuLayout
2021-04-22 16:12:37.971 T:2762 ERROR <general>: Misplaced [
2021-04-22 16:12:37.971 T:2762 ERROR <general>: Error parsing boolean expression [weather.isfetched] + [!string.isempty($info[window.property(current.pressure)])>]

...none of those should happen and I don't see them in my logs when reloading estuary, for example. Have you tried a reboot after running it, does that change anything?  I don't know why but your skin reload is definitely going wrong.

When you manually copy it I guess you are ssh-ing in?


RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - DavidFW1960 - 2021-04-22

(2021-04-22, 08:35)bossanova808 Wrote: Thanks

So everything looks fine to me....can you actually see this file:

/usr/share/kodi/addons/skin.estuary/xml/MyWeather.xml.original

?

That should be created if things are working.  I presume that is there as it's not trying to make a backup again.

It seems to think it succeeded, but my guess is maybe the folder isn't writeable by Kodi?   But then I'd expect an error, and am not sure why it would not raise one if it had an issue with the copy.

The code is trivial

python:

        log(f'Copying OzWeather MyWeather.xml to {config.xml_destination_folder}')
        success = xbmcvfs.copy(config.new_myweather_xml, config.current_myweather_xml)
        if success:
            log("...done")
        else:
            log("...failed!  Is the skin folder writeable?")
            notify('Exiting - as error when copying OzWeather MyWeather.xml - is skin folder writeable?')
            sys.exit(1)

and it writes `...done` so we can assume Kodi thinks the file copied.  It _should_ then reload the skin and be ok. 

Just can't see why a manual copy would work and this wouldn't to be honest....when it does do the skin reload, it hits a bunch of issues I don't understand:

Code:

2021-04-22 16:12:37.957 T:2762 WARNING <general>: Skin has invalid include: CommonBackground
2021-04-22 16:12:37.957 T:2762 WARNING <general>: Skin has invalid include: Header
2021-04-22 16:12:37.957 T:2762 WARNING <general>: Skin has invalid include: CommonNowPlaying
2021-04-22 16:12:37.957 T:2762 WARNING <general>: Skin has invalid include: Footer
2021-04-22 16:12:37.957 T:2762 WARNING <general>: Skin has invalid include: MediaWindowTitleCommons
2021-04-22 16:12:37.962 T:2762 WARNING <general>: Skin has invalid include: VisibleFadeEffect
2021-04-22 16:12:37.962 T:2762 WARNING <general>: Skin has invalid include: BottomMenuLayout
2021-04-22 16:12:37.971 T:2762 ERROR <general>: Misplaced [
2021-04-22 16:12:37.971 T:2762 ERROR <general>: Error parsing boolean expression [weather.isfetched] + [!string.isempty($info[window.property(current.pressure)])>]

...none of those should happen and I don't see them in my logs when reloading estuary, for example. Have you tried a reboot after running it, does that change anything?  I don't know why but your skin reload is definitely going wrong.

When you manually copy it I guess you are ssh-ing in?

I do see the file (.original)
No difference if it reboots
I am ssh'ing in and I have a script to copy the file.

Did you see where I said the MyWeather.XML file being copied over does not contain the OzWeather section?


RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - bossanova808 - 2021-04-22

I did...the question is...why?

Unless you've somehow copied over the one that came with the addon (is that a possibility?), it should copy over just fine (and it says it is).  Works here, I just tested it from scratch again recently.

Maybe check the one in the addon folder is still the original with the OzWeather section?

Or just uninstall and re-install the addon, I guess.


RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - DavidFW1960 - 2021-04-22

Where is the addon folder with the modified file for the skin that you copy from?
See I probably ran the script after I had already patched the skin manually when I was running Leia.
Pretty sure I removed and reinstalled the skin on my ChromeCast though and it has the same issue (although I would have also restored a backup on that that was manually patched as well) I can't work out where the ChromeCast hides all these install files either..


RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - bossanova808 - 2021-04-22

2021-04-22 16:12:21.591 T:3143    DEBUG <general>: ### OzWeather Skin Patcher 0.0.6 - special://skin Is [/usr/share/kodi/addons/skin.estuary/]
2021-04-22 16:12:21.591 T:3143    DEBUG <general>: ### OzWeather Skin Patcher 0.0.6 - CWD is /home/osmc/.kodi/addons/script.ozweather-skinpatcher/
2021-04-22 16:12:21.592 T:3143    DEBUG <general>: ### OzWeather Skin Patcher 0.0.6 - Patch VideoFullScreen is False
2021-04-22 16:12:21.592 T:3143    DEBUG <general>: ### OzWeather Skin Patcher 0.0.6 - Estuary in skin folder name...proceeding...
2021-04-22 16:12:21.593 T:3143    DEBUG <general>: ### OzWeather Skin Patcher 0.0.6 - Skin XML folder is /usr/share/kodi/addons/skin.estuary/xml
2021-04-22 16:12:21.593 T:3143    DEBUG <general>: ### OzWeather Skin Patcher 0.0.6 - Current MyWeather.xml is /usr/share/kodi/addons/skin.estuary/xml/MyWeather.xml
2021-04-22 16:12:21.593 T:3143    DEBUG <general>: ### OzWeather Skin Patcher 0.0.6 - Current VideoFullScreen.xml is /usr/share/kodi/addons/skin.estuary/xml/VideoFullScreen.xml
2021-04-22 16:12:21.593 T:3143    DEBUG <general>: ### OzWeather Skin Patcher 0.0.6 - New MyWeather.xml is /home/osmc/.kodi/addons/script.ozweather-skinpatcher/resources/skin-files/estuary/MyWeather.xml
2021-04-22 16:12:21.594 T:3143    DEBUG <general>: ### OzWeather Skin Patcher 0.0.6 - Backup MyWeather.xml will be /usr/share/kodi/addons/skin.estuary/xml/MyWeather.xml.original
2021-04-22 16:12:21.594 T:3143    DEBUG <general>: ### OzWeather Skin Patcher 0.0.6 - Backup VideoFullScreen.xml will be /usr/share/kodi/addons/skin.estuary/xml/VideoFullScreen.xml.original


RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - DavidFW1960 - 2021-04-22

So I see
osmc@osmc:~/.kodi/addons/script.ozweather-skinpatcher/resources/skin-files/estuary$
Contains MyWeather.xml
osmc@osmc:~/.kodi/addons/script.ozweather-skinpatcher/resources/skin-files/estuary$ cat MyWeather.xml | grep OzWeather
<!-- OzWeather Stuff here -->
<label>OzWeather for Kodi ($INFO[Window.Property(WeatherVersion)]) [CR]Data from and © Australian Bureau of Meteorology</label>
<!-- End OzWeather stuff -->
osmc@osmc:~/.kodi/addons/script.ozweather-skinpatcher/resources/skin-files/estuary$ cd skin-files/estuary/

So that is the patched file.


RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - bossanova808 - 2021-04-22

Honestly, no clue right now, sorry.  You'll have to stick with manual copy I guess.

I'll look at it all as soon as I have some time to dig in to the re-write etc (as there will be some skin changes with that too most likely).

Sorry!


RE: OzWeather - Australian Weather Addon using BOM data inc. animated radar support - DavidFW1960 - 2021-04-26

OK so I killed my Vero and reinstalled from an image and with a fresh install (Matrix) the patcher fails and gives that black screen I posted above.
BUT
If I copy the MyWeather.xml you posted way back for manually updating a skin it works. So I then overwrote the MyWeather.xml in the skin patcher for both the OSMC/Vero and my Chromecast with Google TV and I patch the skin and both of them are now working as expected so it seems that the file you are distributing in the patcher for Estuary isn't the correct one.....

Anyway it's working as per expectations now.