[PATCH]Move subtitles so the OSD wont block them - Printable Version
+- XBMC Community Forum (http://forum.xbmc.org)
+-- Forum: Development (/forumdisplay.php?fid=32)
+--- Forum: Development (/forumdisplay.php?fid=93)
+--- Thread: [PATCH]Move subtitles so the OSD wont block them (/showthread.php?tid=124510)
Pages: 1 2
[PATCH]Move subtitles so the OSD wont block them - eyebeeyou - 2012-03-03 08:23
I attached a patch that moves the subtitles when the OSD is active so the OSD won't block the subtitles.
- epoke - 2012-03-04 14:10
I have tested this patch. Nice on confluence skin. But, every skin have different osd position. In Aeon Nox, this skin have osd on top of the screen, move up subtitle is not good choice.
I figured that would be something like that - eyebeeyou - 2012-03-04 18:12
I'm not familiar with the skins.
Do you think this can be in some way part of the skin?
Or can I get the skin info from the place I wrote the code? I can move the subs down if they are on the top in relevant skins.
I can also have this as an option, I can add in the place of the configuration of the subtitles position an option for "fixed+", where now the default is "fixed", and only in this case move the subtitles.
- jmarshall - 2012-03-04 23:22
Yeah, this isn't going to fly as-is.
To be honest I don't really get why this is much of a problem: how often do you have the OSD up while you're wanting to read the subtitles anyway?
- john.doe - 2012-03-05 07:46
Sometimes when the mouse moves by accident it just blocks the subtitles for a few seconds.
What should be done to do "make it fly"?
- jmarshall - 2012-03-05 10:07
A cat is a great solution to mice problems
Seriously, I'm betting less than 1% of users have a mouse anywhere near XBMC, so that in and of itself isn't a strong enough reason for me (I'd be far more annoyed at the fact that the OSD pops up ruining the experience).
The only thing that would "make it fly" is making it work across all skins: The only way that's going to work is if you remove the OSD from it's current place.
- eyebeeyou - 2012-03-05 13:07
jmarshall Wrote:A cat is a great solution to mice problems
I use a PC remote control with a track ball, so sometimes when it moves the OSD is popping up. And it does ruin the experience, but not being able to read the subtitles is even more frustrating.
I don't understand what you mean by "remove the OSD from it's current place"? what is it's place?
- jmarshall - 2012-03-05 21:58
The only solution that will work completely is making sure that the OSD doesn't come on ever.
The solution that will work most (but not all) the time is making sure that the OSD is at the top of the screen rather than the bottom. There's nothing that stops subtitles being displayed at the top of the screen (or in the middle of the screen), however.
A nice patch for the issue may be that in order for the mouse to come alive a mouse click must be made - currently a mouse move is enough to awaken it. This would be an advancedsetting.
- john.doe - 2012-03-05 23:14
- eyebeeyou - 2012-03-06 14:37
If I understand correctly making the OSD always on the top of the screen is changing the skin. I don't think it's the way I want to go. (but I think the default skin in dharma, or even before that, had this and back then I think I didn't have this issue)
Maybe I can make the current default skin "move" the subtitles so the skin won't block them. And in this case it will be an option within this skin and will not affect other skins. Will this be acceptable?
Preventing the OSD from appearing on mouse move is a challenge, I can give it a try.
Will it be ok to insert my current code If I make it an advancedsetting option?