Kodi Community Forum
Memory Crash - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+--- Thread: Memory Crash (/showthread.php?tid=124710)



Memory Crash - mcborzu - 2012-03-05

Windows 7
RC 2
DEBUG LOG
Full .xml thats causing error

For some reason changing line 4 from:

<control type="list" id="8000">
to
<control type="wraplist" id="8000">

causes a unstoppable memory leak that crashes my computer if I dont catch it in time, I have 7 seconds I have to 'end process' via Windows Task Manager before all RAM is taken up.

Now I dont need this to be a "wraplist" I was just trying to reverse engineer an effect 'black had in his Xpirence skin but regardless I dont think we want memory leaks that crash the computer...

If need full skin to debug, PM me as I dont want skin public yet...


- Jezz_X - 2012-03-05

Just as a test try setting the preloaditems to ZERO I found with SLik that if I put preload items to a number that ended up being more than the total items available my cpu would go crazy with a wrap list

eg: having 4 menu items but all 4 + 1 wrap was visible on the screen so it has already "wraped" but was still trying to preload

Basically if the same item was on the screen more than once Smile and it was also pre loading

eg: this commit https://github.com/JezzX/skin.SLik/commit/33fe2907a1d4f05edd40166476e82616be3fdb5a (ignore the weather bit it got in the wrong commit)


- pieh - 2012-03-06

@mcborzu
Could You share part of your skin to reproduce the problem? that .xml is not enough as there are some unresolved includes.

(Posted here just in case - maybe yesterday's PM was lost in traffic Tongue)


- Hitcher - 2012-03-06

While we're on the discussion of wraplists -

Can I refresh you on the other problem where focus animations only work every other time when there are repeated items in a wraplist?

Thanks.

EDIT: Trac'd


- pieh - 2012-03-06

@Hitcher:
seems like Your code didn't get pasted on trac - could You re-attach it there?

--- edit ok - it's there now, thanks! Smile


- Hitcher - 2012-03-06

pieh Wrote:@Hitcher:
seems like Your code didn't get pasted on trac - could You re-attach it there?

Or I forgot to add it. Oo


RE: Memory Crash - pieh - 2012-03-17

@mcborzu
Fixed crash in 0c276ec8 . Thx for files needed to reproduce.


RE: Memory Crash - Hitcher - 2012-03-17

(2012-03-17, 12:01)pieh Wrote: @mcborzu
Fixed crash in 0c276ec8 . Thx for files needed to reproduce.

Does this have any effect on the focus animation problem?

Thanks.


RE: Memory Crash - pieh - 2012-03-17

(2012-03-17, 14:51)Hitcher Wrote: Does this have any effect on the focus animation problem?
No, I will be trying to push fix for that issue today. I had working/ugly fix ready earlier but deleted it by mistake and didn't have time earlier - will re-do it from memory now. Will let You know when it gets in (in addition to trac notyfing mail You will get when I close ticket Wink )




RE: Memory Crash - Hitcher - 2012-03-17

Good to know it's fixable.

Thanks.


RE: Memory Crash - peter200285 - 2012-03-17

I am also facing same problem, and the below solution not work for me, any other solution?


(2012-03-05, 05:46)mcborzu Wrote: Windows 7
RC 2
DEBUG LOG
Full .xml thats causing error

For some reason changing line 4 from:

<control type="list" id="8000">
to
<control type="wraplist" id="8000">

causes a unstoppable memory leak that crashes my computer if I dont catch it in time, I have 7 seconds I have to 'end process' via Windows Task Manager before all RAM is taken up.

Now I dont need this to be a "wraplist" I was just trying to reverse engineer an effect 'black had in his Xpirence skin but regardless I dont think we want memory leaks that crash the computer...

If need full skin to debug, PM me as I dont want skin public yet...




RE: Memory Crash - pieh - 2012-03-17

(2012-03-17, 19:11)peter200285 Wrote: I am also facing same problem, and the below solution not work for me, any other solution?
If this is same problem - check if focusedlayout width (for horizontal orientation) or height (vertical) is greater than container width/height. It might be also something else - in that case give me more details so I can fix it Smile




RE: Memory Crash - peter200285 - 2012-03-18

Yes you are right the problem was in focusedlayout's width and now its solved, thanks pieh for helping me out.


(2012-03-17, 20:32)pieh Wrote:
(2012-03-17, 19:11)peter200285 Wrote: I am also facing same problem, and the below solution not work for me, any other solution?
If this is same problem - check if focusedlayout width (for horizontal orientation) or height (vertical) is greater than container width/height. It might be also something else - in that case give me more details so I can fix it Smile




RE: Memory Crash - mcborzu - 2012-03-18

@pieh

Thanks for checking into this