+- XBMC Community Forum (http://forum.xbmc.org)
+-- Forum: Development (/forumdisplay.php?fid=32)
+--- Forum: Skin Development (/forumdisplay.php?fid=12)
+--- Thread: GlobalSearch - tiny changes (/showthread.php?tid=126094)
Pages: 1 2
GlobalSearch - tiny changes - ronie - 2012-03-20 21:47
i've just pushed a new version to the addon repo.
if your skin includes script-globalsearch-contextmenu.xml, please note that a small update is in order.
i've added 1 extra button to the context menu (id 1003)
and changed the script code for position the dialog (so double-check if it still pops up where you want it to be)
RE: GlobalSearch - tiny changes - Big_Noid - 2012-03-20 22:31
Although I don't agree with handling positions of the dialog in the script, thx for the heads up
RE: GlobalSearch - tiny changes - ronie - 2012-03-20 22:37
(2012-03-20 22:31)Big_Noid Wrote: Although I don't agree with handling positions of the dialog in the script, thx for the heads up
it was handling them before, but much less now :-)
the script has to do some calculations as the height of the dialog varies
depending on the numbers of buttons available on the context menu.
RE: GlobalSearch - tiny changes - Hitcher - 2012-03-20 22:47
Revenge is sweet.
(2012-03-19 02:35)ronie Wrote: grumble.. i suppose i could... and for about 6 other scripts as well...grumble
;-)
RE: GlobalSearch - tiny changes - jmarshall - 2012-03-20 22:55
Heh
RE: GlobalSearch - tiny changes - Big_Noid - 2012-03-20 22:58
Yeah for height I knew and understand, but posx calculation is new as far as i can tell.
RE: GlobalSearch - tiny changes - ronie - 2012-03-20 23:05
heh, if you want to get to the bottom of this ;-)
the initial dialog code was a straight copy of nuka's dialog for the amt script.
it had some hardcoded posx calculations, which i've removed now:
https://code.google.com/p/ronie/source/diff?spec=svn356&r=338&format=side&path=/trunk/script.globalsearch/resources/lib/contextmenu.py&old_path=/trunk/script.globalsearch/resources/lib/contextmenu.py&old=126
RE: GlobalSearch - tiny changes - Hitcher - 2012-03-20 23:21
Is it me or are the mirrors down for everyone?
RE: GlobalSearch - tiny changes - ronie - 2012-03-20 23:24
(2012-03-20 23:21)Hitcher Wrote: Is it me or are the mirrors down for everyone?
most likely a side-effect of the Artwork Downloader update.
people are standing in line to get their hands on that one.
RE: GlobalSearch - tiny changes - Martijn - 2012-03-20 23:28
(2012-03-20 23:24)ronie Wrote:(2012-03-20 23:21)Hitcher Wrote: Is it me or are the mirrors down for everyone?
most likely a side-effect of the Artwork Downloader update.
people are standing in line to get their hands on that one.
neah who wants that...
Side note:
ronie had like 7 script updated at the same time....
on the other hand the http://fanart.tv site is also having issues
