[RELEASE] XBMC Subtitles - Addon Script

(2012-08-28, 23:35)tebicenter Wrote: Hi, amet.

Sorry if this has been posted before.

If you remember, I'm the one that created argenteam service for the plugin.

A user from our forum says that he tries to download a subtitle file, which is a zip file with two srt files, CD1 and CD2.

First of all, this is the log of the plugin when it downloads the file and unzip it with no problem

Code:
url: http://www.argenteam.net/search/The+Spy+Who+Came+in+from+the+Cold+1965

    13:42:13 T:972   DEBUG: CApplication::ProcessMouse: trying mouse action leftclick

    13:42:13 T:5144   DEBUG: ### [XBMC Subtitles-services.Argenteam.service] - argenteam Getting url: http://www.argenteam.net/subtitles/28329/

    13:42:15 T:5144   DEBUG: ### [XBMC Subtitles-services.Argenteam.service] - argenteam Saving subtitles to 'C:\Users\martin\AppData\Roaming\XBMC\userdata\addon_data\script.xbmc.subtitles\sub_tmp\argenteam.zip'

    13:42:17 T:972   DEBUG: CZipManager::GetZipList - Processing zip://C%3a%5cUsers%5cmartin%5cAppData%5cRoaming%5cXBMC%5cuserdata%5caddon%5fdata%5cscript%2exbmc%2esubtitles%5csub%5ftmp%5cargenteam%2ezip/

    13:42:17 T:972   DEBUG: statdata: 1346165232 new: 1346172135

    13:42:18 T:5144   DEBUG: ### [XBMC Subtitles-services.Argenteam.service] - argenteam Unpacked files in 'C:\Users\martin\AppData\Roaming\XBMC\userdata\addon_data\script.xbmc.subtitles\sub_tmp'

    13:42:18 T:5144   DEBUG: ### [XBMC Subtitles-services.Argenteam.service] - argenteam Unpacked subtitles file 'The.Spy.Who.Came.In.From.The.Cold.(1965).DVDRip.AC3.XviD-PROMiSE.CD1.srt'

    13:42:18 T:5144   DEBUG: ### [XBMC Subtitles-services.Argenteam.service] - argenteam Unpacked subtitles file 'The.Spy.Who.Came.In.From.The.Cold.(1965).DVDRip.AC3.XviD-PROMiSE.CD2.srt'

As you can see, the files are created on the temp folder.

Then, he saw this on the log

Code:
13:42:18 T:5144   DEBUG: ### [XBMC Subtitles-utilities] - vfs module copy C:\Users\martin\AppData\Roaming\XBMC\userdata\addon_data\script.xbmc.subtitles\sub_tmp\The.Spy.Who.Came.In.From.The.Cold.(1965).DVDRip.AC3.XviD-PROMiSE.CD2.srt -> smb://PCH-A110/share/Video\The.Spy.Who.Came.In.From.The.Cold.(1965).DVDRip.AC3.XviD-PROMiSE.CD1.srt

    13:42:18 T:3096  NOTICE: Opening Subtitle stream: 0 source: 1024

Basically, the plugin moves the srt of CD2 as CD1 and the CD1 file is omitted.

Is this a bug?

I checked that my service.py has this code:

Code:
if waittime == 20:

    log( __name__ ,"%s Failed to unpack subtitles in '%s'" % (debug_pretext, tmp_sub_dir))

else:

    log( __name__ ,"%s Unpacked files in '%s'" % (debug_pretext, tmp_sub_dir))

    for file in files:

        # there could be more subtitle files in tmp_sub_dir, so make sure we get the newly created subtitle file

        if (string.split(file, '.')[-1] in ['srt', 'sub', 'txt']) and (os.stat(os.path.join(tmp_sub_dir, file)).st_mtime > init_max_mtime): # unpacked file is a newly created subtitle file

            log( __name__ ,"%s Unpacked subtitles file '%s'" % (debug_pretext, file))

            subs_file = os.path.join(tmp_sub_dir, file)

and I check that "subs_file" it's overwritten with the latest sub file (in this case, CD2) and that this variable is the one that is returned to the plugin.

Should this method return a list instead of a single file?

Thanks in advance