+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Subtitle Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=143)
+---- Thread: [RELEASE] XBMC Subtitles - Addon Script (/showthread.php?tid=126495)
RE: [RELEASE] XBMC Subtitles - Addon Script - Nander - 2012-11-23
Since the latest update of XBMC Subtitles the add-on has stopped working for me. After choosing a subtitle, it downloads correctly and continues to play the movie. However, the pause UI (saying "Paused" and the time etc.) doesn't disappear and it freezes (time elapsed doesn't update even though the movie is playing). A few seconds later XBMC hangs and the only way to fix it is by resetting the ATV2.
Using Frodo Beta1 on an ATV2. This happens with all skins (including Confluence) and with all movies/shows. I had no problems whatsoever before the latest auto-update of XBMC Subtitles, and the rollback button is for some reason greyed out in the settings.
RE: [RELEASE] XBMC Subtitles - Addon Script - amet - 2012-11-23
(2012-11-23, 08:51)Nander Wrote: Since the latest update of XBMC Subtitles the add-on has stopped working for me. After choosing a subtitle, it downloads correctly and continues to play the movie. However, the pause UI (saying "Paused" and the time etc.) doesn't disappear and it freezes (time elapsed doesn't update even though the movie is playing). A few seconds later XBMC hangs and the only way to fix it is by resetting the ATV2.
Using Frodo Beta1 on an ATV2. This happens with all skins (including Confluence) and with all movies/shows. I had no problems whatsoever before the latest auto-update of XBMC Subtitles, and the rollback button is for some reason greyed out in the settings.
Debug Log for gods sake
RE: [RELEASE] XBMC Subtitles - Addon Script - Nander - 2012-11-23
(2012-11-23, 10:26)amet Wrote: debug log for gods sake
Of course, I'm very sorry.
Here you go: http://pastebin.com/nRDevicj
RE: [RELEASE] XBMC Subtitles - Addon Script - phate89 - 2012-11-23
(2012-11-23, 07:04)amet Wrote:I already seen that, but seems there's no way to get the original tv show name with that method, suggestions?(2012-11-23, 02:11)phate89 Wrote:(2012-11-22, 14:08)amet Wrote: maybe we could call original title info label on that. something ITASA author might look into
Code:xbmc.getInfoLabel("VideoPlayer.OriginalTitle")
With this label don't work, with a tv show it only gets an empty string, probably is ment to be used with movies? There are other apis?
http://wiki.xbmc.org/index.php?title=InfoLabels
RE: [RELEASE] XBMC Subtitles - Addon Script - amet - 2012-11-23
(2012-11-23, 12:45)phate89 Wrote: ... suggestions?
none
RE: [RELEASE] XBMC Subtitles - Addon Script - gfjardim - 2012-11-23
(2012-11-23, 12:45)phate89 Wrote:(2012-11-23, 07:04)amet Wrote:I already seen that, but seems there's no way to get the original tv show name with that method, suggestions?(2012-11-23, 02:11)phate89 Wrote: With this label don't work, with a tv show it only gets an empty string, probably is ment to be used with movies? There are other apis?
http://wiki.xbmc.org/index.php?title=InfoLabels
http://pastebin.com/u1xBKrCH
My solution to the same problem.
RE: [RELEASE] XBMC Subtitles - Addon Script - amet - 2012-11-23
(2012-11-23, 12:28)Nander Wrote:(2012-11-23, 10:26)amet Wrote: debug log for gods sake
Of course, I'm very sorry.
Here you go: http://pastebin.com/nRDevicj
try with this change -> https://github.com/amet/script.xbmc.subtitles/commit/d6af3915ca9c46aebc31fa818c7664836e34c74c
RE: [RELEASE] XBMC Subtitles - Addon Script - phate89 - 2012-11-23
(2012-11-23, 15:05)gfjardim Wrote:Thanks for the help, i'll look into it, so it's not my only problem, i think it's more common than amet think, why not develop a way in the official addon? To me it's a conceptual flaw to search the name of the series, it works only if you're english or if the name isn't changed in translation(2012-11-23, 12:45)phate89 Wrote:(2012-11-23, 07:04)amet Wrote: http://wiki.xbmc.org/index.php?title=InfoLabelsI already seen that, but seems there's no way to get the original tv show name with that method, suggestions?
http://pastebin.com/u1xBKrCH
My solution to the same problem.
RE: [RELEASE] XBMC Subtitles - Addon Script - Popeye - 2012-11-23
(2012-11-22, 13:06)phate89 Wrote:(2012-11-21, 15:04)phate89 Wrote: it is possible to use the original title to look to subtitles or edit the plugin to add an option to do so?
Because italians are stupid and often add subtitles to tv show names (for example "breaking bad" becomes "breaking bad - danni collaterali"), so if i want the italian plot i use thtat title, but this breaks the subtitles addon because when it search it uses the long title and itasa (biggest italian translator website) and all subtitle makers use the original one...
Is it possible to do this? Because i tried to look to the code and i can't find a way to get the original name through the videoplayer api
I'm not sure I really follow what you mean. you have the show "breaking bad" in a folder. When scraped and added to the library it's added as "breaking bad - danni collaterali" ? What are each episode named?
Would there be any use to use the folder or file name for the search? I assume they are named in english since you want subs for them.
RE: [RELEASE] XBMC Subtitles - Addon Script - amet - 2012-11-23
I dont get how this is "my" fault, XBMC provides a wrong name and you have a go at me and the Addon... if XBMC doesnt provide the original name what exactly you want me to do about it?
in almost 3 million addon downloads you and one more user had this issue... that tells you much?
RE: [RELEASE] XBMC Subtitles - Addon Script - phate89 - 2012-11-23
(2012-11-23, 17:06)Popeye Wrote:(2012-11-22, 13:06)phate89 Wrote:(2012-11-21, 15:04)phate89 Wrote: it is possible to use the original title to look to subtitles or edit the plugin to add an option to do so?
Because italians are stupid and often add subtitles to tv show names (for example "breaking bad" becomes "breaking bad - danni collaterali"), so if i want the italian plot i use thtat title, but this breaks the subtitles addon because when it search it uses the long title and itasa (biggest italian translator website) and all subtitle makers use the original one...
Is it possible to do this? Because i tried to look to the code and i can't find a way to get the original name through the videoplayer api
I'm not sure I really follow what you mean. you have the show "breaking bad" in a folder. When scraped and added to the library it's added as "breaking bad - danni collaterali" ? What are each episode named?
Would there be any use to use the folder or file name for the search? I assume they are named in english since you want subs for them.
The problem it's not the episode title, but the show title (itasa part of the code didn't use the name of the episode to find it).
If i'm italian and i scan my breaking bad folder i get italian title ("breaking bad - danni collaterali"), italian plot and titles are italian for the already aired episodes.
The code take the title of the show from the videoplayer and passes to the plugin of the site to use it to search the tv show. So in this case it search the tv show "Breaking bad - danni collaterali", but it didn't exists anywhere because it's always called "breaking bad". But in the library there is the original title of the tv show, and it make more sense to use that title to search the tv show, at least for itasa that always use the original name (but also other websites uses it).
The code gfjardim passed is not exactly what i need because it retrieve the original episode title, not the original tv show name...
RE: [RELEASE] XBMC Subtitles - Addon Script - Popeye - 2012-11-23
(2012-11-23, 17:39)phate89 Wrote:(2012-11-23, 17:06)Popeye Wrote:(2012-11-22, 13:06)phate89 Wrote: Is it possible to do this? Because i tried to look to the code and i can't find a way to get the original name through the videoplayer api
I'm not sure I really follow what you mean. you have the show "breaking bad" in a folder. When scraped and added to the library it's added as "breaking bad - danni collaterali" ? What are each episode named?
Would there be any use to use the folder or file name for the search? I assume they are named in english since you want subs for them.
The problem it's not the episode title, but the show title (itasa part of the code didn't use the name of the episode to find it).
If i'm italian and i scan my breaking bad folder i get italian title ("breaking bad - danni collaterali"), italian plot and titles are italian for the already aired episodes.
The code take the title of the show from the videoplayer and passes to the plugin of the site to use it to search the tv show. So in this case it search the tv show "Breaking bad - danni collaterali", but it didn't exists anywhere because it's always called "breaking bad". But in the library there is the original title of the tv show, and it make more sense to use that title to search the tv show, at least for itasa that always use the original name (but also other websites uses it).
The code gfjardim passed is not exactly what i need because it retrieve the original episode title, not the original tv show name...
If the original name is in the library, then there has to be a way to get it out of there. If not, you always have the manual option or to use folder/file name...
RE: [RELEASE] XBMC Subtitles - Addon Script - phate89 - 2012-11-23
(2012-11-23, 17:39)amet Wrote: I dont get how this is "my" fault, XBMC provides a wrong name and you have a go at me and the Addon... if XBMC doesnt provide the original name what exactly you want me to do about it?
in almost 3 million addon downloads you and one more user had this issue... that tells you much?
XBMC doesn't provide the wrong name, the videoplayer obviously uses the localised name.
But all the tv show subtitle websites i know uses the original title, not the translated one, so i think that should be the title you should use by default (or at least provide an option).
Of course if the localised name it's the same as original (luckily rarely someone translate the tv show titles, but this isn't always true) or you use the same language of the tv show (this is the most common scenario i think, usually tv shows are from usa and uk and they're the most common users) this method don't create an issue, but it's not always true...
Of course this is not my addon so i can't force you to change it, but can you at least help me to understand how can i get the original title by myself so i can edit it? it's in the library, i know python but i have no clue how to get that value from xbmc database.
RE: [RELEASE] XBMC Subtitles - Addon Script - Popeye - 2012-11-23
(2012-11-23, 17:48)phate89 Wrote: Of course this is not my addon so i can't force you to change it, but can you at least help me to understand how can i get the original title by myself so i can edit it? it's in the library, i know python but i have no clue how to get that value from xbmc database.
And then create a nice and tidy pull request to Amet for everyone's benefit
RE: [RELEASE] XBMC Subtitles - Addon Script - gfjardim - 2012-11-24
(2012-11-23, 17:48)phate89 Wrote: Of course this is not my addon so i can't force you to change it, but can you at least help me to understand how can i get the original title by myself so i can edit it? it's in the library, i know python but i have no clue how to get that value from xbmc database.You can use JSON-RPC and TheTVDB to retrieve this data:
http://pastebin.com/u1xBKrCH