(2013-02-24, 20:58)gboado Wrote: Hi. Since version 3 of this addon there are two annoying problems with the provider Subdivx (one of the best Spanish subtitles sites):
1) The first is related with the way they represent the number of downloads. They use a colon to separate thousands, which makes the line
downloads = int (matches.group(2)) / 1000 fail, as int will receive a number like 1,200. This wasn't a problem until the number of downloads exceeded 999, which happens now in every subtitle. The solution (found elsewhere in the net) is to change by:
downloads = int(matches.group(2).replace(",","")) / 1000
This works and I implemented it in every update, but it would be desirable to have it corrected in the addon, since it is rather cumbersome to fix it every time.

(2013-02-24, 20:58)gboado Wrote: 2) The second problem is far worse. There are some subtitles that contain (in addition to the corresponding subtitle file) a text file with a name using accented characters (i.e. á, é, í, ó, ú) or the Spanish character ñ. This makes the function which iterates through the files fail, so the .rar or .zip file is decompressed but the subtitle is never processed.

(2013-02-24, 22:33)jamesonmula Wrote:

(2013-02-24, 20:58)gboado Wrote: Hi. Since version 3 of this addon there are two annoying problems with the provider Subdivx (one of the best Spanish subtitles sites):
1) The first is related with the way they represent the number of downloads. They use a colon to separate thousands, which makes the line
downloads = int (matches.group(2)) / 1000 fail, as int will receive a number like 1,200. This wasn't a problem until the number of downloads exceeded 999, which happens now in every subtitle. The solution (found elsewhere in the net) is to change by:
downloads = int(matches.group(2).replace(",","")) / 1000
This works and I implemented it in every update, but it would be desirable to have it corrected in the addon, since it is rather cumbersome to fix it every time.

Oh, if I only had seen your post before it would save me a lot of time! Sorry for the late answer on this, I fixed it this morning (with a similar method) and sent it to the admins. Hopefully a new release will be distributed son. I am a fast downloader so my subtitles rarely have more than 1,000 downloads.

(2013-02-24, 20:58)gboado Wrote: 2) The second problem is far worse. There are some subtitles that contain (in addition to the corresponding subtitle file) a text file with a name using accented characters (i.e. á, é, í, ó, ú) or the Spanish character ñ. This makes the function which iterates through the files fail, so the .rar or .zip file is decompressed but the subtitle is never processed.

Not sure if I will be able to fix this, but can you send me a sample? A subdivx URL containing the file you are downloading will be enough.

Thanks!

(2013-02-26, 11:12)jurrabi Wrote: Maybe if people reported issues in specific services following forum rules (specifically in a separate thread and with proper subject) more people would read them and give support or add fixes for everybody.

Me for example, I never read this thread, since it's a thread to notify of changes in release and (being a part of releases) I already know about them.

I might be able to help with the accented files trouble. I'm working on it on other services. But I won't give or read support in this thread so please create an specific thread in the forum for the subdivx service with this issue and I'll report my advances there.

(2013-02-28, 01:38)jowadmax Wrote: @amet

-Subscene: fixed zip files not getting extracted properly.
http://pastebin.com/QDZHD5eP

Thanks!

(2013-02-28, 10:37)amet Wrote:

(2013-02-28, 01:38)jowadmax Wrote: @amet

-Subscene: fixed zip files not getting extracted properly.
http://pastebin.com/QDZHD5eP

Thanks!

please use github in future

(2013-02-28, 18:43)misa Wrote:

(2013-02-28, 10:37)amet Wrote:

(2013-02-28, 01:38)jowadmax Wrote: @amet

-Subscene: fixed zip files not getting extracted properly.
http://pastebin.com/QDZHD5eP

Thanks!

please use github in future

Yes Mylord............as you wish

(2013-02-28, 22:10)amet Wrote:

(2013-02-28, 18:43)misa Wrote:

(2013-02-28, 10:37)amet Wrote: please use github in future

Yes Mylord............as you wish

not very constructive... are you just trying to get your post count up?

(2013-03-01, 07:07)amet Wrote: It was not commanding , this is a second time I get a pastebin to update the service. Every other service maintainer does it at github, why us it different now?

If he asked how to do it I would explain it, if he googled it and hot stuck half way I still would have explained it...

Imagine what this thread would look like if everyone pasted bits of code and expected me to add to github, not to mention that we don't even know if it works now since I copy/pasted pastebin instead of merging the github branches.

Just my $0.02