+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Kodi Application (https://forum.kodi.tv/forumdisplay.php?fid=93)
+---- Forum: GSoC (https://forum.kodi.tv/forumdisplay.php?fid=299)
+----- Forum: GSoC 2012 (https://forum.kodi.tv/forumdisplay.php?fid=161)
+----- Thread: Improved UPnP serving and client (/showthread.php?tid=127949)
RE: Improved UPnP serving and client - da-anda - 2012-10-24
for the record - the patch you gave me on IRC did work. XBMC is showing up as UPNP source now on my Bravia TV, but had some issues with not showing playable files while browsing the nodes. Will update the library on my dev system and check again.
Please tell me if you want me to debug this further to get it fixed for Frodo - if not, I'm fine as I usually don't use the UPNP server of XBMC, only wanted to help testing and debugging.
RE: Improved UPnP serving and client - sialivi - 2012-10-24
@alcoheca
I just noticed that the android UPnP client "Skifta" fails on the same nodes as my Pioneer:
Artists > Sabaton > Carolus Rex > "An error accured fetching the media items"
Genres > Power Metal > Sabaton > "An error accured fetching the media items"
BubbleUPnP on the other hand can browse those nodes just fine.
RE: Improved UPnP serving and client - alcoheca - 2012-10-25
(2012-10-24, 21:04)sialivi Wrote: @alcoheca
Just so you don't miss it, someone posted about having a UPnP issue here -> http://forum.xbmc.org/showthread.php?tid=143459
thanks
RE: Improved UPnP serving and client - alcoheca - 2012-10-25
(2012-10-24, 21:19)da-anda Wrote: for the record - the patch you gave me on IRC did work. XBMC is showing up as UPNP source now on my Bravia TV, but had some issues with not showing playable files while browsing the nodes. Will update the library on my dev system and check again.
Please tell me if you want me to debug this further to get it fixed for Frodo - if not, I'm fine as I usually don't use the UPNP server of XBMC, only wanted to help testing and debugging.
Sorry didn't see this - the issue is Platinum is not fully DLNA compliant which the Sony's expect. To fix this sort of thing properly we need to support per manufacturer/model profiles. Too late for Frodo.
RE: Improved UPnP serving and client - da-anda - 2012-10-25
sure, np from my side. Just drop a note once I can help testing/debugging again.
RE: Improved UPnP serving and client - kricker - 2012-10-25
Same here for my Bravia that didn't work originally.
RE: Improved UPnP serving and client - alcoheca - 2012-10-26
(2012-10-24, 23:45)sialivi Wrote: @alcoheca
I just noticed that the android UPnP client "Skifta" fails on the same nodes as my Pioneer:
Artists > Sabaton > Carolus Rex > "An error accured fetching the media items"
Genres > Power Metal > Sabaton > "An error accured fetching the media items"
BubbleUPnP on the other hand can browse those nodes just fine.
I just recreated this, it's a bug in our or Platinum's URL encoding. As our library paths can include ampersands, we need to escape them properly. For some reasons we represent an & as & when it should be &
fix incoming once I track it down.
RE: Improved UPnP serving and client - kricker - 2012-10-26
Your doing great work Alcoheca.
RE: Improved UPnP serving and client - alcoheca - 2012-10-26
(2012-10-26, 01:03)alcoheca Wrote:(2012-10-24, 23:45)sialivi Wrote: ...I just recreated this, it's a bug in our or Platinum's URL encoding. As our library paths can include ampersands, we need to escape them properly. For some reasons we represent an & as & when it should be &
BubbleUPnP on the other hand can browse those nodes just fine.
Actually, on second thoughts, there's nothing wrong with & when it's like that, it's doubly escaped to fit into the soap envelope.
It's Skifta & the Panasonic which are misbehaving. I've just read a lot of specs and the only restriction on object IDs is that they're UTF-8 encoded, XML escaped, and no longer than 256 bytes.
They cope fine with doubly escaped ampersands in Artist names and song titles, just not in object ids.
RE: Improved UPnP serving and client - sialivi - 2012-10-26
I don't suppose anyone has had time to look at that crash dump yet?
RE: Improved UPnP serving and client - alcoheca - 2012-10-26
(2012-10-26, 18:21)sialivi Wrote: I don't suppose anyone has had time to look at that crash dump yet?
Hi yeah we've had a look but aren't sure right now. Can you make sure to remove ALL .fi files from special://xbmc/temp folder.
special://xbmc - C:\Program Files\XBMC
special://home - C:\Users\[username]\AppData\Roaming\XBMC
and then try the latest available build.
RE: Improved UPnP serving and client - sialivi - 2012-10-26
Still crashes with the latest build. No .fi files in any of those locations, only a single .fi file under "portable data\cache\" and deleting that made no difference.
Dump: https://dl.dropbox.com/u/41720073/xbmc/xbmc_crashlog-12.0-ALPHA7%20Git_20121024-8885f2f-20121026-203238.dmp
Log: http://xbmclogs.com/show.php?id=11445
RE: Improved UPnP serving and client - sialivi - 2012-10-26
Some more tidbits of information regarding this crash:
If I press Up right away, it nearly always crashes.
If I wait a few seconds before pressing Up it doesn't crash as often.
It's almost like it's still busy with the previous request and performing a new one while it's not done makes it crash. That's the impression I get at least.
Sometimes it doesn't crash but the list on the TV doesn't fully populate. The list shows 11 items at a time and I have 541 items in the database.
I press Up, the list wraps around to the end of the list, and the last item is in focus. The list visible on the TV should now show item 530 to 541 with 541 in focus. At this point, if XBMC hasn't crashed, one of two things happen:
1) Item 530 to 540 is populated, 541 is blank (but still in focus)
2) Item 530 to 540 are blank, only 541 is populated. If I press Up again to move focus to item 540, nothing happens, I can't move in that direction. Pressing Down wraps around to the start of the list as expected.
RE: Improved UPnP serving and client - alcoheca - 2012-10-26
Yeah so that was a good clue, it seems we're trying to open the cache file while still writing to it, which means when we load an invalid value for the length of the file to load, and then try and allocate that amount on the heap. Your PC runs out of RAM and xbmc quickly dies.
I imagine if you waited a minute before pushing up you'd not see the crash.
RE: Improved UPnP serving and client - alcoheca - 2012-10-27
I only just now saw the last edit to you post, but have committed locks around the caching in UPnPServer. Let's see how you get on after the next nightly build.