+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Kodi Application (https://forum.kodi.tv/forumdisplay.php?fid=93)
+--- Thread: Forced Subtitles in PGS Streams (/showthread.php?tid=148019)
Forced Subtitles in PGS Streams - Majin - 2012-12-11
Hi there,
The issue is forced subs in bluray rips not showing when subtitles are not turned on. eg Na'vi sections in Avatar
I just commented on hakuya's BRRip playback branch thread (http://forum.xbmc.org/showthread.php?tid=128935) where I explained that by replicating the updates he made in Eden, against the Frodo master, fixes the issue again.
The files updated were:
lib/ffmpeg/libavcodec/avcodec.h
lib/ffmpeg/libavcodec/pgssubdec.c
xbmc/cores/dvdplayer/DVDCodecs/Overlay/DVDOverlayCodecFFmpeg.cpp
lib/ffmpeg/libavcodec/options.c
In commits:
Added support for forced subtitles in PGS streams: https://github.com/hakuya/xbmc/commit/63e6c1a9e4d9d205903d1617051c4bacbebf9b55
Pulling in changes from latest pgssubdec.c ffmpeg upstream for PGS decoding fixes: https://github.com/hakuya/xbmc/commit/6ff147c82a71407dc47d30ecdd28c8b2b5694861
Would it be possible to merge these changes with master to resolve a long standing issue?
RE: Forced Subtitles in PGS Streams - da-anda - 2012-12-11
It's unfortunately to late to get this thing in for Frodo. Also the ffmpeg patches are a bit critical atm - might need to wait until we upgrade ffmpeg.
RE: Forced Subtitles in PGS Streams - GreenOnyx - 2012-12-29
This should be fixed with the below commits:
Fixed forced subtitles display in PGS stream: 1992 (PR)
Don't utilize rect.flags for an external ffmpeg that doesn't support it: 2002 (PR)
It was discussed under the last couple pages of the older Eden thread: http://forum.xbmc.org/showthread.php?tid=128935&pid=1278949