FFmpeg version bump + XBMC add-on patches.

FFmpeg version bump + XBMC add-on patches. - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Kodi Application (https://forum.kodi.tv/forumdisplay.php?fid=93)
+--- Thread: FFmpeg version bump + XBMC add-on patches. (/showthread.php?tid=156303)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29

RE: FFmpeg version bump + XBMC add-on patches. - vicbitter - 2013-05-09

(2013-05-08, 22:41)ace20022 Wrote: I think I found out why external subs do not work. Looking at the code I'm not sure that it was meant to work at any time at all (at least for dvds). Maybe someone from the team can answer this.

When you say "code", can you be more specific? What code are you looking at?

Thanks!

RE: FFmpeg version bump + XBMC add-on patches. - Ace - 2013-05-11

(2013-05-09, 01:25)vicbitter Wrote:
(2013-05-08, 22:41)ace20022 Wrote: I think I found out why external subs do not work. Looking at the code I'm not sure that it was meant to work at any time at all (at least for dvds). Maybe someone from the team can answer this.

When you say "code", can you be more specific? What code are you looking at?

Thanks!

Sorry for the delay! The problem isn't related to the ffmpeg version bump, I'm trying to find a fix. If you want to have a look, the timestamp conversion for media with menu is the root cause imo: CDVDDemuxFFmpeg::ConvertTimestamp(int64_t pts, int den, int num).

RE: FFmpeg version bump + XBMC add-on patches. - Ace - 2013-05-12

@Wanilton I also found the reason for the unknown languages. I will try to bring it to the dev's attention, since I haven't found a fix on my own yet.

RE: FFmpeg version bump + XBMC add-on patches. - vicbitter - 2013-05-13

(2013-05-12, 23:14)ace20022 Wrote: @Wanilton I also found the reason for the unknown languages. I will try to bring it to the dev's attention, since I haven't found a fix on my own yet.

Great, can you point us in the right direction? ie. The offending code.

Thanks!

RE: FFmpeg version bump + XBMC add-on patches. - Ace - 2013-05-13

@vicbitter I've opened a pr2743.

RE: FFmpeg version bump + XBMC add-on patches. - Wanilton - 2013-05-13

@ace20022, well I compiled XBMC gotham, latest master with your PR, and have now info for tracks language and subtitles, but XBMC only load internal subtitle, external don´t work yet..

RE: FFmpeg version bump + XBMC add-on patches. - Ace - 2013-05-13

@Wanilton, the problem is (or seems to be) that the path in which external subtitles are search is inside the virtual file system of the iso file. What happens if you choose them manually from the audio menu?

RE: FFmpeg version bump + XBMC add-on patches. - Robotica - 2013-05-13

(2013-05-04, 01:32)sialivi Wrote: flyingrat,

I didn't have any luck playing the opus audiobooks I have, I tried both PAPlayer and DVDPlayer and both say the files are unplayable.

Log: http://www.xbmclogs.com/show.php?id=15896

I'll PM you a link to one of the files I tested.

Both seem to fail creating and use the ffmpeg-demuxer.

RE: FFmpeg version bump + XBMC add-on patches. - flyingrat - 2013-05-14

(2013-05-13, 22:48)Robotica Wrote:
(2013-05-04, 01:32)sialivi Wrote: flyingrat,

I didn't have any luck playing the opus audiobooks I have, I tried both PAPlayer and DVDPlayer and both say the files are unplayable.

Log: http://www.xbmclogs.com/show.php?id=15896

I'll PM you a link to one of the files I tested.

Both seem to fail creating and use the ffmpeg-demuxer.

It should work (well, i can sense that mr Murphy is laughing now Smile

) Which branch and platform did you test?

RE: FFmpeg version bump + XBMC add-on patches. - Robotica - 2013-05-14

Looking at his log, 13.0alpha3 on Win7. He also used a correct as.xml to have support for the extension.

RE: FFmpeg version bump + XBMC add-on patches. - Wanilton - 2013-05-14

(2013-05-13, 22:43)ace20022 Wrote: @Wanilton, the problem is (or seems to be) that the path in which external subtitles are search is inside the virtual file system of the iso file. What happens if you choose them manually from the audio menu?

Well, work fine if I choose manually, sometimes I have troubles with sync, and xbmc Gotham don´t go correctly for specific folder movie, in XBMC Eden, when choose subtitle manually, go to correct movie folder..

RE: FFmpeg version bump + XBMC add-on patches. - vicbitter - 2013-05-14

(2013-05-13, 16:40)ace20022 Wrote: @vicbitter I've opened a pr2743.

Great work! The Language info is working again with commit 606455a

Thanks!

RE: FFmpeg version bump + XBMC add-on patches. - flyingrat - 2013-05-14

(2013-05-14, 00:48)Robotica Wrote: Looking at his log, 13.0alpha3 on Win7. He also used a correct as.xml to have support for the extension.

Hard to tell if that was from any of my old binaries or not. I'll check which versions are online...

RE: FFmpeg version bump + XBMC add-on patches. - sialivi - 2013-05-14

(2013-05-14, 21:47)flyingrat Wrote: Hard to tell if that was from any of my old binaries or not. I'll check which versions are online...

It was with XBMCSetup-20130419-c01c97d-dx.exe

RE: FFmpeg version bump + XBMC add-on patches. - Ace - 2013-05-15

(2013-05-14, 00:37)flyingrat Wrote:
(2013-05-13, 22:48)Robotica Wrote:
(2013-05-04, 01:32)sialivi Wrote: flyingrat,

I didn't have any luck playing the opus audiobooks I have, I tried both PAPlayer and DVDPlayer and both say the files are unplayable.

Log: http://www.xbmclogs.com/show.php?id=15896

I'll PM you a link to one of the files I tested.

Both seem to fail creating and use the ffmpeg-demuxer.

It should work (well, i can sense that mr Murphy is laughing now ) Which branch and platform did you test?

Hi,

with this patch:

Code:
xbmc/cores/paplayer/CodecFactory.cpp | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xbmc/cores/paplayer/CodecFactory.cpp b/xbmc/cores/paplayer/CodecFactory.cpp

index c35d913..1a7cb5a 100644

--- a/xbmc/cores/paplayer/CodecFactory.cpp

+++ b/xbmc/cores/paplayer/CodecFactory.cpp

@@ -108,7 +108,8 @@ ICodec* CodecFactory::CreateCodec(const CStdString& strFileType)

#endif

   else if (strFileType.Equals("tta"))

     return new DVDPlayerCodec();

-

+  else if (strFileType.Equals("opus"))

+    return new DVDPlayerCodec();

   return NULL;

}

I get:

Code:
ffmpeg[1850]: [ogg] ti bytes of comment header remain

CDVDDemuxFFmpeg::Open - avformat_find_stream_info starting

CDVDDemuxFFmpeg::Open - av_find_stream_info finished

ffmpeg[1850]: Input #0, ogg, from '***\testvector01.bit.opus':

ffmpeg[1850]:   Duration: 00:00:29.47, start: 0.000000, bitrate: 181 kb/s

ffmpeg[1850]:     Stream #0:0: Audio: opus, 48000 Hz, 2 channels

CDVDDemuxFFmpeg::AddStream(0, ...) -> 0

The thread 0x4fc has exited with code 0 (0x0).

FactoryCodec - Audio: FFmpeg - Opening

The thread 0x1cb0 has exited with code 0 (0x0).

SECTION:LoadDLL(special://xbmcbin/system/players/dvdplayer/swresample-0.dll)

'XBMC.exe' (Win32): Loaded 'D:\Code\xbmc-git\system\players\dvdplayer\swresample-0.dll'. Module was built without symbols.

CDVDAudioCodecFFmpeg::Open() Unable to find codec 1330664787

FactoryCodec - Audio: FFmpeg - Failed

Maybe it is necessary to configure ffmpeg with "--enable-libopus" ?