Kodi Community Forum
custom dialogs broken in gotham - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=26)
+---- Forum: PVR (https://forum.kodi.tv/forumdisplay.php?fid=136)
+---- Thread: custom dialogs broken in gotham (/showthread.php?tid=176636)

custom dialogs broken in gotham - krustyreturns - 2013-10-27

I am developing the pvr addon and server for using windows media center as the backend for xbmc. I created a couple of simple custom dialog windows for my users that work fine in frodo but hang in gotham. The dialogs open and look ok but won't respond to any mouse or keyboard input - except the escape key which successfully cancels the dialog.

Can anyone help me understand what changes in gotham would cause these to break? Or even better, let me know how I can fix them Smile.

RE: custom dialogs broken in gotham - margro - 2013-10-27

I noticed that too when I copied your idea for the series recording dialog Wink

The fix I'm using for the MediaPortal pvr addon is to return "false" instead of true in the OnAction() function.
See also: my GUIDialogRecordSettings.cpp
Returning false causes XBMC to handle actions that the addon code does not handle. With true, XBMC does not handle the keypresses etc.

By the way, I also noticed that you say that people have to copy the skin files for the custom dialogs. I'm using a slightly different skin folder name, and I don't have to copy anything.
Try renaming your "skins/Confluence" folder to "skins/skin.confluence".

RE: custom dialogs broken in gotham - krustyreturns - 2013-10-27

(2013-10-27, 14:09)margro Wrote: I noticed that too when I copied your idea for the series recording dialog Wink

The fix I'm using for the MediaPortal pvr addon is to return "false" instead of true in the OnAction() function.
See also: my GUIDialogRecordSettings.cpp
Returning false causes XBMC to handle actions that the addon code does not handle. With true, XBMC does not handle the keypresses etc.

By the way, I also noticed that you say that people have to copy the skin files for the custom dialogs. I'm using a slightly different skin folder name, and I don't have to copy anything.
Try renaming your "skins/Confluence" folder to "skins/skin.confluence".

Thanks! That worked!

It almost makes up for the fact that you never told me about the skin.confluence thing until now Smile. Thanks for that too btw.

I have a thick skin - if you notice any other dumb stuff I have done please let me know.

RE: custom dialogs broken in gotham - margro - 2013-10-27

(2013-10-27, 19:08)krustyreturns Wrote: It almost makes up for the fact that you never told me about the skin.confluence thing until now Smile. Thanks for that too btw.
Hehe... otherwise your addon would become better than mine... Big Grin
I discovered it by looking at the VDR addon sources which did not need the manual install step.

RE: custom dialogs broken in gotham - krustyreturns - 2013-10-28

(2013-10-27, 21:36)margro Wrote:
(2013-10-27, 19:08)krustyreturns Wrote: It almost makes up for the fact that you never told me about the skin.confluence thing until now Smile. Thanks for that too btw.
Hehe... otherwise your addon would become better than mine... Big Grin
I discovered it by looking at the VDR addon sources which did not need the manual install step.

lol, not much chance of that. Thanks again.