Skin / Script Development - Updates and Support

Skin / Script Development - Updates and Support - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Skins Support (https://forum.kodi.tv/forumdisplay.php?fid=67)
+---- Forum: Aeon Nox: Silvo (https://forum.kodi.tv/forumdisplay.php?fid=142)
+---- Thread: Skin / Script Development - Updates and Support (/showthread.php?tid=202302)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83

RE: Welcome back - Development updates - phil65 - 2014-12-02

(2014-12-02, 23:18)bsoriano Wrote: Phil,

I see in the log lookups into the music database. Mine is pretty large, with close to 150k songs. Does this make any difference? Also, I noticed skin.widgets service running also, does your skin require it?

Well, perhaps I am grabbing at straws here. Given the size of my collection overall, I could live without the cross-comparing.

Again, thank you so much for your work and this fantastic skin.

Regards,

Bart

i noticed them too, but I cannot imagine why ExtendedInfo script should be responsible for them.

service.skin.widgets is basically only required for backgrounds atm, and that will also get removed in some time.

RE: Welcome back - Development updates - bsoriano - 2014-12-02

Latest Log.

That did it! Times are now between 3 and 5 seconds, great! Thanks a lot Phil.

Regards,

Bart

RE: Welcome back - Development updates - Rastan - 2014-12-02

Wow!! I just tried the latest script change and it is 3 seconds to get to movie info now!

EDIT

I forgot to post a LOG

Welcome back - Development updates - sveni_lee - 2014-12-02

Yes, that change was great, 3-5sec.... Thanks

RE: Welcome back - Development updates - phil65 - 2014-12-02

ok, seems everyone is happy now Smile

how fast is it on second try? same amount? I´m askin because results get cached.
There is one more way to speed up that dialog (caching the created listitems instead of caching the JSON answer itself), that would require some major changes though which are probably out of sight at the moment. (much more important things to do)

RE: Welcome back - Development updates - phil65 - 2014-12-02

(2014-12-02, 23:25)Rastan Wrote: Wow!! I just tried the latest script change and it is 3 seconds to get to movie info now!

EDIT

I forgot to post a LOG

ok, the only thing which takes too long for you now is the JSON call to get MovieInfo from database. (2.2 sec)
i pushed another commit to speed it up a bit, not sure if that is noticable. If not, then I have one or two more ideas to improve that delay.

RE: Welcome back - Development updates - Rastan - 2014-12-03

(2014-12-02, 23:57)phil65 Wrote:
(2014-12-02, 23:25)Rastan Wrote: Wow!! I just tried the latest script change and it is 3 seconds to get to movie info now!

EDIT

I forgot to post a LOG
ok, the only thing which takes too long for you now is the JSON call to get MovieInfo from database. (2.2 sec)
i pushed another commit to speed it up a bit, not sure if that is noticable. If not, then I have one or two more ideas to improve that delay.

I just updated the script again and tried it out. But The script fails Undecided

LOG

RE: Welcome back - Development updates - phil65 - 2014-12-03

(2014-12-03, 00:06)Rastan Wrote:
(2014-12-02, 23:57)phil65 Wrote:
(2014-12-02, 23:25)Rastan Wrote: Wow!! I just tried the latest script change and it is 3 seconds to get to movie info now!

EDIT

I forgot to post a LOG
ok, the only thing which takes too long for you now is the JSON call to get MovieInfo from database. (2.2 sec)
i pushed another commit to speed it up a bit, not sure if that is noticable. If not, then I have one or two more ideas to improve that delay.

I just updated the script again and tried it out. But The script fails LOG

already fixed, stupid mistake from my side Wink

RE: Welcome back - Development updates - Rastan - 2014-12-03

(2014-12-03, 00:08)phil65 Wrote:
(2014-12-03, 00:06)Rastan Wrote:
(2014-12-02, 23:57)phil65 Wrote: ok, the only thing which takes too long for you now is the JSON call to get MovieInfo from database. (2.2 sec)
i pushed another commit to speed it up a bit, not sure if that is noticable. If not, then I have one or two more ideas to improve that delay.

I just updated the script again and tried it out. But The script fails LOG

already fixed, stupid mistake from my side

I just updated and tried again. The speed seems the same on repeated attempts. Still fast at around 3 seconds though. New LOG

RE: Welcome back - Development updates - phil65 - 2014-12-03

ok, I tried something else. try again. it should speed up when opening for the second time after restarting xbmc.

RE: Welcome back - Development updates - bsoriano - 2014-12-03

Phil,

Some additional questions:

1. Is it the intended behavior that the poster shown in the movie info page is the one from themoviedb and not the one from my library? Could you show the library one instead?

2. Would it be possible to always show the audio and subtitle language flags in the movie info page?

3. Would you consider showing the IMDB Top 250 info in the movie info page?

4. Are the musicvids widgets broken at the moment? they do not show anything for me.

Lastly, I just wanted to reiterate that it is truly amazing work you have done and are doing with this skin! Thank youso much.

Regards,

Bart

RE: Welcome back - Development updates - phil65 - 2014-12-03

yes, probably all points will get done. you probably can workaround musicvideo widgets by using smart playlists, not sure atm. (in general it´s better to treat concert videos as a movie genre)

some feedback if the latest change improved performance would be nice. (including debug logs)

RE: Welcome back - Development updates - Rastan - 2014-12-03

(2014-12-03, 00:24)phil65 Wrote: ok, I tried something else. try again. it should speed up when opening for the second time after restarting xbmc.

I updated again and got info on movie it took about 3 seconds. I then shut down Kody and opened it again. I got info again and it took around 3 seconds. I got info again on the same movie and it went to 2 seconds. Tried again and it was 3 seconds....LOL

Heres the LOG

3 seconds is more than good considering it was close to a minute at the begining. If you want to continue tweaking I don't mind testing it Wink

RE: Welcome back - Development updates - phil65 - 2014-12-03

I am also not sure yet how to implement re-scraping of a movie. that action only seems to be available for the "native" movieinfo dialog, not for my scripted one by JSON-RPC/whatever

(2014-12-03, 00:38)Rastan Wrote:
(2014-12-03, 00:24)phil65 Wrote: ok, I tried something else. try again. it should speed up when opening for the second time after restarting xbmc.

I updated again and got info on movie it took about 3 seconds. I then shut down Kody and opened it again. I got info again and it took around 3 seconds. I got info again on the same movie and it went to 2 seconds. Tried again and it was 3 seconds....LOL

Heres the LOG

3 seconds is more than good considering it was close to a minute at the begining. If you want to continue tweaking I don't mind testing it

not completely true, from logs it´s an improvement by one second.

first time it takes

22:31:33 T:8628 DEBUG: script.extendedinfo: create_light_movielist: -1.58900022507

and after that:

22:31:42 T:11440 DEBUG: script.extendedinfo: create_light_movielist: -0.460999965668

22:31:51 T:7868 DEBUG: script.extendedinfo: create_light_movielist: -0.461000204086

22:31:59 T:9996 DEBUG: script.extendedinfo: create_light_movielist: -0.448999881744

it would be great if you would also have a look at RAM usage, I´m caching a lot of stuff as window properties now, not sure if that will lead into problems in the longer term.

RE: Welcome back - Development updates - bsoriano - 2014-12-03

(2014-12-03, 00:39)phil65 Wrote: I am also not sure yet how to implement re-scraping of a movie. that action only seems to be available for the "native" movieinfo dialog, not for my scripted one by JSON-RPC/whatever

(2014-12-03, 00:38)Rastan Wrote:
(2014-12-03, 00:24)phil65 Wrote: ok, I tried something else. try again. it should speed up when opening for the second time after restarting xbmc.

I updated again and got info on movie it took about 3 seconds. I then shut down Kody and opened it again. I got info again and it took around 3 seconds. I got info again on the same movie and it went to 2 seconds. Tried again and it was 3 seconds....LOL

Heres the LOG

3 seconds is more than good considering it was close to a minute at the begining. If you want to continue tweaking I don't mind testing it

not completely true, from logs it´s an improvement by one second.

first time it takes

22:31:33 T:8628 DEBUG: script.extendedinfo: create_light_movielist: -1.58900022507

and after that:

22:31:42 T:11440 DEBUG: script.extendedinfo: create_light_movielist: -0.460999965668

22:31:51 T:7868 DEBUG: script.extendedinfo: create_light_movielist: -0.461000204086

22:31:59 T:9996 DEBUG: script.extendedinfo: create_light_movielist: -0.448999881744

Phil,

Latest log from me. I show an improvement of 1 second that remains pretty much constant on subsequent attempts.

When you say re-scraping, that would be the "Refresh" button in the usual movie info dialog? I was going to ask you how that was done with the new info dialog.

Regards,

Bart