+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Discussions (https://forum.kodi.tv/forumdisplay.php?fid=222)
+--- Forum: Feature Requests (https://forum.kodi.tv/forumdisplay.php?fid=9)
+--- Thread: Req skin.confluence as a git submodule (/showthread.php?tid=205165)
skin.confluence as a git submodule - shandian - 2014-09-25
I wanted to fork this the other day but was surprised to find that it is still part of the main repository (by comparison, skin.re-touched, the other default skin, is contained as it's own git submodule). Would it be possible to move Confluence into its own repository and then add it as a submodule?
Link for reference: https://github.com/xbmc/xbmc/tree/master/addons
RE: skin.confluence as a git submodule - da-anda - 2014-09-25
there was a lengthy discussion about this already. Short answer is NO. Long answer is that submodules suck when you have core changes that require Confluence changes and Github doesn't deal with this very well from our experience (submodule updates got reverted unnoticed by other PRs that had nothing to do with the submodule). Skin.Touched is preinstalled but an ugly abandoned step child that gets updated form time to time, whereas Confluence is the default that HAS TO work no matter what and which has to be easy for any dev to update along with his PRs.
RE: skin.confluence as a git submodule - shandian - 2014-09-25
Ah, okay. Do you have a link to the discussion?
RE: skin.confluence as a git submodule - da-anda - 2014-09-26
sorry no - don't even remember if it was on the forum or on github. If github improved by now it could be rethought of - or we move it out and use cmake to grab and build once that's deployed and tested well for all our platforms
RE: skin.confluence as a git submodule - Memphiz - 2014-09-26
No submodules anymore - jenkins has trouble with them too.