+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Discussions (https://forum.kodi.tv/forumdisplay.php?fid=222)
+--- Forum: Feature Requests (https://forum.kodi.tv/forumdisplay.php?fid=9)
+--- Thread: Req Add sort method "DateAdded" for MusicVideo views (/showthread.php?tid=317917)
Add sort method "DateAdded" for MusicVideo views - scott967 - 2017-07-08
Propose adding an additional sort method of "SortByDateAdded" for music video views in videos window. I think the applicable file is GUIViewStateVideo.cpp and could be PRed something like this?
scott s.
.
RE: Add sort method "DateAdded" for MusicVideo views - ironic_monkey - 2017-07-10
why did you go through all the work of creating a screenshot of the PR instead of just posting the actual PR
your change is all good.
RE: Add sort method "DateAdded" for MusicVideo views - scott967 - 2017-07-12
Well, 1 - I'm not a C programmer, so I just did what seems logical based on general programming knowledge; could be messed up, but more so 2 - so far I haven't been able to compile on VS2015, and it seemed not wise to PR something that I couldn't even test, potentially wasting people's time and effort.
So I was hopping by doing the preliminary work, someone could sanity check and submit a valid PR.
scott s.
.
RE: Add sort method "DateAdded" for MusicVideo views - jjd-uk - 2017-07-13
Do you have the change pushed to a fork of the XBMC projec n Github? as any Team member can kick off a build for you using our Jenkins build system if you wish to test before doing a PR.
RE: Add sort method "DateAdded" for MusicVideo views - docwra - 2017-07-14
Nice request! Get it PR'd up, at least then someone could take it over if its wrong in any way.
RE: Add sort method "DateAdded" for MusicVideo views - ironic_monkey - 2017-07-14
so much time wasted...
untested PR submitted; https://github.com/xbmc/xbmc/pull/12495
RE: Add sort method "DateAdded" for MusicVideo views - jjd-uk - 2017-07-14
Scott there is a Win 32 Test Build at http://mirrors.kodi.tv/test-builds/windows/win32/KodiSetup-20170714-c303005-add_sortbydate-x86.exe if you want to test.