(2013-07-13, 07:05)spookybathtub Wrote: I'm using 4.1.9 and I get an error in xbmc.log when loading the list of latest talks

Code:

T:140128643254016 WARNING: GetDurationFromMinuteString <runtime> should be in minutes. Interpreting '00:15:55' as 0 minutes

This type error for every episode. I'm running Frodo 12.2. Sounds like a bug with the addon?

(2013-07-27, 23:46)XBMC_PUNK Wrote: Is there any way to get 720p with this plugin?

(2013-09-26, 06:01)artrafael Wrote: Works fine for me; just watched several videos with this add-on. Check your debug log (wiki) to see why it's not working for you.

Quote:16:02:41 T:4924 WARNING: CVideoInfoTag::GetDurationFromMinuteString <runtime> should be in minutes. Interpreting '00:08:21' as 0 minutes

Quote:16:02:47 T:4616 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.TypeError'>
Error Contents: sequence item 0: expected string, NoneType found
Traceback (most recent call last):
File "C:\Users\Knurlhelm\AppData\Roaming\XBMC\addons\plugin.video.ted.talks\default.py", line 17, in <module>
ted_talks.Main(args_map=args_map).run()
File "C:\Users\Knurlhelm\AppData\Roaming\XBMC\addons\plugin.video.ted.talks\resources\lib\ted_talks.py", line 346, in run
modes[mode].run(self.args_map)
File "C:\Users\Knurlhelm\AppData\Roaming\XBMC\addons\plugin.video.ted.talks\resources\lib\ted_talks.py", line 172, in run
self.run_internal(args)
File "C:\Users\Knurlhelm\AppData\Roaming\XBMC\addons\plugin.video.ted.talks\resources\lib\ted_talks.py", line 190, in run_internal
self.ui.playVideo(args['url'], args['icon'])
File "C:\Users\Knurlhelm\AppData\Roaming\XBMC\addons\plugin.video.ted.talks\resources\lib\ted_talks.py", line 73, in playVideo
title, url, subs, info_labels = self.ted_talks.getVideoDetails(url=url, video_quality=settings.video_quality, subs_language=subs_language)
File "C:\Users\Knurlhelm\AppData\Roaming\XBMC\addons\plugin.video.ted.talks\resources\lib\ted_talks_scraper.py", line 55, in getVideoDetails
subs = subtitles_scraper.get_subtitles_for_talk(talk_html, subs_language, self.logger)
File "C:\Users\Knurlhelm\AppData\Roaming\XBMC\addons\plugin.video.ted.talks\resources\lib\model\subtitles_scraper.py", line 108, in get_subtitles_for_talk
msg = 'No subtitles in: %s' % (",".join(accepted_languages))
TypeError: sequence item 0: expected string, NoneType found
-->End of Python script error report<--

(2013-09-26, 21:29)artrafael Wrote: Please upload your *entire* debug log (wiki) to a public paste site such as www.xbmclogs.com and post just the assigned URL here. Do not paste log contents directly in your post. Also, it would help others trying to reproduce your problem if you mention some of the specific talks you're having trouble viewing.

(2013-09-27, 00:37)Knurlhelm Wrote: Found the issue!

The plugin fails when the XBMC language is set to spanish (dunno why)
The plugin worked fine when I did a factory reset, then I changed the language and I was watching the videos just fine, but when I did close XBMC and re opened the script failed, tried doing the opposite (changing language to english and restarting) and it worked again, so for some reason the script fails when the language is not set to english (tried with dutch too, for the sake of testing), so maybe there is something missing, for now I'm gonna keep the plugin on my computer but remove it from my living room since my family would be pissed if I set the media center to english rofl...

Is there any chance you would add another languages support?, if you do it would be awesome, if you don't, the plugin rocks anyway ^_^

Thank you guys for helping me find a solution
I hope this issue will be useful to someone with similar experience

See ya!

(2013-10-06, 23:19)Knurlhelm Wrote: Yeah you're right, the issue was on the "Enable Subtitles" option, I did change the language to dutch (too lazy to look up for spanish) and went to the plugin config and disabled those subs, and the plugin worked again, enabled it and it stopped working, so it seems that the problem is on fetching subs, I'm gonna try inserting the codes for english and spanish on the plugin to check it out, but for now disabling the subs is getting it done, at least for me, and it work on any language.


Thanks again!

EDIT: I tried the following case scenarios:



and some languages with "Enable Subtitles" Set on off, it worked on all of them

so what I think is that the script fails at the moment it tries to get the XBMC language and set it into the default language code, since the plugin works as intended if you enter the code manually, it also works as intended when you enter more than one code (it follows the order the user set to pick subs), so that's the problem for me, the easier workarounds (for me) would be:

1.- Setting "en" as the default subtitle language
2.- Asking the user for his language and Setting it as custom

What I found is, the problem is on this line on settings:

[language_mapping.get_language_code(xbmc_language)]

If I change it to a string (like ['en']) the video loads and the subtitle charges correctly

I'm gonna keep digging but I'm not that familiar with Python so this may be where I become useless rofl

(2013-10-07, 23:27)moreginger Wrote: Oh man I epic fail. I fixed this ages ago [1] but haven't requested a pull yet.
Need to get my priorities straight and give TED plugin some love! <= this x3

Thank you for the really thorough investigation.

[1] https://github.com/moreginger/xbmc-plugin.video.ted.talks/issues/39