+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Kodi Application (https://forum.kodi.tv/forumdisplay.php?fid=93)
+--- Thread: PR build picking up stale code? (/showthread.php?tid=374480)
PR build picking up stale code? - paul.j.ghosh - 2023-09-20
Why would the PR build be picking up stale code? The line numbers in the errors for a file do not match the actual commit.
PR in question: 23789 (PR)
Action.h snippet:
Code:
26 CAction(int actionID,
27 float amount1 = 1.0f,
28 float amount2 = 0.0f,
29 const std:: string& name = "",
30 unsigned int holdTime = 0,
31 unsigned int buttonCode = 0);
32 CAction(int actionID, wchar_t unicode);
error in recent builds:
/home/jenkins/jenkins-root/workspace/android-arm-docker@2/xbmc/input/actions/Action.h:26:3: note: candidate constructor
CAction(int actionID,
^
/home/jenkins/jenkins-root/workspace/android-arm-docker@2/xbmc/input/actions/Action.h:31:3: note: candidate constructor
CAction(int actionID,
^
RE: PR build picking up stale code? - paul.j.ghosh - 2023-09-22
Heard back from core developer:
sundermann commented 2 days ago
That can happen sometimes if you force push while jenkins is trying to build your PR