[PATCH] LaunchPlayer - External Video Player Launcher (to launch third-party players)

[PATCH] LaunchPlayer - External Video Player Launcher (to launch third-party players) - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Kodi Application (https://forum.kodi.tv/forumdisplay.php?fid=93)
+--- Thread: [PATCH] LaunchPlayer - External Video Player Launcher (to launch third-party players) (/showthread.php?tid=40136)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27

- Jester - 2008-12-04

I've updated the patch to work with the latest SVN (16458) and added it to the ticket

- nekrosoft13 - 2008-12-04

alienagenda Wrote:I really hate to ask this so far into this thread, but what is it that people dislike so much with the mplayer in XBMC?

what ashalar said

Quote:Lack of support for hardware acceleration, lack of performance in h.264 decoding, lack of Reclock-like capabilities.

plus it won't even play some media properly, some SD WMV files cause artifacts, HD WMV files cause huge frame drops and about 20-40 seconds audio sync.

Another thing what I tried explain in my other thread, had to upgrade to quad core to get higher bitrate H264 files to play properly.

Dual Core was able to play them in WMP11 with FFDshow, but XMBC had CPU at almost 100% with frame skips, audio sync issues and motion blur.

- GregKeys - 2008-12-04

Jester, I grabbed your test build.
XBMC just locks up when I try to use the launcher. I get this in the log:

13:51:46 T:1192 M:881258496 NOTICE: CLAUPlayer:OpenFile: V:\Downloads\MPlayer Samples\abs.mpg
13:51:46 T:3516 M:881229824 NOTICE: CLAUPlayer:Filename: "C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe"
13:51:46 T:3516 M:881225728 NOTICE: CLAUPlayer:Args:
13:51:46 T:3516 M:881225728 NOTICE: CLAUPlayer Tongue

rocess: Start
13:51:46 T:3516 M:881221632 NOTICE: CLAUPlayer:ExecuteApp: "C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe" "C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe" "V:\Downloads\MPlayer Samples\abs.mpg"
13:51:46 T:3516 M:881225728 NOTICE: CLAUPlayer:ExecuteAppFailure: 0

If I copy the command line and paste it to a cmd prompt, it fires up just fine.
I have tried this with XBMC in a window and in full screen, with arguements and without. In all cases I do not see mplayerc running in the task manager (process explorer) and XMBC just locks up.

Greg Keys

- Jester - 2008-12-04

uhmm, strange, is the log from the normal log or the debug log ?

- GregKeys - 2008-12-04

Did not have debug on.....
Just noticed, the executeapp line has the app listed twice Huh

My advancedsettings file looks like:

<advancedsettings>
<launchplayer>
<defaultplayer>false</defaultplayer>
<filename>"C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe"</filename>
<args>/d3dfs</args>
</launchplayer>
</advancedsettings>

15:26:24 T:4064 M:856895488 INFO: Loading skin file: DialogContextMenu.xml
15:26:24 T:4064 M:856891392 DEBUG: Load DialogContextMenu.xml: 1.58ms
15:26:24 T:4064 M:856768512 DEBUG: Alloc resources: 10.43ms (0.00 ms skin load, 0.25 ms preload)
15:26:26 T:4064 M:856616960 DEBUG: CPlayerCoreFactor::GetPlayers(V:\Downloads\MPlayer Samples\abs.mpg)
15:26:26 T:4064 M:856616960 INFO: Loading skin file: DialogContextMenu.xml
15:26:26 T:4064 M:856612864 DEBUG: Load DialogContextMenu.xml: 1.70ms
15:26:26 T:4064 M:856743936 DEBUG: Alloc resources: 2.09ms (0.00 ms skin load, 0.17 ms preload)
15:26:27 T:4064 M:856678400 NOTICE: CLAUPlayer:OpenFile: V:\Downloads\MPlayer Samples\abs.mpg
15:26:27 T:2796 M:856645632 DEBUG: thread start, auto delete: 0
15:26:27 T:2796 M:856641536 NOTICE: CLAUPlayer:Filename: "C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe"
15:26:27 T:2796 M:856641536 NOTICE: CLAUPlayer:Args: /d3dfs
15:26:27 T:2796 M:856641536 NOTICE: CLAUPlayer Tongue

rocess: Start
15:26:27 T:2796 M:856641536 NOTICE: CLAUPlayer:ExecuteApp: "C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe" "C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe" /d3dfs "V:\Downloads\MPlayer Samples\abs.mpg"
15:26:27 T:2796 M:856641536 NOTICE: CLAUPlayer:ExecuteAppFailure: 0

- Jester - 2008-12-04

We need konfoo to have a look at this, if somebody else wants to try and post the log too, that might help to diagnose this...

- GregKeys - 2008-12-04

I went back and edited my reply, and I think I was editing when you replied Smile

Look back up at it. Note the double entry of the app name on the Execute App line.

Greg

- Jester - 2008-12-04

GregKeys Wrote:I went back and edited my reply, and I think I was editing when you replied
Look back up at it. Note the double entry of the app name on the Execute App line.

Greg

maybe an issue in parsing the args section, can you try running it without the arg section filled in ?

- GregKeys - 2008-12-04

Still there....
(and still locking up XBMC)

<advancedsettings>
<launchplayer>
<defaultplayer>false</defaultplayer>
<filename>"C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe"</filename>
<args></args>
</launchplayer>
</advancedsettings>

15:54:24 T:904 M:814981120 DEBUG: thread start, auto delete: 0
15:54:24 T:904 M:814977024 NOTICE: CLAUPlayer:Filename: "C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe"
15:54:24 T:904 M:814977024 NOTICE: CLAUPlayer:Args:
15:54:24 T:904 M:814977024 NOTICE: CLAUPlayer Tongue

rocess: Start
15:54:24 T:904 M:814977024 NOTICE: CLAUPlayer:ExecuteApp: "C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe" "C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe" "V:\Downloads\MPlayer Samples\abs.mpg"
15:54:24 T:904 M:814977024 NOTICE: CLAUPlayer:ExecuteAppFailure: 0

- Jester - 2008-12-04

no clue i'm afraid, its up to konfoo and the other dev's to have a look
i assume that if you use another external player you get the same problem...

- GregKeys - 2008-12-04

Took out the args section completely. Still doubled up.....

<advancedsettings>
<launchplayer>
<defaultplayer>false</defaultplayer>
<filename>"C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe"</filename>
</launchplayer>
</advancedsettings>
16:03:10 T:4448 M:808058880 INFO: Loading skin file: DialogContextMenu.xml
16:03:10 T:4448 M:808054784 DEBUG: Load DialogContextMenu.xml: 1.37ms
16:03:10 T:4448 M:807964672 DEBUG: Alloc resources: 20.12ms (0.00 ms skin load, 0.38 ms preload)
16:03:12 T:4448 M:808353792 DEBUG: CPlayerCoreFactor::GetPlayers(V:\Downloads\MPlayer Samples\abs.mpg)
16:03:12 T:4448 M:808353792 INFO: Loading skin file: DialogContextMenu.xml
16:03:12 T:4448 M:808349696 DEBUG: Load DialogContextMenu.xml: 1.49ms
16:03:12 T:4448 M:808300544 DEBUG: Alloc resources: 2.19ms (0.00 ms skin load, 0.17 ms preload)
16:03:14 T:4448 M:808517632 NOTICE: CLAUPlayer:OpenFile: V:\Downloads\MPlayer Samples\abs.mpg
16:03:14 T:912 M:808579072 DEBUG: thread start, auto delete: 0
16:03:14 T:912 M:808574976 NOTICE: CLAUPlayer:Filename: "C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe"
16:03:14 T:912 M:808574976 NOTICE: CLAUPlayer:Args:
16:03:14 T:912 M:808574976 NOTICE: CLAUPlayer Tongue

rocess: Start
16:03:14 T:912 M:808574976 NOTICE: CLAUPlayer:ExecuteApp: "C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe" "C:\Program Files\K-Lite Codec Pack\Media Player Classic\mplayerc.exe" "V:\Downloads\MPlayer Samples\abs.mpg"
16:03:14 T:912 M:808574976 NOTICE: CLAUPlayer:ExecuteAppFailure: 0
16:03:26 T:5512 M:806285312 DEBUG: CThread: Confused

taticThread, deleting thread graphic context
16:03:26 T:5512 M:806285312 DEBUG: Thread 5512 terminating

- GregKeys - 2008-12-04

Fixed it!
XBMC does not seem to like launching with the long space embedded filename for the player. Moved the player, and it now works:

<advancedsettings>
<launchplayer>
<defaultplayer>false</defaultplayer>
<filename>C:\MPC\mplayerc.exe</filename>
</launchplayer>
</advancedsettings>

- Jester - 2008-12-04

nice Smile

- ashlar - 2008-12-04

Hi Jester... it was too good to be true Sad

With the following advancedsettings.xml:

Code:
<advancedsettings>

<launchplayer>

<defaultplayer>true</defaultplayer>

<filename>C:\Program Files\Zoom Player\zplayer.exe</filename>

<args>/Q /FS /PLAY /MOUSEOFF</args>

</launchplayer>

</advancedsettings>

I get XBMC using DVDPlayer for default just the same. And if I select "Play using... Launchplayer" Zoomplayer starts in the background and there's no way of alt-tabbing there. I'm about to cry... Sad

Log for when I just launch a video (and it uses DVDplayer even if the default should be Launchplayer): http://pastebin.com/m5719f30f

Log for when I launch a video using Launchplayer and Zoomplayer starts in the background: http://pastebin.com/m288b71c1

- ashlar - 2008-12-04

GregKeys Wrote:Fixed it!
XBMC does not seem to like launching with the long space embedded filename for the player. Moved the player, and it now works:

<advancedsettings>
<launchplayer>
<defaultplayer>false</defaultplayer>
<filename>C:\MPC\mplayerc.exe</filename>
</launchplayer>
</advancedsettings>

It's not the long space embedded filename, it's the fact that you don't need the " to embed the spaces. I tried putting " at the beginning and end of the filename and it locked up XBMC for me too. Wink