Kodi Community Forum
.CDG Karaoke-files support for music - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Kodi Application (https://forum.kodi.tv/forumdisplay.php?fid=93)
+--- Thread: .CDG Karaoke-files support for music (/showthread.php?tid=4654)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28


- erpi99 - 2006-01-20

in the current implementation, the voice from the microphone is too weak even when the volume is set to 100 in xbmc. i figured out the reason is that only the center channel is open for voice. there are 2 issues with this:

- in a 5.1 dolby digital system, you can notice that the voice is only from the center channel, while the music from the left and right speakers. the voice and music are not mixed together. it sounds plain.

- the voice level is too low.

a small change is required in cdgvoicemanager.cpp to fix the issue. the code change below turn on front left and right channel for the voice and turn off the rest. i have tested the solution for 2 channel and 5.1 systems. it works great. can any developer submit the change to cvs?

in file cdgvoicemanager.cpp line # 104

 // set up the voice stream
 //comment out dsmixbinvolumepair dsmbvp = { dsmixbin_front_center, dsbvolume_max };
 //comment out dsmixbins dsmb = { 1, &dsmbvp};

 // change to all front and center channels
 dsmixbinvolumepair dsmbvp[6] = {
 {dsmixbin_front_left, dsbvolume_max},
 {dsmixbin_front_right, dsbvolume_max},
 {dsmixbin_front_center, dsbvolume_max},
 {dsmixbin_back_left, dsbvolume_min},
 {dsmixbin_back_right, dsbvolume_min},
 {dsmixbin_low_frequency, dsbvolume_min}};
 
 dsmixbins dsmb;
 dsmb.dwmixbincount = 6;
 dsmb.lpmixbinvolumepairs = dsmbvp;
 // end of add all channels


- jmarshall - 2006-01-21

will make the change.


- erpi99 - 2006-01-21

if any developer want to add reverb into the karaoke feature, there is an open source library available.

http://www.openal.org/downloads.html

they even have sdk for xbox and xbox 360 if you can prove that you are a registered xbox software developer.

http://developer.creative.com/article....aid=147






- erpi99 - 2006-01-21

thanks a lot. i noticed that it sounds even better if the center channel is turned off.

need to change

{dsmixbin_front_center, dsbvolume_max},

to

{dsmixbin_front_center, dsbvolume_min},

thanks again


- erpi99 - 2006-01-21

some more information of audio processing.

http://www.harmony-central.com/computer/programming/


- jmarshall - 2006-01-23

will add to cvs.


- you_stole_my_atari - 2006-02-13

hey excellent work all round on this apsect of xbmc functionality....

i've been tracking this thread for ages now to see how the product develops but i've got one quick question...

i've read through all and think this should be the case but when i select an mp3 with a corresponding cdg file it does not automatically launch the visual, instead i need to push the "display" button on the remote... this is quite annoying as it seems everyone does not have to do this... is this function present? if so (i'm running latest cvs etc) would i be best re-installing xbmc and adding cvs or am i overlooking something really obvious as there are no obvious "please launch visuals right away" buttons!

cheers

rob


- creepe - 2006-03-03

(dreamweb @ july 26 2005,04:06 Wrote:wow! this is much improved!

thanks to the developers.. and the donation of the mic!

one question.. is there any chance we might eventually see some kind of reverb addition? i think that would pretty much make it complete.

d.
agreed! the karaoke functionality within xbmc works quite well. 2 improvements which i agree with are:

1. ~29 effects for the microphone - which are fun to play with however no reverb which is the basic of all karaoke voice effects.

2. script that enables the display to pop up immediately following song selection.


- spiff - 2006-04-23

hi,

i just commited some changes to the karaoke stuff. but since i have only one file to test with, and i have no clue how it's supposed to be, i'm kinda working in the blind.

so, feedback please.


- spiff - 2006-04-24

to be a bit grumpy..

the enormous amount of feedback really makes me glad i spent most of my weekend fixing a function that i personally never use.


- C-Quel - 2006-04-24

i don't use it either but kudos spiff! Smile


- Solo0815 - 2006-04-24

kudos from me too
thx


- sollie - 2006-04-24

i dont use it at all, but my girlfriend does. i asked her and see is happy with it.

thanks spiff :bowdown: .


- spiff - 2006-04-25

specifically, i'm looking for feedback on how the sync is. in theory, 0 delay should be the correct one, and i want to set it as default but first i need some confirmations...

and thanks for your support Smile


- sollie - 2006-04-25

i always set it to 0.

sollie.