+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Scrapers (https://forum.kodi.tv/forumdisplay.php?fid=60)
+--- Thread: Help needed with development of new scraper for filmdelta.se (Swedish Movie Scraper)? (/showthread.php?tid=55353)
- Daniel Malmgren - 2009-07-27
vdrfan Wrote:Uhm, whats the current problem with the scraper? The modified version i've attached to the ticket (see above) is working fine for me.
Well, currently I guess everything that I've implemented is working. I haven't included all possible info from filmdelta though. And the thumbs are way to low resolution, I guess I could fetch them from another place (imdb?) instead, right?
Nicezia Wrote:The nature of web-scraping
the page is always bound to change
Yep. I've established a communication with the folks behind filmdelta though, my hope is that they could put up something for me that is not as bound to change. Not sure if it's going to happen though...
/Daniel
- Daniel Malmgren - 2009-07-27
spiff Wrote:it happens if you do a manual lookup using 'movie information' from context
Ah. Thanks there mate. I've always wondered
/Daniel
- Daniel Malmgren - 2009-07-27
vdrfan Wrote:Uhm, whats the current problem with the scraper? The modified version i've attached to the ticket (see above) is working fine for me.
Darn. Just realized that you actually changed stuff in the xml in the ticket. Thought you just posted my xml right up. Means that I've been working in parallell with you.
I'll incorporate my changes into your xml and post again...
/Daniel
- mkortstiege - 2009-07-27
doh! thanks for not ignoring me
- Nicezia - 2009-07-27
not to be thread jacking, but since there's some attention here, what's the accepted indentation on the XML (how many spaces generally do you use per indentation - so i can get the scraper editor outputting to that standard)
- Daniel Malmgren - 2009-07-27
Nicezia Wrote:not to be thread jacking, but since there's some attention here, what's the accepted indentation on the XML (so i can get the scraper editor outputting to that standard)
Yes, I noticed your editor outputting quite ugly intendented code
I think the nicest intendention is the one outputted by a "xmllint --format". But that's only my five pence
/Daniel
(And as for hijacking my thread. You will be punished.)
- Daniel Malmgren - 2009-07-27
vdrfan Wrote:doh! thanks for not ignoring me
I'm thoroughly sorry. In reality I'm a nice guy
/Daniel
- mkortstiege - 2009-07-27
about the indentation stuff.. I don't like the xmllint output that much as it's really hard to read.
- Daniel Malmgren - 2009-07-27
Ok. This is now the result of my and vdrfans joint efforts:
http://trac.xbmc.org/attachment/ticket/6958/filmdelta.xml
Big question now to vdrfan is: Do you fix fetching of thumbs from tmdb (since you've fixed fetching of fanart anyway) or should I look into it? (I'm assuming here that the thumbs at tmdb is generally more useful than the ones at filmdelta)
/Daniel
- mkortstiege - 2009-07-27
Cool. It's up to you
I surely can look at this later today if you want me to.
- spiff - 2009-07-27
do we have a point of translation like imdb id?
- mkortstiege - 2009-07-27
Yeah, imdbid is fetched via google and the original title for fanart atm.
- Daniel Malmgren - 2009-07-27
Don't think I'll be able to work any more on this tonight. Made a little fix so that the list returned from GetSearchResult actually contains the year (made it a little hard choosing otherwise). Latest version:
http://pastebin.com/m2126d552
/Daniel
- Daniel Malmgren - 2009-07-28
vdrfan Wrote:Cool. It's up to you
Ok, now I tried doing it. But xbmc doesn't want the same thing I do
I've got no experience with custom functions, so that might be the problem. Tried looking at the GetTMDBFanart function and made my own GetTMDBPoster, called the same way as GetTMDBFanart. Doesn't get any poster. Where am I thinking wrong?
/Daniel
- spiff - 2009-07-28
hard/impossible to say without seeing what you did