blinkseb Wrote:It's surely related to dsplayer. There're some options to control vsync, not yet on the gui (soon ) and activated by default on this release (were off before). I think it affects people on differents ways.

You can try that :
Create a file named "dsconfig.xml" on your userdata folder, and put that into it

Code:

<dsplayersettings>
  <VMR9VSync>true</VRM9VSync>
  <VMR9VSyncAccurate>true</VMR9VSyncAccurate>
  <VMRFlushGPUBeforeVSync>true</VMRFlushGPUBeforeVSync>
</dsplayersettings>

You can set the options true or false.

hsinchu308 Wrote:Hi seb,

FYI:
I tried putting the above lines into dsconfig.xml and store it in my userdata directory (according to the xbmc.log that's where special://masterprofile/ is mapped to), but it does not seem to work. I tried to turn off VMR9VsyncAccurate but in the Stats screen accurate vsync is still enabled.

As a test, I put some random characters before dsplayersettings, like XYZdisplayersettings, which, according to a quick glance at rendersettings.cpp, should generate a "Doesn't contain <dsplayersettings>" error in the xbmc log, but it does not, so it seem that the file is not been read somehow.

I am using Windows XP SP3, VMR9 renderer instead of EVR.

blinkseb Wrote:Thanks! I'll look at it You're right, you should see a "Doesn't contain blablabla" in the log.

Anyway, the XML file i've given you is wrong, it missed a tag. A correct one would be :

Code:

<dsplayersettings>
  <videorenderers>
    <VMR9VSync>true</VMR9VSync>
    <VMR9VSyncAccurate>true</VMR9VSyncAccurate>
    <VMRFlushGPUBeforeVSync>true</VMRFlushGPUBeforeVSync>
  </videorenderers>
</dsplayersettings>

I'll try to make it works quickly

EDIT: It's fixed on my side, code was soo buggy. I make some tests and commit the changes.

hsinchu308 Wrote:Cool! Maybe I can trouble you for one more thing. Right now for videos that don't use square pixels (i.e., a lot of the SD videos use 720x480 resolution, or 3:2 ratio, but actually need to be displayed in either 4:3 or 16:9 aspect ratio), the "NORMAL" view mode in dsplayer displays the video in square pixels, requiring the user to switch to either the "stretch 4:3" mode, or "stretch 16:9" mode to display the correct video aspect ratio. If the video is in some other aspect ratio, like 14x9, then you need to adjust the pixel ratio on the OSD. On the other hand, dvdplayer in "NORMAL" view mode uses the correct aspect ratio stored in the video file header (I use MediaInfo to look), so no mode switching or pixel ratio adjustment is needed. I've narrowed down the calculation of the pixel aspect ratio for the dsplayer in "NORMAL" mode to BaseRenderer::SetViewMode in BaseRenderer.cpp. But I need to know where dsplayer stores the "display aspect ratio" (target aspect ratio) that it reads from video file headers.

OTOH, if you prefer to tackle this yourself that's fine with me too.

offline_thk Wrote:No idea?

gulp Wrote:with a clean installation of rev 30589,
xbmc doesn't start, in log i've:

Code:

16:04:20 T:3844 M:2521030656  NOTICE: Loading player core factory settings from special://profile/playercorefactory.xml.
16:04:20 T:3844 M:2521014272  NOTICE: Loaded playercorefactory configuration
16:04:20 T:3844 M:2521014272  NOTICE: No advancedsettings.xml to load (special://masterprofile/advancedsettings.xml)
16:04:20 T:3844 M:2521014272  NOTICE: Default DVD Player: dvdplayer
16:04:20 T:3844 M:2521014272  NOTICE: Default Video Player: dvdplayer
16:04:20 T:3844 M:2521014272  NOTICE: Default Audio Player: paplayer
16:04:20 T:3844 M:2521042944  NOTICE: Loading media sources from special://masterprofile/sources.xml
16:04:22 T:3844 M:2499248128  NOTICE: initializing playlistplayer
16:04:22 T:3844 M:2499248128  NOTICE: DONE initializing playlistplayer
16:04:22 T:3844 M:2499260416   ERROR: Default skin 'skin.confluence' not found! Terminating..

obviously /addons/skin.confluence exist and is populated

blinkseb Wrote:Weird. If you're running from VS, have you defined the XBMC_HOME environment variable in the debugging section ?

ten8Epee Wrote:Sorry if this has been discussed throughout the numerous pages...but after installation for some reason I am limited to only PM.3 and Confluence Skins. How do I get my custom skin back (Rapier)?

Quote:I had it working with the previous release but I just updated to the newest release here and I am now stuck with the ugly default skins :

blinkseb Wrote:You need to know that dsplayer doesn't read the media file itself. Each available informations come from DirectShow and the filters.

AFAIK, the aspect ratio is calculated with display width / height. But, since I'm not sure what you're looking for (:p), you'll find everything you need in DX9AllocatorPresenter.cpp, EVRAllocatorPresenter.cpp and VMR9AllocatorPresenter.cpp. The DX9AllocatorPresenter:aint may be the more important (drawing is done here).

Hope you'll find what you're looking for, I'm not very aware of these aspect ratio things

Since r30589, things have changed a little bit. Now, to tweak the renderer settings, you need to create a XML file in your userdata folder named dsrenderersettings.xml, with the following structure :

Code:

<dsrenderersettings>
  <sharedsettings>
    
  </sharedsettings>
  <evrsettings>
    
  </evrsettings>
  <vmr9settings>
    
  </vmr9settings>
</dsrenderersettings>

As you can easily understand, there're three categories. The first one contains settings shared by the two renderers. The two others settings for each renderer. You can find a list of what setting you can tweak here : http://trac.xbmc.org/browser/branches/dsplayer/xbmc/cores/DSPlayer/Filters/RendererSettings.cpp, starting at line 103. You can see default values here : http://trac.xbmc.org/browser/branches/dsplayer/xbmc/cores/DSPlayer/Filters/RendererSettings.h (SetDefault methods).

If someone wants to document theses settings on the wiki, feel welcomed!

An example :

Code:

<dsrenderersettings>
  <sharedsettings>
    <VSync>false</VSync>
  </sharedsettings>
  <evrsettings>
    <HighColorResolution>true</HighColorResolution>
  </evrsettings>
  <vmr9settings>
    
  </vmr9settings>
</dsrenderersettings>

rickardkk Wrote:Great work with the DSPlayer branch.

I have a hard time to get fluid playback when automatically setting the refresh rate to match the frame rate though. Using the same codecs in MPC-HC or Media Portal will give smooth playback without any stutter (using ReClock). But here I get like sporadic stutters.

Are you aware of this (I've seen it mentioned in the thread earlier) or should I post a debug log and samples?

hsinchu308 Wrote:Hi Seb,

Wanted to try out the new setting so updated to r30594 and compiled using VC2010 (VC2008 gives me undefined ref when linking xbmc.exe), but xbmc crashed during startup.

Here's the pastebin debug log:
http://pastebin.com/HJ82JGNU

Regards,

EDIT: I did a clean install, and removed the userdata settings in the Application Data\XBMC directory