+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: General Support (https://forum.kodi.tv/forumdisplay.php?fid=111)
+---- Forum: Windows (https://forum.kodi.tv/forumdisplay.php?fid=59)
+---- Thread: [WINDOWS] Internal Directshow Based Player [NO LONGER DEVELOPED] (/showthread.php?tid=61355)
Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
- hsinchu308 - 2010-05-28
blinkseb Wrote:Ok so it's not only on my side. r30594 messed with something and I don't know why. Please stay below until I found why it crashes ... If you have some times, can you try with a really clean build? (I mean delete the folder, checkout and build) Maybe it's because it's linking against outdated lib, I don't know...
O, I'll try it. But my development machine is a not-so-speedy Intel Atom 1.6Ghz (the original Asus EEE Box) that I had lying around, so it will take a while.
- adb76 - 2010-05-28
blinkseb Wrote:Ok so it's not only on my side. r30594 messed with something and I don't know why. Please stay below until I found why it crashes ... If you have some times, can you try with a really clean build? (I mean delete the folder, checkout and build) Maybe it's because it's linking against outdated lib, I don't know...
Hi Seb,
so I already made a real fresh compile of the dsplayer (svn download to a complete new folder) with VS2010 last evening. Then I deleted my old xbmc installation completely (including the user folder), and manually activated the debug log in guisettings.xml - and r30594 crashed again at the start. Here you will find the debug log http://pastebin.com/2UzKyd7w and the crashlog http://www.megaupload.com/?d=JT8MGOGL
Greetings,
André
- hsinchu308 - 2010-05-28
adb76 Wrote:Hi Seb,
so I already made a real fresh compile of the dsplayer (svn download to a complete new folder) with VS2010 last evening. Then I deleted my old xbmc installation completely (including the user folder), and manually activated the debug log in guisettings.xml - and r30594 crashed again at the start. Here you will find the debug log http://pastebin.com/2UzKyd7w and the crashlog http://www.megaupload.com/?d=JT8MGOGL
Greetings,
André
Yes, I can confirm as well. Just downloaded svn to a new folder, compiled with VC2010, uninstalled and then make sure that XBMC folder under Program Files and XBMC folder under the User/Application Data directory are deleted, then install XBMC. Still crash at the same place.
- blinkseb - 2010-05-28
adb76 Wrote:Hi Seb,
so I already made a real fresh compile of the dsplayer (svn download to a complete new folder) with VS2010 last evening. Then I deleted my old xbmc installation completely (including the user folder), and manually activated the debug log in guisettings.xml - and r30594 crashed again at the start. Here you will find the debug log http://pastebin.com/2UzKyd7w and the crashlog http://www.megaupload.com/?d=JT8MGOGL
Greetings,
André
hsinchu308 Wrote:Yes, I can confirm as well. Just downloaded svn to a new folder, compiled with VC2010, uninstalled and then make sure that XBMC folder under Program Files and XBMC folder under the User/Application Data directory are deleted, then install XBMC. Still crash at the same place.
After two hours, I wasn't be able to find the reason of the crash. Maybe some of you can help me :
I've introduced a new proprocessor define, HAS_DS_PLAYER, in order to be able to build xbmc without DSPlayer (a request from spdiff :p). Fun things,if you build latest dsplayer rev without the HAS_DS_PLAYER define (in the Preprocessor fiels on XBMC project properties), no crash, it works fine.
If you define HAS_DS_PLAYER, it builds fine, but it crashes.
Technical part :
It crashes on a std::vector::push_back(). It's nearly impossible that vector::push_back() crashes, so it's a memory corruption problem somewhere. I'll investigate a bit more this afternoon (it's 10 am here) because there's no reason for crashing :p
EDIT: Great news, it's fixed. For those interested, HAS_DS_PLAYER was not defined for guilib project. So, two differents class definitions was linked together, so, big mess and crash! It's fixed now
- adb76 - 2010-05-28
blinkseb Wrote:EDIT: Great news, it's fixed. For those interested, HAS_DS_PLAYER was not defined for guilib project. So, two differents class definitions was linked together, so, big mess and crash! It's fixed now
So I've recompiled and installed it - and it works really great. First I had some stuttering with 1080p mkv's. Then I've defined the "dsrenderersettings.xml" with the following content:
Code:
<dsrenderersettings>
<sharedsettings>
<VSync>false</VSync>
</sharedsettings>
<evrsettings>
</evrsettings>
<vmr9settings>
</vmr9settings>
</dsrenderersettings>And now I've automatic switch of the refresh rate and really smooth playback! Great. Many thanks to the team!!!
- Nedder - 2010-05-28
Don't you get tearing with vsync disabled?
- hsinchu308 - 2010-05-28
Nedder Wrote:Don't you get tearing with vsync disabled?
Not if you are running under Windows 7, with Aero (desktop composition) enabled, and fake full screen. When I run MPC-HC as an external player under Win7 w/Aero, I disable all sync as well and don't get any tearing. Too many vsync algorithms running together can cause dropped frames and/or stuttering.
- rickardkk - 2010-05-28
adb76 Wrote:So I've recompiled and installed it - and it works really great. First I had some stuttering with 1080p mkv's. Then I've defined the "dsrenderersettings.xml" with the following content:
Code:<dsrenderersettings>
<sharedsettings>
<VSync>false</VSync>
</sharedsettings>
<evrsettings>
</evrsettings>
<vmr9settings>
</vmr9settings>
</dsrenderersettings>
And now I've automatic switch of the refresh rate and really smooth playback! Great. Many thanks to the team!!!
Perfect playback here to (with the setting above). But it hangs on enabling the HTTP API/webserver (not broken in latest main branch build 30621) and sometimes on skiping.
Playback is smooth!! Great work!!
- zilexa - 2010-05-28
Hi Seb, didn't had time to test anymore unfortunately but I see there has been development. Might be best for me to wait for a new build? to test mpcvideodec further on WinXP?
- blinkseb - 2010-05-28
zilexa Wrote:Hi Seb, didn't had time to test anymore unfortunately but I see there has been development. Might be best for me to wait for a new build? to test mpcvideodec further on WinXP?
Testing under XP is a bit dangerous right now :p I need some times to find why there's a crash whi the auto refresh rate feature
Oh, I won't be available tomorrow, I'll get some fun at Europapark (http://www.europapark.de/lang-en/Home/c51.html) !
But sunday I think I'll have some free time, even if it's Mother's Day here in France.
Anyway, it's interessting that disabling vsync actually make the render better, but why not! A new think to look at :p
- ten8Epee - 2010-05-28
blinkseb Wrote:That's kind of opinion is yours. So, keep it for yourself please. I think you can be more grateful to people who make a *HARD* work to give you the best experience. You don't like the default skin, it's alright. But it's certainly not ugly. Thanks
Geez man, were you having a bad day? No need to take offense as if I called your child an ugly snot eater... I have been u sing XBMC from the very beginning and have am deeply grateful for everything these people do here. I dont believe expressing my feelings on the aesthetics of a skin as being a spiteful and rude remark. In fact, I didn't necessarily even mean to call the default skins ugly... I was just trying to figure out if this is a known problem.
Anyways, for some reason when I used the installer in the OP it must have made some type of conflict because I would put skins in the proper folders and it just wouldn't show. I thought perhaps the skins were not supported or something. Even after a clean install it wouldn't work.
- rickardkk - 2010-05-28
blinkseb Wrote:Anyway, it's interessting that disabling vsync actually make the render better, but why not! A new think to look at :p
Night and day when using 23.976Hz refresh rate. Just as smooth as MPC-HC when vsync is disabled in the dsrenderersettings. Actually playback is near perfect now!!
Four problems encountered though:
1. Sometimes (can't reproduce at will) when starting playback the frame rate is at 4.0 fps (right after the refresh rate change). And it stays there until you do a small skip forward. After that it starts playback at the correct frame rate. Don't think this is of any help, but here is the debug log: http://pastebin.com/9tJSR3Pp
Have only been able to reproduce this when the "match refreshrate/framerate" option is enabled.
2. Skipping (backwards/forwards) does crash XBMC quite often.
Log: http://pastebin.com/qPMBhTV5
Dump: http://www.earselect.se/test/skipping.dmp
3. 50fps/25fps mks can't be played it seems. Tested alot of them and I always get the same message in the log:
http://pastebin.com/RCusccFr
4. Videos with non square pixels are not displayed with the correct AR. DVDPlayer displays them with correct AR (in Normal "zoom" mode)
Windows 7 32-bit
XBMC 30642
(Fullscreen windows rather than true...." option enabled
- hsinchu308 - 2010-05-29
rickardkk Wrote:Night and day when using 23.976Hz refresh rate. Just as smooth as MPC-HC when vsync is disabled in the dsrenderersettings. Actually playback is near perfect now!!
Four problems encountered though:
1. Sometimes (can't reproduce at will) when starting playback the frame rate is at 4.0 fps (right after the refresh rate change). And it stays there until you do a small skip forward. After that it starts playback at the correct frame rate. Don't think this is of any help, but here is the debug log: http://pastebin.com/9tJSR3Pp
Have only been able to reproduce this when the "match refreshrate/framerate" option is enabled.
2. Skipping (backwards/forwards) does crash XBMC quite often.
Log: http://pastebin.com/qPMBhTV5
Dump: http://www.earselect.se/test/skipping.dmp
3. 50fps/25fps mks can't be played it seems. Tested alot of them and I always get the same message in the log:
http://pastebin.com/RCusccFr
4. Videos with non square pixels are not displayed with the correct AR. DVDPlayer displays them with correct AR (in Normal "zoom" mode)
Windows 7 32-bit
XBMC 30642
(Fullscreen windows rather than true...." option enabled
#4 has been observed and reported by a few people, including myself.
Anyway, I spent some time and finally found a fix. Tested it on camcorder videos that are in 720x480 resolution (AR 3:2). Before the fix they are always displayed in AR 3:2, in "Normal" zoom mode, though they should be either 4:3 or 16:9 AR, and after the fix they are displayed correctly, just like in dvdplayer. Also tested other files that have non-square pixels in other video resolutions beside 720x480, and they also displayed correctly, like in dvdplayer.
So far I've only test on VMR9 and not EVR, using r30642, because my windows XP crashes with BSOD when I use EVR.
The fix: Change line 660 in VMR9AllocatorPresentor.cpp
from:
g_renderManager.Configure(m_NativeVideoSize.cx, m_NativeVideoSize.cy, m_NativeVideoSize.cx, m_NativeVideoSize.cy, m_fps,
CONF_FLAGS_FULLSCREEN);
to:
g_renderManager.Configure(m_NativeVideoSize.cx, m_NativeVideoSize.cy, m_AspectRatio.cx, m_AspectRatio.cy, m_fps,
CONF_FLAGS_FULLSCREEN);
Do the same thing for line 1672 in EVRAllocatorPresenter.cpp (NOT tested yet).
- zilexa - 2010-05-29
hsinchu308 Wrote:So far I've only test on VMR9 and not EVR, using r30642, because my windows XP crashes with BSOD when I use EVR.
WinXP doesn't have EVR so that is normal
XP has VMR9, Vista/Win7 have EVR.Each have their own DXVA specs, VMR9 has 1.0 spec and EVR has 2.0 spec.
Do you test using the MPC Video decoder? On WinXP 32bit? Does any video (like mpeg4 or h264 or mpeg2/dvd) play correctly?
- rickardkk - 2010-05-29
Great. I will test it on EVR as soon as I get it to compile. Are blinkseb aware of this patch?