zilexa Wrote:WinXP doesn't have EVR so that is normal XP has VMR9, Vista/Win7 have EVR.
Each have their own DXVA specs, VMR9 has 1.0 spec and EVR has 2.0 spec.

Do you test using the MPC Video decoder? On WinXP 32bit? Does any video (like mpeg4 or h264 or mpeg2/dvd) play correctly?

rickardkk Wrote:Great. I will test it on EVR as soon as I get it to compile. Are blinkseb aware of this patch?

rickardkk Wrote:Night and day when using 23.976Hz refresh rate. Just as smooth as MPC-HC when vsync is disabled in the dsrenderersettings. Actually playback is near perfect now!!

Four problems encountered though:

1. Sometimes (can't reproduce at will) when starting playback the frame rate is at 4.0 fps (right after the refresh rate change). And it stays there until you do a small skip forward. After that it starts playback at the correct frame rate. Don't think this is of any help, but here is the debug log: http://pastebin.com/9tJSR3Pp
Have only been able to reproduce this when the "match refreshrate/framerate" option is enabled.

2. Skipping (backwards/forwards) does crash XBMC quite often.
Log: http://pastebin.com/qPMBhTV5
Dump: http://www.earselect.se/test/skipping.dmp

3. 50fps/25fps mks can't be played it seems. Tested alot of them and I always get the same message in the log:
http://pastebin.com/RCusccFr

4. Videos with non square pixels are not displayed with the correct AR. DVDPlayer displays them with correct AR (in Normal "zoom" mode)

Windows 7 32-bit
XBMC 30642
(Fullscreen windows rather than true...." option enabled

hsinchu308 Wrote:#4 has been observed and reported by a few people, including myself.

Anyway, I spent some time and finally found a fix. Tested it on camcorder videos that are in 720x480 resolution (AR 3:2). Before the fix they are always displayed in AR 3:2, in "Normal" zoom mode, though they should be either 4:3 or 16:9 AR, and after the fix they are displayed correctly, just like in dvdplayer. Also tested other files that have non-square pixels in other video resolutions beside 720x480, and they also displayed correctly, like in dvdplayer.

So far I've only test on VMR9 and not EVR, using r30642, because my windows XP crashes with BSOD when I use EVR.

The fix: Change line 660 in VMR9AllocatorPresentor.cpp
from:
g_renderManager.Configure(m_NativeVideoSize.cx, m_NativeVideoSize.cy, m_NativeVideoSize.cx, m_NativeVideoSize.cy, m_fps,
CONF_FLAGS_FULLSCREEN);
to:
g_renderManager.Configure(m_NativeVideoSize.cx, m_NativeVideoSize.cy, m_AspectRatio.cx, m_AspectRatio.cy, m_fps,
CONF_FLAGS_FULLSCREEN);

Do the same thing for line 1672 in EVRAllocatorPresenter.cpp (NOT tested yet).

rickardkk Wrote:Great. I will test it on EVR as soon as I get it to compile. Are blinkseb aware of this patch?

blinkseb Wrote:Thanks for the feedback!

So, quickly. Skipping, fast forward etc... are known to be broken. I just need more time to solve it and there're lots of things that need to be corrected! But it will.

3. It seems like haali don't like your files! Does the same file play in mpc with the same codec configuration? (or in graphstudio?)



That is a GREAT news! Thanks a lot! I'll test that tonight or tomorrow, and commit the change? No reason it works for VMR and not for EVR! Thanks again!

Next time, can you please post a patch file on pastebin instead of code ? Thanks


Don't worry, I'm always here, and I read everything, even if sometimes I don't answer!

hsinchu308 Wrote:Hi,

I can create a patch file w/ TortoiseSVN, but I've added a lot of debug statements to the files, so it maybe seem a bit confusing to locate the changes. I am hoping that by posting codes that only take a line or two, they can be quickly implemented by other testers and then comment on whether or not they work. But for changes that are more than two lines, a patch file is the way to go.

In any case, I got a chance to test the display aspect ratio fix on a Windows 7 32bit machine using EVR, and they work fine.

FYI: on the Win7 machine, I turned off all vsync inside dsplayer (Vsync, Accurate Vsync, Alternative Vsync), using dsrenderersettings.xml, and used true full screen mode, and did NOT get any tearing. I did have the Aero desktop enabled though, as I said before.

The mpcvideodec.ax is still a bit problematic on the Win7 machine though. About 20% percent of the time the video freezes at the first frame (unlike my Windows XP machine, which is 100% of the time). Also, on the Win7 machine, with EVR, subtitle switching using the "L" key often freezes the video, though skipping forward fixes the freeze about 50% of the time (this does not happen at all on my XP machine, weird ).

sentinel41 Wrote:Where do you place the dsrenderersettings.xml?

hsinchu308 Wrote:Hi,

I can create a patch file w/ TortoiseSVN, but I've added a lot of debug statements to the files, so it maybe seem a bit confusing to locate the changes. I am hoping that by posting codes that only take a line or two, they can be quickly implemented by other testers and then comment on whether or not they work. But for changes that are more than two lines, a patch file is the way to go.

In any case, I got a chance to test the display aspect ratio fix on a Windows 7 32bit machine using EVR, and they work fine.

FYI: on the Win7 machine, I turned off all vsync inside dsplayer (Vsync, Accurate Vsync, Alternative Vsync), using dsrenderersettings.xml, and used true full screen mode, and did NOT get any tearing. I did have the Aero desktop enabled though, as I said before.

The mpcvideodec.ax is still a bit problematic on the Win7 machine though. About 20% percent of the time the video freezes at the first frame (unlike my Windows XP machine, which is 100% of the time). Also, on the Win7 machine, with EVR, subtitle switching using the "L" key often freezes the video, though skipping forward fixes the freeze about 50% of the time (this does not happen at all on my XP machine, weird ).

tiben20 Wrote:Interesting, you should see the patch i have done a while ago i totally converted the mpc video decoder into xbmc but the only thing that is keeping me from posting it is the dxva not working due to the way mpc-hc is using a static link to ffmpeg. With the patch i didnt get those freeze of skip forward

tiben20 Wrote:Interesting, you should see the patch i have done a while ago i totally converted the mpc video decoder into xbmc but the only thing that is keeping me from posting it is the dxva not working due to the way mpc-hc is using a static link to ffmpeg. With the patch i didnt get those freeze of skip forward

zilexa Wrote:If you are really planning to build-in the MPC decoder, will that be the newer version that also has DXVA for MPEG-2? Since march or april the svn versions have this feature, DXVA for VC-1, H.264 and MPEG-2.

>>X<<' Wrote:That might sound good to some but I hope we don't lose DSPlayer as it is now with the ability to use any audio/video codec you like

tiben20 Wrote:The only reason why im coding this is to have everything built-in. Elupus told me at start that i cant include mpc-hc filters in the installation directly. So if i want the dsplayer to be able to handle as much type of video files as dvdplayer i have to code a video decoder an audio decoder and a demultiplexer. Right now the video and demuxer are really advanced and the audio decoder is not started yet.

tiben20 Wrote:The only reason why im coding this is to have everything built-in. Elupus told me at start that i cant include mpc-hc filters in the installation directly. So if i want the dsplayer to be able to handle as much type of video files as dvdplayer i have to code a video decoder an audio decoder and a demultiplexer. Right now the video and demuxer are really advanced and the audio decoder is not started yet.

>>X<<' Wrote:Sorry if I'm being thick so you are saying we would lose the ability to use other audio video codecs/filters like ffdshow, coreavc etc ?