hsinchu308 Wrote:My suggestion would be to put those important, or often tweaked options, that are exclusive to dsplayer, like subtitle shadow depth, inside a dsplayer tab, like the current one you have inside Video Settings. This way, 1) you don't confuse people (for example, dvdplayer does not have subtitle shadow at all), 2) you can make the whole dsplayer tab, with all its options, disappear by setting the HAS_DSPLAYER option at compile time, without altering other tabs at all, and 3) easier for the dsplayer user, because all dsplayer-specific options are inside one tab, instead of spreading over many tabs (like subtitle tab, audio tab, etc.)

hsinchu308 Wrote:Hi Joe,

Not sure if this is the cause of your problem but I thought I'd share my experience in case other people are having the same problem. I am running Windows XP SP3 w/ Nvidia 8400GS PCI.

For the past week or so I have been troubleshooting a stutter problem with dsplayer. The most curious/interesting/frustrating part for me was that I was using the same settings and codec that I use in MPC-HC, like MPCVideoDec codec (DXVA), setting of Vsync, Accurate Vsync, Flush GPU Before Vsync, subtitle maximum texture size to 800x600 (had to compile my own), subtitle subpictures to buffer to 3, etc., yet MPC-HC did not stutter, but dsplayer did - once every few seconds.

I finally found the cause: the Vsync in the XBMC Systems -Settings (Vertical Blank Sync) was set to "Always Enabled", and was interfering with the Vsync inside dsplayer! I had to disable it by setting it to "Disabled". Then the stuttering was gone. Eventually, I found the best setting was actually to disable all vsync inside dsplayer, set XBMC to true fullscreen, and set Vertical Blank Sync to "Always Enabled", to get the smoothest playback.

Curiously, in the 28xxx and 29xxx builds, this setting did not have any effect at all inside dsplayer, because it was set to "Always Enabled" as the default, yet I still got tearing in Windows XP.

Quote:Thanks, I'll give that a try later at home. Possibly what you describing is similar to a "double negative" that cancels itself out, maybe a programming logic error?

In any case do you disable the vsync options for dsplayer in specific as you suggest in the xml file that Seb posted about a couple of times a few pages back? If so, can you please paste in the settings you are using to save some trial and error on my part?

Thanks again
The REAL Joe

blinkseb Wrote:Beware, the xml file doesn't work with the latest build released. You'll need to build your own dsplayer to add this feature

blinkseb Wrote:Oh, while I think about it, I've tried to add the VMR7 renderer. Unfortunatly, it uses DirectX 7, and XBMC uses DirectX 9. It would need a complete rewrite of the XBMC renderer to use DirectX 7 But it seems like tearing is gone, hopefully for ever... !

hsinchu308 Wrote:Hi Joe,

Not sure if this is the cause of your problem but I thought I'd share my experience in case other people are having the same problem. I am running Windows XP SP3 w/ Nvidia 8400GS PCI.

For the past week or so I have been troubleshooting a stutter problem with dsplayer. The most curious/interesting/frustrating part for me was that I was using the same settings and codec that I use in MPC-HC, like MPCVideoDec codec (DXVA), setting of Vsync, Accurate Vsync, Flush GPU Before Vsync, subtitle maximum texture size to 800x600 (had to compile my own), subtitle subpictures to buffer to 3, etc., yet MPC-HC did not stutter, but dsplayer did - once every few seconds.

I finally found the cause: the Vsync in the XBMC Systems -Settings (Vertical Blank Sync) was set to "Always Enabled", and was interfering with the Vsync inside dsplayer! I had to disable it by setting it to "Disabled". Then the stuttering was gone. Eventually, I found the best setting was actually to disable all vsync inside dsplayer, set XBMC to true fullscreen, and set Vertical Blank Sync to "Always Enabled", to get the smoothest playback.

Curiously, in the 28xxx and 29xxx builds, this setting did not have any effect at all inside dsplayer, because it was set to "Always Enabled" as the default, yet I still got tearing in Windows XP.

blinkseb Wrote:I guess your analyse is good. The Paint() method of the renderer is called by XBMC itself, so any vsync options delay the method calls. But, inside the Paint() method, if renderer vsync is enabled, there's another delay, resulting I guess in playback stuttering.

I see two solutions : First, disable vsync in the renderer and lets XBMC do the job (seems like the best?). Second, enable vsync in the renderer, but automatically disable XBMC vsync when using dsplayer.

I think the two solutions deserve to be tested. I add it on my todo list.

PS: On the 28xxx and 29xxx revisions, vsync was disabled by default and implementation was buggy.

hsinchu308 Wrote:Thanks for the explanation about the Paint() method. Now it makes sense to me. I was thinking of an easy (hopefully) solution: Right now you have 3 choices in Vertical Blank Sync - 1) Always Enabled, 2) Disabled and 3) Enabled During Video Playback; how about adding a fourth choice: Disabled During Video Playback . This way the user has a more complete control over when Vsync is used inside XBMC.

PS. I just want to thank you again for all the time you've spent helping us with our questions and problems.

hsinchu308 Wrote:My suggestion would be to put those important, or often tweaked options, that are exclusive to dsplayer, like subtitle shadow depth, inside a dsplayer tab, like the current one you have inside Video Settings. This way, 1) you don't confuse people (for example, dvdplayer does not have subtitle shadow at all), 2) you can make the whole dsplayer tab, with all its options, disappear by setting the HAS_DSPLAYER option at compile time, without altering other tabs at all, and 3) easier for the dsplayer user, because all dsplayer-specific options are inside one tab, instead of spreading over many tabs (like subtitle tab, audio tab, etc.)

tiben20 Wrote:Since the start i coded in a way dsplayer is only seen for the people using windows with directx rendering. I dont know why we would need an option HAS_DSPLAYER. The only problem we are facing for the settings is i really dont want to add a button on the osd gui for the dsplayer options. This would require to add the button in every skin this would be way too long and confusing for users.

blinkseb Wrote:Why not! It's a little bit weird to have vsync for the gui but not for the video, but in our case, it makes sense. But wouldn't it be confusing for the user? I guess we could do something like that : when the user enable vsync in dsplayer, it aucomatically switch to "Disabled During Video Playback". This way, no more conflicts.

Hm, I like this idea! I add it on my todo list

zoing Wrote:Hi Seb,

maybe it is my stupidity, but for me it is not possible to change the dxva codec?
I tested it with the arcsoft and the cyberlinc codec but dsplayer uses always the mpc codec. I use the 30829 build.
I can change the codec for the xvid/divx to arcsoft for example. This works.
In the debug log there seems no error. http://pastebin.com/3ZAd5S4c

Here is the section from the mediasconfig file.
<video>
<video dxva="true" filter="arcsoftvideodec" />
<!video filter="mpcvideodec" />
</video> -->

Maybe you can look into this.

PS: Great work on the FastForward and Rewind part of the player. Works flawlessly

Quote:<rule filetypes="mkv">
<source filter="mkvsource" />
<splitter filter="mkvsplitter" />
<video>
<video dxva="true" filter="arcsoft" />
<video filter="mpcvideodec" />
</video>
<audio filter="ffdaudiodec" />
</rule>

blinkseb Wrote:The HAS_DS_PLAYER define is already in place in the code, as requested by spdiff. Indeed, some may want to compile xbmc without dsplayer (microsoft, closed source, etc...), and futhermore, what if someone want to port xbmc to win mobile 7 / WinCE ? DirectX would be present, but not DirectShow.

Anyway it's not a big deal

And I agree on the OSD button, it will only be confusing for users.

blinkseb Wrote:It seems like you're not very familiar with XML syntax, no? In case of, read this http://www.w3schools.com/xml/xml_tree.asp

If you want to use DXVA with arcsoft for example :



You can't have a "!" in your tag name. Moreover, the "-->" is only here to say "this is the end of my comment, which starts with "<!--" ".

zoing Wrote:As i said it before it was my stupidity. Thanks for looking into it. It works now.
And no I am not familiar with XML syntax but always willing to learn.

therealjoeblow Wrote:Ok, I disabled Vsync from the main system settings page, and sure enough, the cures the judder problem when using the dxva decoder and video displays perfectly smooth with no tearing. HOWEVER, it reintroduces tearing when using the software decoder.

So that's only a partial solution, either I get judder s/dxva and no tearing with software decoder, or no judder w/dxva and tearing with software :-(

Hopefully this can be sorted to give no judder and no tearing regardless of the decoder.

At least we're on the right track here and seem to have narrowed things down.

Have a great weekend everyone!

Cheers
The REAL Joe