Kodi Community Forum
[RELEASE] CU Lyrics (Script) Addon - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Lyrics Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=146)
+---- Thread: [RELEASE] CU Lyrics (Script) Addon (/showthread.php?tid=62853)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26


- paco - 2009-11-30

Nice release Amet. Most files work but I had some issues that required me to copy the 'language' folder from XBMC into the resources folder of CU Lyrics to make it work. I also get messages like below with every search:

DEBUG: CGUIMediaWindow::GetDirectory (?)
DEBUG: ParentPath = []
ERROR: DIRECTORY::CDirectory::GetDirectory - Error getting ?
ERROR: CGUIMediaWindow::GetDirectory(?) failed

I also have run into capitalization issue. ZZ Top won't return any results because it changes the 2nd 'Z' to lowercase. The paste below is what CU Lyrics sends:

http://lyricwiki.org/index.php?title=Zz%20Top:La%20Grange&action=edit

If you modify the above post to 'ZZ' in a browser, it works. Too bad Lyricwiki is so case-sensitive.

Those issues aside this script looks quite nice. Great work!


- Loto_Bak - 2009-11-30

Thanks for the hard work,

I'm having a different problem.
Using confluance, I cannot escape out of the script
I am able to navigate the up/down arrows but cannot navigate to the 'X' button
The standard back and home buttons are ineffective

If I start the script in the 'scripts' window I am only able to change to fullscreen vis but not change back
If I start the script in fullscreen vis I cannot escape anywhere

Much appreciated, my most used script forsure

*edit
on song change the script does not attempt to fetch the new song.


- amet - 2009-11-30

woodyearl Wrote:http://www.mediafire.com/?k5djatz3eow

paco Wrote:Nice release Amet. Most files work but I had some issues that required me to copy the 'language' folder from XBMC into the resources folder of CU Lyrics to make it work. I also get messages like below with every search:

DEBUG: CGUIMediaWindow::GetDirectory (?)
DEBUG: ParentPath = []
ERROR: DIRECTORY::CDirectory::GetDirectory - Error getting ?
ERROR: CGUIMediaWindow::GetDirectory(?) failed

I also have run into capitalization issue. ZZ Top won't return any results because it changes the 2nd 'Z' to lowercase. The paste below is what CU Lyrics sends:

http://lyricwiki.org/index.php?title=Zz%20Top:La%20Grange&action=edit

If you modify the above post to 'ZZ' in a browser, it works. Too bad Lyricwiki is so case-sensitive.

Those issues aside this script looks quite nice. Great work!


Updated first post with version 0.6.0, it should take care of capitalization issue

Let me know if it works for you.
Thanks for testing
Zeljko


- amet - 2009-11-30

Loto_Bak Wrote:Thanks for the hard work,

I'm having a different problem.
Using confluance, I cannot escape out of the script
I am able to navigate the up/down arrows but cannot navigate to the 'X' button
The standard back and home buttons are ineffective

If I start the script in the 'scripts' window I am only able to change to fullscreen vis but not change back
If I start the script in fullscreen vis I cannot escape anywhere

Much appreciated, my most used script forsure

I only have Win to test here, "esc" button works to stop the script. I will test on ATV when I get home

Loto_Bak Wrote:*edit
on song change the script does not attempt to fetch the new song.

I will test that as well, thanks for letting me know
Zeljko


- amet - 2009-11-30

Nuka1195 Wrote:amet, the changing of case is because lyricwiki most time requires it be camel case.

thats why there is an excepetion option, so when it finds AC/DC it won't change it.

this was in the original scraper, looks like it's still there in yours

Nuka1195 Wrote:just noticed using the old drive letters P:\\, so change those to special://

Thanks for the pointers, I have updated the scraper to hopefully solve the issue.

Zeljko


- sonic - 2009-11-30

Hi!

I like your script a lot but I think I have found a little "bug".. If I for example play "Helloween - Livin' ain't no crime" it can´t find any lyrics for me but if I change the song title in the ID3 tag to "Livin aint no crime" the script finds the lyrics right away Smile. So it seems to have some problems if the song name/title has " ' " characters in it.

I have tried several other songs too, and I got the same results.

Thanks for a great script!

/Sonic


- amet - 2009-11-30

sonic Wrote:Hi!

I like your script a lot but I think I have found a little "bug".. If I for example play "Helloween - Livin' ain't no crime" it can´t find any lyrics for me but if I change the song title in the ID3 tag to "Livin aint no crime" the script finds the lyrics right away Smile. So it seems to have some problems if the song name/title has " ' " characters in it.

I have tried several other songs too, and I got the same results.

Thanks for a great script!

/Sonic

Thanks for the feedback,

I would appreciate if you could post the log and upload the song somewhere so that I can test

Thanks,
Zeljko


- paco - 2009-11-30

Amet Wrote:Thanks for the feedback,

I would appreciate if you could post the log and upload the song somewhere so that I can test

Thanks,
Zeljko

Hi Zeljko,

I also ran into the same problem. Your script capitalizes the T after an apostrophe ("Ain't" becomes "Ain'T" which then fails to find any results). See example:

NOTICE: SongAin't Talkin' 'Bout Love
NOTICE: ArtistVan Halen
NOTICE: Title:[Van Halen:Ain'T Talkin' 'Bout Love]
NOTICE: http://lyricwiki.org/index.php?title=Van%20Halen%3AAin%27T%20Talkin%27%20%27Bout%20Love&action=edit

Another issue I have noticed is quotes (") within lyrics aren't scraped correctly. See following link:

http://lyricwiki.org/index.php?title=Van%20Halen%3AMean%20Street&action=edit

At the end of the song, the line:

(This is home) Somebody said "fair warning"!

Gets scraped as:

(This is home) Somebody said "fair warning"!


Keep up the great work!


- amet - 2009-12-01

paco Wrote:Another issue I have noticed is quotes (") within lyrics aren't scraped correctly. See following link:

http://lyricwiki.org/index.php?title=Van%20Halen%3AMean%20Street&action=edit

At the end of the song, the line:

(This is home) Somebody said "fair warning"!

Gets scraped as:

(This is home) Somebody said "fair warning"!


Keep up the great work!

If you look at the Page source, thats where we get the lyrics from, it shows ""fair warning"".There is an ugly hack to get rid of it in V 0.6.1, first post has download link

I am not entirely sure how to handle the " ' " issue, I'll look at it over the weekend


Thanks for letting me know.

Zeljko


- sonic - 2009-12-01

Quote:I am not entirely sure how to handle the " ' " issue, I'll look at it over the weekend

Thank you for looking at it, i hope you will find a fix for that.

/Sonic


- willers.nail - 2009-12-01

well done on this script works rather well. I'm using this on the xbox and find that some times the lyrics don't appear for the next song when skipping the track back and forward. They appear for split second then the song you just had on come up again which is obviously incorrect.


- amet - 2009-12-02

willers.nail Wrote:well done on this script works rather well. I'm using this on the xbox and find that some times the lyrics don't appear for the next song when skipping the track back and forward. They appear for split second then the song you just had on come up again which is obviously incorrect.

Thanks for the info, I'll look into it over the weekend


- alanwww1 - 2009-12-04

I just want to thank you Amet for keeping alive this plugin. Smile

This plugin is a must for me. Working really great.

Thanks again.


- amet - 2009-12-04

alanwww1 Wrote:I just want to thank you Amet for keeping alive this plugin. Smile

This plugin is a must for me. Working really great.

Thanks again.

NP Smile, credit to the original authors as well.

I have added the latest version to SVN Repo Installer, any problems please let me know.


- amet - 2009-12-05

and another new version on SVN Repo InstallerSmile

0.7.0 attempts to fetch lyrics for the next track/song and saves it to file. when track changes, the lyrics (if exist) are shown immediately.

Zeljko