Kodi Community Forum
[PATCH] New passthrough implementation for AAC/MP1/MP2/MP3 support - Testers needed! - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Kodi Application (https://forum.kodi.tv/forumdisplay.php?fid=93)
+--- Thread: [PATCH] New passthrough implementation for AAC/MP1/MP2/MP3 support - Testers needed! (/showthread.php?tid=67924)

Pages: 1 2


[PATCH] New passthrough implementation for AAC/MP1/MP2/MP3 support - Testers needed! - gnif - 2010-01-20

Hi all.

I am posting this in the hopes of getting some of you who have receivers that support AAC, MP1, MP2 or MP3 to test this patch set.

http://trac.xbmc.org/ticket/8575

* Adds spdif muxer to ffmpeg
* Modifies CDVDAudioCodecPassthrough to use ffmpeg spdif muxer
* Adds configure switches --enable-lib(dts|a52) to switch back to the old implementation
* Adds downmixing via ffmpeg to CDVDAudioCodecFFmpeg
* Adds AAC passthrough
* Adds MP1 passthrough
* Adds MP2 passthrough
* Adds MP3 passthrough


- thetalm - 2010-01-22

I recently posted a question about xbmc capability for xbmc to passtrough mp3 audio streams over hdmi without conversion in lpcm

my Denon 4308 receiver handles mp3 conversion and has a "restorer" function that improves mp3 audio. I noticed a huge difference in music quality when accessing my music library via dlna against directly from xbmc

so i'available for testing, but i'm a complete linux newby i don't know what i have to do. Have I to download a specific SVN ?

my setup is camelot on ubuntu karmic on a acer revo 3600 connected via hdmi only.


- althekiller - 2010-01-22

thetalm Wrote:i noticed a huge difference in music quality when accessing my music library via dlna against directly from xbmc

lol!


- gnif - 2010-01-29

The changes are now in svn, just grab the latest revision if you want to test. It would be great if those with MP* and AAC support could provide me feedback on how well it does/doesn't work.


- uncertainty - 2010-02-05

By the way does this mean that realtime AC3 encoding of AAC files is in the works?

thanks


- gnif - 2010-02-05

Yes, its on its way Big Grin


- WiSo - 2010-02-05

What about the low volume for down mixing is there also something "in the works"? Wink


- uncertainty - 2010-02-05

gnif Wrote:Yes, its on its way Big Grin

Great to hear.......thanks


- dodvan - 2010-02-09

Reading http://www.xbmc.org/trac/attachment/ticket/8726/ac3.diff I think I found a small bug, at file xbmc/cores/dvdplayer/DVDCodecs/Audio/DVDAudioCodecPassthroughFFmpeg.cpp, line #56, it should be "memset(m_OutputBuffer, 0, ..." instead of "memset(m_DecodeBuffer, 0, ...".

Is this the proper place to report things like this one? Please excuse me if not (I'm a newbie...) Regards.


- The doctor - 2010-02-09

I use the Denon AVR-1909 with MP3/WMA/AAC restorer. XBMC running via Apple TV and HDMI.

Will add to feedback.

Regards


- uncertainty - 2010-02-10

BTW Gnif I'm following Ticket #8726 and looks awesome. Can't wait to try it out soon.....

Good work..


- Goga777 - 2010-11-20

I have tested video files with mp2 aac ac3 tracks on Dharma Rc1 and passthrough - work fine. But passthrough doesn't work with mp3 shoutcast streams. Does it feature of paplayer ?


- cowunder - 2010-11-24

Goga777 Wrote:I have tested video files with mp2 aac ac3 tracks on Dharma Rc1 and passthrough - work fine. But passthrough doesn't work with mp3 shoutcast streams. Does it feature of paplayer ?

u can decode aac with ur amplifier without converting to ac3? i mean ur decoder says it's aac?


- Goga777 - 2010-11-27

I didn't find in specification for my Digital Home Cinema System Samsung HT-TKX500 aac decoding capability , that's why for me it's surprising - how it was possible. My Samsung doesn't have indicator for stream name.


- alexrose1uk - 2010-11-27

Heh, I wondered where this feature actually went as I was using AAC passthrough in the Dharma Beta 1, and then the option for MP1/2/3/AAC passthrough dissapeared from the options in B2 and onwards.
Just noticed the ticket states the feature is due in 10.5, so I'm guessing they're saving it for the SVN/releases after Dharma official, perhaps along with Gnif's new audio engine Smile