+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Kodi Application (https://forum.kodi.tv/forumdisplay.php?fid=93)
+---- Forum: JSON-RPC (https://forum.kodi.tv/forumdisplay.php?fid=174)
+---- Thread: JSON-RPC (JSON Remote Procedure Call) interface protocol in development for XBMC (/showthread.php?tid=68263)
Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
- Montellese - 2010-10-18
topfs2 Wrote:Hmm, seems like introspect is wrong. will look into it
I just checked the source code and it seems that the only valid parameters are "playlist-virtual" or "playlist-file". If none of these parameters is present it tries CPlayListPtr(). If I understand it correctly CPlayListPtr() should point to the currently active playlist but it seems like it doesn't in my case (although I was listening to a music album while issuing the call).
- topfs2 - 2010-10-18
Montellese Wrote:I just checked the source code and it seems that the only valid parameters are "playlist-virtual" or "playlist-file". If none of these parameters is present it tries CPlayListPtr(). If I understand it correctly CPlayListPtr() should point to the currently active playlist but it seems like it doesn't in my case (although I was listening to a music album while issuing the call).
CPlayListPtr means null shared ptr, i.e. no playlist.
The Playlist is not to be used for playing anymore, at some point it might be that again but needs lots of core redesign for it to work properly (in discussion).
For playing stuff use AudioPlaylist or VideoPlaylist, they should be considered extended Playlists or a special case of them, should have roughly the same features though
- Montellese - 2010-10-18
topfs2 Wrote:CPlayListPtr means null shared ptr, i.e. no playlist.Ah I should have taken a closer look.
topfs2 Wrote:The Playlist is not to be used for playing anymore, at some point it might be that again but needs lots of core redesign for it to work properly (in discussion).
For playing stuff use AudioPlaylist or VideoPlaylist, they should be considered extended Playlists or a special case of them, should have roughly the same features though
Good to know thanks. Video-/AudioPlaylist support more features apart from Playlist.Create, Playlist.Destroy and Playlist.Swap but these don't look like they would be used regularly.
I'm currently looking into the duplicate PlaybackStopped announcement in the code. If I find anything useful I'll let you know.
- topfs2 - 2010-10-19
Montellese Wrote:Ah I should have taken a closer look.Hehe, tbh a client creator really shouldn't need to even look through the code at all but its still in development so some bumps is expected
- Montellese - 2010-10-19
topfs2 Wrote:Hehe, tbh a client creator really shouldn't need to even look through the code at all but its still in development so some bumps is expected
I absolutely don't mind looking in the code. If I wouldn't have looked into the code I would have no idea about all the announcements XBMC provides.
Should I edit the JSON RPC wiki article when I find wrong or come up with missing information or is that still to early because the possibility that it will change again is pretty high?
- Montellese - 2010-10-19
EDIT: I'm an idiot. I looked at the trunk source instead of the dharma branch. Well seems like I'll have to hunt down the duplicate PlaybackStopped again. Sorry for the inconvenience.
But I noticed that it doesn't happen all the time. Normally I get a PlaybackResumed (see below) followed by a PlaybackStopped but occasionally I get no PlaybackResumed but two PlaybackStopped.
I hunted the dispensible PlaybackResumed announcement down in the source and found this in PAPlayer.cpp on line 279:
Code:
bool PAPlayer::CloseFileInternal(bool bAudioDevice /*= true*/)
{
if (IsPaused())
Pause(); <-- This is where the PlaybackResumed is announced
m_bStopPlaying = true;
m_bStop = true;
m_visBufferLength = 0;
StopThread(); <-- This is where the PlaybackStopped is announced
...So what I tried is to move the line "m_bStopPlaying = true" above the pause-check and add a condition for "if(!m_bStopPlaying)" at line 443 right before the PlaybackResumed announcement is initiated.
That seems to work fine but I don't know if it could produce any weird sideeffects. I checked all usages of m_bStopPlaying and didn't see anything "dangerous" but maybe I missed something.
Should I create a patch for this or is there a better way to do it?
- slash - 2010-10-19
topfs2 Wrote:GetSources probably should give tem, via parameter to aggregate autoadded sources (such as optical and dvd) probably.
Files.Download will just give you direction on how to download based on your current transport. Http will just give you a URL you can access, TCP at some point might give you a port and so on.
ScanForContent won't take a parameter of path since its hard / impossible to make proper (other thread regarding this matter).
Refresh might be interesting, not sure how to code it up but definatly a nice thing if possible. Seems perfect to be able to refresh scanned items via the web interface.
As for library manipulations, I'd say its appropriate to do them via httpapi for the time being. It is planned to be doable via jsonrpc at some point. Probably needs the security addition (mostly to display them in gui, a dialog that asks if client foo can have these permissions etc.).
Please add tickets and cc me so we don't forget them.
Thanks,
Added tickets in track
http://trac.xbmc.org/ticket/10546
http://trac.xbmc.org/ticket/10547
http://trac.xbmc.org/ticket/10548
Let me know if I can help in anyway, I'm slow at C++ coding but I don't mind trying.
/
- Montellese - 2010-10-19
I did some more digging into the code concerning the fact that the "playing" is always set to "true" when calling Audio-/VideoPlayer.GetTime/.GetTimeMS/.State and found this in the AVPlayerOperations.cpp at multiple occasions:
Code:
result["playing"] = g_application.IsPlaying();
result["paused"] = g_application.IsPaused();Is this the inteded use in JSON RPC? If so I don't understand why because whenever IPlayer.IsPlaying() returns false it also means that the player is not active at all and therefore can't even be accessed through the JSON RPC API because it only allows you to access the currently active player.
Why are there two items "playing" and "paused" anyway? Doesn't the value of one automatically imply the value of the other?
- topfs2 - 2010-10-19
Montellese Wrote:I did some more digging into the code concerning the fact that the "playing" is always set to "true" when calling Audio-/VideoPlayer.GetTime/.GetTimeMS/.State and found this in the AVPlayerOperations.cpp at multiple occasions:
I then did some searching on the IPlayer.IsPlaying() and found out that it doesn't actually tell you whether a song/video is playing or not but rather that the player itself (DVDPlayer, PAPlayer, ExternalPlayer) is active (although the current song/video might be paused).Code:result["playing"] = g_application.IsPlaying();
result["paused"] = g_application.IsPaused();
Is this the inteded use in JSON RPC? If so I don't understand why because whenever IPlayer.IsPlaying() returns false it also means that the player is not active at all and therefore can't even be accessed through the JSON RPC API because it only allows you to access the currently active player.
Why are there two items "playing" and "paused" anyway? Doesn't the value of one automatically imply the value of the other?
Hmm, I really dislike our interfaces at times. Might be that should be result["playing"] = g_application.IsPlaying() && !g_application.IsPaused();
- Zarquon - 2010-10-20
I'm making the following JSON call and was wondering what fields were available for return? Specifically I was hoping I could retrieve the air date and run time.
Code:
{"jsonrpc": "2.0", "method": "VideoLibrary.GetRecentlyAddedEpisodes", "params" : { "start" : 0 , "end" : 15 , "fields": [ "director", "year", "rating","showtitle", "season", "episode","plot" ] }, "id" : 1 }Any help would be appreciated.
- Tolriq - 2010-10-20
All the fields can be found here :
http://trac.xbmc.org/browser/trunk/xbmc/lib/libjsonrpc/FileItemHandler.cpp
just check the FillVideoDetails or FillMusicDetails
You are looking for :
firstaired and runtime
Developers, its time to thing of users !! - vaton4 - 2010-10-20
Hi to all. I am not sure this is the right thread for my laments, but seems it is populated by the people who can help.
I am relatively new XBMC user, but a quite experienced computer professional (in the battlefield since 1968), so I do not need help frequently. This time I need.
Recently I tried the new (Dharma) web control interface and I must say I am a bit confused. I can connect without problems ... but if XBMC is not allready playing, it's allmost all I can do.
At the bottom I see just big gray rectangle; at the top there are REMOTE, MOVIES, TV SHOWS, MUSIC, and SETTINGS fields, but they seem to be dead - If I point to some field, its background color changes, but clicking does nothing except the 'ajax-loader.gif' icon shows and starts to rotate. No directories, no files, no controls, no messages, no help ...
If XBMC is allready playing (thanks to heavens the infra remote and wireless keyboard work for me), I can see album and track info, timing info, next track info and basic control butons. Buttons seem to work as expected, but no playlist, no playlist edition, no volume control. And again, no directories, no files to build playlist. Beyond this, track name sometimes changes properly, somtimes does not (reloading page helps here).
In the Wiki there is just a very, very brief description of the obsolete interface and list of JSONRPM functions for developers. No description, no user help.
Would finally developers of this nightmare make this part of XBMC more user friendly, please ??
- topfs2 - 2010-10-20
vaton4 this is development thread about jsonrpc, not webinterface. Please ask your questions in the correct forum. And before you post again, please read through the docs about how to submit a proper bugreport.
- Zarquon - 2010-10-20
Tolriq Wrote:All the fields can be found here :Thank you. This is exactly what I was looking for and this is great for reference. Unfortunately "runtime" do not seem to be supported in that return value for VideoLibrary.GetRecentlyAddedEpisodes but "duration" is.
http://trac.xbmc.org/browser/trunk/xbmc/lib/libjsonrpc/FileItemHandler.cpp
just check the FillVideoDetails or FillMusicDetails
You are looking for :
firstaired and runtime
The only problem seems to be that duration isn't always populated. Any ideas?
- Montellese - 2010-10-20
Did anyone else notice a strange behaviour of the "rating" field when using AudioLibrary.GetSongs()? I always get
Code:
"rating": 48Code:
if (item->IsAlbum() && item->HasProperty(field))
{
if (field == "album_rating")
object[field] = item->GetPropertyInt(field);
else
object[field] = item->GetProperty(field);
}Or is there a reason that the value is 48 for every song? I check the "song" table in the MyMusic7.db database file and saw that most of the songs have a rating of 0.