grywnn Wrote:I can open tickets for these two things if needed.

Montellese Wrote:Well it doesn't work in the sense that it will add all items from album 1 AND from artist 1. It will only add items from album 1 because the second "item" overwrites the first one.


The "item" parameter of Playlist.Add does only allow to contain a single propertie i.e. EITHER "artistid" OR "albumid" OR "songid" OR "movieid" OR ...

I might write a more detailed description about the "union type" feature of JSON schema which we use in our JSONRPC.Introspect. In short if you see something like this in introspect:

PHP Code:

"type": [
  { "type": "object", "properties": { "artistid": { "$ref": "Library.Id", "required": true } } },
  { "type": "object", "properties": { "albumid": { "$ref": "Library.Id", "required": true } } },
  ...
] 


it means that you can either provide an object which contains a property "artistid" OR you can provide an object which contains a property "albumid" OR ... BUT you MUST NOT provide an object which contains more than one of those properties. The fact that the "type" is defined as an array of possible JSON schemas means that those JSON schemas exclude each other and only one of them can be valid for a specific JSON object.

jasonvp Wrote:Hi guys,

Player.GetProperties/Player.Property.Name which replaced Player.State has no "playing" or "paused" option. Are these going to be added?

Montellese Wrote:We thought that having "playing" and "paused" was kindof overkill and then we decided that we use the "speed" property to determine whether a player is currently playing (speed != 0) or is paused (speed = 0).

mzanetti Wrote:Calling this crashes xbmc:

Code:

"{ "id" : 22, "jsonrpc" : "2.0", "method" : "Playlist.Clear", "params" : { "playlistid" : 2 } }"
"{ "id" : 23, "jsonrpc" : "2.0", "method" : "Playlist.Add", "params" : { "item" : { "file" : "/home/user/Pictures/picture.jpg" }, "playlistid" : 2 } }"
"{ "id" : 24, "jsonrpc" : "2.0", "method" : "Player.Open", "params" : { "item" : { "playlistid" : 2, "position" : 0 } } }"
"{ "id" : 25, "jsonrpc" : "2.0", "method" : "Playlist.Clear", "params" : { "playlistid" : 2 } }"

This can be worked around by calling Player.Stop before the Playlist.Clear but still shouldn't happen I guess.

jasonvp Wrote:Hi guys,

What am I doing wrong?

Code:

{"jsonrpc":"2.0","id":1,"method":"Player.SetSpeed","params":{"playerid":0,"speed":2}}

Code:

{"error":{"code":-32602,"data":{"method":"Player.SetSpeed","stack":{"message":"Received value does not match any of the union type definitions","name":"speed","type":["string","integer"]}},"message":"Invalid params."},"id":1,"jsonrpc":"2.0"}

Montellese Wrote:Broken here as well. Probably a bug in my union type implementation. Please create a bug ticket as well. Thanks.

jasonvp Wrote:Just to add, "increment" and "decrement" work but I'm just wondering what the speed values i.e. 2, 4, 8, 16 are suppose to represent?

e.g. I would have thought that "speed":2 would mean twice as fast as "speed":1 i.e. a song that is 4 minutes long would take 2 minutes to fast forward to the end. It currently only takes 4 seconds at "speed":2 using "increment" sent once. Seems to fast to me.

Quote:Montellese;896673]Yeah it was a bug in my union type implementation. I fixed it and Player.SetSpeed should now also work with the numerical values (btw I also added -32 and 32).

Quote:You are right, setting the playback speed to 2 on a playing song plays it way faster than 2 times the original speed. But when I use the Fast Forward functionality from the music player OSD in XBMC itself that's the way it works there as well. So jsonrpc simply works the way it works when using the GUI functionality. But I agree that it's not very intuitive.

jasonvp Wrote:I did some more investigating and found that in the Video Player Fast Forward x2, x4 etc. work as you expect but Rewind speed is faster than expected. The Music Player is way out for both Fast Forward and Rewind...weird. I'll submit a Bug Ticket.

jasonvp Wrote:I also noticed that "fields" for "Playlist.GetItems" is not working with Windows GIT:20110924-0074b5e. It was working fine with GIT:20110919-8af9b11.
Result

Code:

{"code":-32602,"data":{"message":"Too many parameters","method":"Playlist.GetItems","stack":{"name":"playlistid","type":"integer"}},"message":"Invalid params."},"id":1,"jsonrpc":"2.0"}

Montellese Wrote:Probably because all "fields" parameters have been renamed to "properties" on 20th September (http://forum.xbmc.org/showpost.php?p=893214&postcount=1225)