XBMC Community Forum
[RELEASE] Logo Downloader Script - Printable Version

+- XBMC Community Forum (http://forum.xbmc.org)
+-- Forum: Help and Support (/forumdisplay.php?fid=33)
+--- Forum: Add-ons Help and Support (/forumdisplay.php?fid=27)
+---- Forum: Program Add-ons (/forumdisplay.php?fid=151)
+---- Thread: [RELEASE] Logo Downloader Script (/showthread.php?tid=74912)



- thezoggy - 2010-10-01 01:47

So I added a new show, "Law & Order LA" so I ran your script to pick up the new logo:
Quote: <onclick>XBMC.RunScript(script.logo-downloader,mode=bulk,clearart=False,logo=True,showthumb=False)</onclick>
(showthumb = one word.. this forum splits it for some reason if there is a , before it.)

but it downloaded clearart, thumbs, and no logos for the whole collection. wtf?


- ppic - 2010-10-01 02:17

it can't with this line... debug log please


- thezoggy - 2010-10-01 08:09

ppic Wrote:it can't with this line... debug log please

When I'm home from work I'll provide some debug info. It worked fine the first day I ran this command but now after a week it appears not to work like it should.


- ppic - 2010-10-01 13:43

strange, i wait your log to see what's append.


- thezoggy - 2010-10-01 17:13

ppic Wrote:strange, i wait your log to see what's append.

here you go: http://pastebin.com/Z1vZpsgr

I deleted my log and created a fresh one. Started up XBMC waited for it to do its startup thing then ran the script and closed out XBMC. I removed the startup scrap debug block (figured you don't need to see my music/movies).

As you can see, the arguments are set and picked up:

09:59:26 T:3968 M:3021598720 DEBUG: CApplication::ExecuteXBMCAction : Translating XBMC.RunScript(script.logo-downloader,mode=bulk,clearart=False,logo=True,showthumb=False)

09:59:26 T:1820 M:3018498048 NOTICE: ['script.logo-downloader', 'mode=bulk', 'clearart=False', 'logo=True', 'showthumb=False']
09:59:26 T:1820 M:3018498048 NOTICE: arg 0: script.logo-downloader
09:59:26 T:1820 M:3018498048 NOTICE: arg 1: mode=bulk
09:59:26 T:1820 M:3018498048 NOTICE: arg 2: clearart=False
09:59:26 T:1820 M:3018498048 NOTICE: arg 3: logo=True
09:59:26 T:1820 M:3018498048 NOTICE: arg 4: showthumb=False
09:59:26 T:1820 M:3018498048 NOTICE: no arg5

But it clearly did not follow the arguments,
10:01:30 T:1820 M:3017576448 NOTICE: total tvshow = 64
10:01:30 T:1820 M:3017576448 NOTICE: logo found = 54
10:01:30 T:1820 M:3017576448 NOTICE: logo download = 0
10:01:30 T:1820 M:3017576448 NOTICE: thumb found = 1
10:01:30 T:1820 M:3017576448 NOTICE: thumb download = 41
10:01:30 T:1820 M:3017576448 NOTICE: clearart found = 0
10:01:30 T:1820 M:3017576448 NOTICE: clearart download = 39

let me know if you need anything else

--z


- thezoggy - 2010-10-01 17:17

Since i'm doing a bulk search, does it matter if i have arg5 not set? (showname)

btw I noticed that you have one line still in french listed in default.py,
Quote: print "### ERROR impossible d'ouvrir la page %s" % url

"error- not able to open a page"

Also to note, when your script is running.. the cancel button doesn't work on the popup.


- ppic - 2010-10-01 18:21

yes this 2 point are normal.

i'll check that later.


- ppic - 2010-10-01 21:23

ok, i've found the problem !

i was gathering the information in a wrong way, no it's good, i'll upload soon.

here is the working code :

Code:
for item in sys.argv:
            match = re.search("mode=(.*)" , item)
            if match: self.mode = match.group(1)            
            match = re.search("clearart=(.*)" , item)
            if match:
                if match.group(1): self.clearart = match.group(1)
                else: pass
            match = re.search("logo=(.*)" , item)
            if match:
                if match.group(1): self.logo = match.group(1)
                else: pass
            match = re.search("showthumb=(.*)" , item)
            if match:
                if match.group(1): self.show_thumb = match.group(1)
                else: pass
            match = re.search("showname=" , item)
            if match: self.show_name = item.replace( "showname=" , "" )
            else: pass



- ppic - 2010-10-01 23:24

well, not enought Sad

Code:
['script.logo-downloader', 'mode=bulk', 'clearart=False', 'logo=True', 'showthumb=False']

strange thing is that catch each True or False states in variable, But "False" return a True Boolean, i was assuming that Python catch the "False" string as False boolean, seems not ...

i've worked on it it's good now, i also add the ability to cancel the script Wink


- thezoggy - 2010-10-02 05:01

Ok neat, I'll wait your next release to test out. Nerd