+- XBMC Community Forum (http://forum.xbmc.org)
+-- Forum: Help and Support (/forumdisplay.php?fid=33)
+--- Forum: Skin Help and Support (/forumdisplay.php?fid=67)
+---- Forum: Artwork packs (/forumdisplay.php?fid=71)
+---- Thread: fanart.tv - Request and share ClearLOGO, ClearART and more Fan Artwork / Thumbs (/showthread.php?tid=87577)
- NeoRame - 2011-04-20 10:24
i submitted these stuff BEFOR he denied your stuff but ok!
and hey, yes i create these stuff myself:
Nicks Logo = Georgia Font with stroke and drop shadow 100% (4-6 times)
TeenWolf = Arial Black (Italic) + Two colors and a dropshadow
World War = "Stencilia-A" Font + finished with a disorted brush+ 2 colors and a dropshadow
i take the time to search the right font or create this shit myself with a vector layer
- BlueNZ - 2011-04-20 11:34
All good bro, just giving you a hard time
By the way, thanks for the help with filling some requests today we're slowly whittling down the list. Can you have a go at Keeping Up Appearances? It'd be good to get it off the list and it's giving me a massive headache.
- Kode - 2011-04-20 16:04
Does anyone have any objections with me changing the naming scheme?
When the files were in a directory it made sense for there to be a standard naming scheme (though it wasn't properly thought out in any case) of seriesname-thetvdbid.png, seriesname-thetvdbid-2.png, seriesname-thetvdbid-3.png etc, however, this has caused some issues.
Specifically I believe when deleting items such as -2.png and -3.png needing to be renamed to -2.png, there have been cases where it has caused wrong files to be renamed and some lost, something that is easily preventable with my suggestion below.
As we have an API needing to have a consistant naming scheme is irrelevant, especially as the logo is going to be renamed after it is downloaded anyway.
Currently when a logo is uploaded pending approval it is named uniqueid.png (something like 4d03f90e88937.png) then when it is approved it is renamed.
What I would like to do is on the initial upload name it seriesname-uniquid.png so bones-4d03f90e88937.png, then keep this name when it is approved, this would mean that we wouldn't need to rename files when others are deleted etc. and would make the whole system more robust.
*edit*
This wouldn't affect current images, they would keep their current names, it would just be new images.
- ppic - 2011-04-20 16:16
hum, i'm asking myself if this won't break a little the script.
i rememenber that the script is always taking the first image (i.e. , taking out the '-3' from the name.
keep me update when you've got something to test.
- Kode - 2011-04-20 16:30
ppic Wrote:hum, i'm asking myself if this won't break a little the script.
i rememenber that the script is always taking the first image (i.e. , taking out the '-3' from the name.
keep me update when you've got something to test.
Well currently the API returns a list, could you not just use the first result? i.e.
http://fanart.tv/api/fanart.php?id=75682 returns:
<clearlogos>
<clearlogo url="http://fanart.tv/fanart/73739/clearlogo/Lost-73739.png"/>
<clearlogo url="http://fanart.tv/fanart/73739/clearlogo/Lost-73739-2.png"/>
</clearlogos>
- ppic - 2011-04-20 16:38
hum, i don't remember what the code done, maybe you're right, i'm taking the first.
- Kode - 2011-04-20 16:39
ppic Wrote:hum, i don't remember what the code done, maybe you're right, i'm taking the first.
Well before the API you would have had to take out the -3 etc, I'm not sure what changes you made to the script since switching to the API though?
- Kode - 2011-04-20 16:50
Just had a look at your source, I'm assuming it's this bit:
Code:
def search_logo( self ):
match = re.findall("""<clearlogo url="(.*?)"/>""" , self.lockstock_xml)
if match:
if self.mode == "solo" : self.image_list = match
if self.mode == "bulk" : self.image_url = match[0]
return True
else:
print "### No logo found !"
if self.mode == "solo": xbmcgui.Dialog().ok("Not Found" , "No logo found!" )
self.image_list = False
return FalseIf I'm reading that right, it says if you are in solo mode (I assume thats when you are looking for a specific show and using the dialog to choose which logo you want) set image_list to all the results, but if you are in bulk mode (so finding images automatically, not asking for user input) use the first match, so any changes to the naming scheme shouldn't affect the script at all
- ppic - 2011-04-20 19:01
yeap right !
- BlueNZ - 2011-04-21 00:10
From the perspective of a contributor I like it as your submission would have a trackable ID from the moment uploaded so you can keep a record when submitted since there's no access to our submitted/approved stuff at present. From a user perspective the current numbering system allows people to determine the latest submissions (by highest number) when selecting through the scraper, but the first offered should be the most popular/downloaded/voted anyways.