+- XBMC Community Forum (http://forum.xbmc.org)
+-- Forum: Development (/forumdisplay.php?fid=32)
+--- Forum: Python Add-on Development (/forumdisplay.php?fid=26)
+--- Thread: Icefilms (Icefilms.info) Addon Development Thread (/showthread.php?tid=90315)
- CrashX - 2011-03-17 20:29
@anarchintosh
Please note that they are major changes in the xbmc trunk which is causing issues with your plugin + patch (westcoast) ... I am getting script errors on xbmc svn builds vs xbmc dharma builds ... Will investigate more tonight ...
That is good hear that caching is fixed ...
- Eldorado - 2011-03-17 21:53
anarchintosh Wrote:when patch enters nightly builds (if it is accepted by xbmc team) i'll add support for moving that file to library. so you can save the video files you stream.
but as i said it needs testing!
this patch is built upon that patch that displays buffering progress, in fact it improves the old one a lot.
I'm a developer by day, I know all about the testing
What I was getting at was if you purely want to stream there would need to be a process that cleans up these files when you are done, which I would figure should be left up to the addon to handle.. so possibly a new option?
eg. clean up the files when you exit the addon - or even finished playing the stream; or move to a specified folder for one of each video category (TV Shows, Movies, Stand-Up, Other, etc)
- CrashX - 2011-03-17 22:52
Eldorado Wrote:I'm a developer by day, I know all about the testing
What I was getting at was if you purely want to stream there would need to be a process that cleans up these files when you are done, which I would figure should be left up to the addon to handle.. so possibly a new option?
eg. clean up the files when you exit the addon - or even finished playing the stream; or move to a specified folder for one of each video category (TV Shows, Movies, Stand-Up, Other, etc)
XBMC creates them and should be responsible for deleting it not addon.
- anarchintosh - 2011-03-18 00:14
CrashX Wrote:XBMC creates them and should be responsible for deleting it not addon.
i think eldorado is referring to a player option that sets whether the file is deleted after finish.
i don't think this would be the best thing.
what would be better is if xbmc clears the file cache (deletes the old video file) upon opening a new stream.
the thing is, i need to post a trac ticket and get the opinions of actual xbmc developers.
also, testers, here is a windows binary:
http://www.megaupload.com/?d=V13F2HOF
- Eldorado - 2011-03-18 02:56
CrashX Wrote:XBMC creates them and should be responsible for deleting it not addon.
But such a thing does need to be configurable via the addon, and even more at an individual stream level - you may want to keep one movie, but not another
If XBMC handles the deletion, then would need the ability to accept a value from the addon whether to delete or not..and a proper timing of when to do it - immediately when finished playing, opening a new stream, exiting the app.. Or am I thinking about this wrong?
Does the current patch simply retain all streams, even partial downloads? Just something you need to watch so that you don't accidentally fill up your hard drive.. or ATV
- kalel90 - 2011-03-18 04:06
Eldorado Wrote:But such a thing does need to be configurable via the addon, and even more at an individual stream level - you may want to keep one movie, but not another
If XBMC handles the deletion, then would need the ability to accept a value from the addon whether to delete or not..and a proper timing of when to do it - immediately when finished playing, opening a new stream, exiting the app.. Or am I thinking about this wrong?
Does the current patch simply retain all streams, even partial downloads? Just something you need to watch so that you don't accidentally fill up your hard drive.. or ATV
Im pretty sure it only keeps finished streams/downloads.
- anarchintosh - 2011-03-18 12:00
kalel90 Wrote:Im pretty sure it only keeps finished streams/downloads.yes it only keeps finished streams.
@eldorado
i don't think you read my previous post.
rather than introduce a new 'delete' (whether its timed or not) parameter to the xbmc and xbmcplugin python modules, which is a bit annoying for addon devs to think about....
would it not be better to have xbmc delete the old cached/downloaded video file upon opening (or even finishing) a new stream?
that way there is plenty of time to move the video to a safe place if user wants to.
- Eldorado - 2011-03-18 19:36
anarchintosh Wrote:yes it only keeps finished streams.
@eldorado
i don't think you read my previous post.
rather than introduce a new 'delete' (whether its timed or not) parameter to the xbmc and xbmcplugin python modules, which is a bit annoying for addon devs to think about....
would it not be better to have xbmc delete the old cached/downloaded video file upon opening (or even finishing) a new stream?
that way there is plenty of time to move the video to a safe place if user wants to.
I guess I'm just hung up on the timing of the delete and how it impacts the user.. and what is the best option
Option 1 - delete previous when a new stream is opened
What if the user doesn't start a new stream and just exists the addon? Just let it stay until some point in the future when the user does return?
Option 2 - delete immediately when finished watching
Will you have enough time to copy it to a safe place?
Should we care about the possibility of re-watching the same stream immediately after, and not force the user to re-download?
Don't mind me, I just like to throw out ideas left and right
- kalel90 - 2011-03-18 23:58
Eldorado Wrote:I guess I'm just hung up on the timing of the delete and how it impacts the user.. and what is the best option
Option 1 - delete previous when a new stream is opened
What if the user doesn't start a new stream and just exists the addon? Just let it stay until some point in the future when the user does return?
Option 2 - delete immediately when finished watching
Will you have enough time to copy it to a safe place?
Should we care about the possibility of re-watching the same stream immediately after, and not force the user to re-download?
Don't mind me, I just like to throw out ideas left and right
The best way to do what your talking about is to have xbmc delete the old files after either 1. a certain amount of them have accumulated 2. all of them combined have reached a certain size and therefore the oldest should be deleted first or 3. delete them auto after a certain amount of time starting with the oldest first. Now im not sure how you would implement it but i know it can and has been done before by other streaming related software.
- ajnicho - 2011-03-19 00:10
What happens for partially watched streams? If I came back to watch the remainder of the film the following day would it start over? And if I was to skip forward to say 30 mins in to the film, would the cached file start from there?
Also, I would have a box pop up and the end of the movie or when backing out of the movie to ask the user if they would prefer to store the file or delete it, you could also have a check box to confirm action for all future movies
Just my two cents