XBMC Community Forum
Icefilms (Icefilms.info) Addon Development Thread - Printable Version

+- XBMC Community Forum (http://forum.xbmc.org)
+-- Forum: Development (/forumdisplay.php?fid=32)
+--- Forum: Python Add-on Development (/forumdisplay.php?fid=26)
+--- Thread: Icefilms (Icefilms.info) Addon Development Thread (/showthread.php?tid=90315)



- jesterthejedi - 2011-09-27 08:32

PLAY-LISTS!!!

I love this plug-in, but always seeing the most Popular Category films of such poor taste and writing/acting quality really bugs me. I want a listing for Cult Classics, Award Winners, Independent Films, Dark Comedies, 80's Teen Comedies, Gay & Lesbian, ETC. I want to see this plug-in have the ability to find movies that my diverse palate will enjoy. I have no problem editing the files, but I need to know where to look and what to change. If you have input/ideas please share and I will do the same

Thanks Smile


- wesada - 2011-09-27 15:32

jesterthejedi Wrote:PLAY-LISTS!!!

I love this plug-in, but always seeing the most Popular Category films of such poor taste and writing/acting quality really bugs me. I want a listing for Cult Classics, Award Winners, Independent Films, Dark Comedies, 80's Teen Comedies, Gay & Lesbian, ETC. I want to see this plug-in have the ability to find movies that my diverse palate will enjoy. I have no problem editing the files, but I need to know where to look and what to change. If you have input/ideas please share and I will do the same

Thanks Smile

The lists are not stored with the plugin. They are grabbed from the existing lists on the site.


- Eldorado - 2011-09-27 16:24

jesterthejedi Wrote:PLAY-LISTS!!!

I love this plug-in, but always seeing the most Popular Category films of such poor taste and writing/acting quality really bugs me. I want a listing for Cult Classics, Award Winners, Independent Films, Dark Comedies, 80's Teen Comedies, Gay & Lesbian, ETC. I want to see this plug-in have the ability to find movies that my diverse palate will enjoy. I have no problem editing the files, but I need to know where to look and what to change. If you have input/ideas please share and I will do the same

Thanks Smile

... and to create such lists you would need the meta data, which likely doesn't exist


- BradleyJ33 - 2011-10-07 05:03

wesada Wrote:Haha, yeah bit of a pre-mature post yesterday. Was going through the code while waiting to pickup my wife. Posted the link to the needed import and the modified default.py on the release thread. Can get it from the unstable branch of my fork at bitbucket. http://code.wesada.ca/xbmc-icefilms/raw/f76437f59b8b/default.py

http://code.wesada.ca/xbmc-icefilms/raw/f76437f59b8b/icefilms_constants.py

Quick question...I see how to replace the default.py file when I ssh into my ATV2. Where does the icefilms_constants.py file go? I don't see a file with that name to replace with the new one...is this a new file that I need to just drop in via ssh, and if so, where does it go? Thanks in advance.


- wesada - 2011-10-08 17:35

BradleyJ33 Wrote:Quick question...I see how to replace the default.py file when I ssh into my ATV2. Where does the icefilms_constants.py file go? I don't see a file with that name to replace with the new one...is this a new file that I need to just drop in via ssh, and if so, where does it go? Thanks in advance.

Same spot as default.py

But I need to make updates to my version. The guys over at icefilms changed the site slightly.


- BradleyJ33 - 2011-10-09 04:15

wesada Wrote:Same spot as default.py

But I need to make updates to my version. The guys over at icefilms changed the site slightly.

Thanks for the reply. I'll look forward to trying your updated version once it's available.


- A1rw4lk3r - 2011-10-09 18:46

Posted this in the wrong forum, sorry.


Metacontainer - wthpr0 - 2011-10-11 01:29

Can anyone tell me how far along the development of the meta container is and what needs to be done ?


Fix for Invalid Characters in Filenames - spoyser - 2011-10-11 15:10

Here is a fix for fixing downloading of programs with names that contain invalid characters.

It works simply by replacing all invalid characters (\/:*?"<>|) in vidname and mediapath with nothing.

in default.py

Code:
def Get_Path(srcname,vidname):
     #get settings
     selfAddon = xbmcaddon.Addon(id='plugin.video.icefilms')
          
     #get path for download
     mypath=os.path.normpath(str(selfAddon.getSetting('download-folder')))

     [b]#remove invalid characters
     for a in ['\\', '/', ':', '*', '?', '"', '<', '>', '|']:
         vidname = vidname.replace(a, '')[/b]

     if os.path.exists(mypath):

          #if source is split into parts, attach part number to the videoname.
          if re.search('Part',srcname) is not None:
               srcname=(re.split('\|+', srcname))[-1]
               vidname=vidname+' part'+((re.split('\ +', srcname))[-1])
               #add file extension
               vidname = vidname+'.avi'
          else:
               #add file extension
               vidname = vidname+'.avi'

          initial_path=os.path.join(mypath,'Icefilms Downloaded Videos')

          #is use special directory structure set to true?
          SpecialDirs=selfAddon.getSetting('use-special-structure')

          if SpecialDirs == 'true':
               mediapath=os.path.normpath(handle_file('mediapath','open'))

               [b]#remove invalid characters
               for a in [':', '*', '?', '"', '<', '>', '|']:
                   mediapath = mediapath.replace(a, '')[/b]

               mediapath=os.path.join(initial_path,mediapath)              
              
               if not os.path.exists(mediapath):
                    os.makedirs(mediapath)
               finalpath=os.path.join(mediapath,vidname)
               return finalpath
    
          elif SpecialDirs == 'false':
               mypath=os.path.join(initial_path,vidname)
               return mypath
     else:
          return 'path not set'


Is it possible for someone to add this to the main code?


- Eldorado - 2011-10-11 15:54

wthpr0 Wrote:Can anyone tell me how far along the development of the meta container is and what needs to be done ?

Check out the master branch on github, it is very close

While I was working on the metahandlers module I referenced back to this branch and noticed a few problems, I've made some fixes and will push them in soon

I'm pretty sure the majority of it works, though tv show metadata could use some attention/testing.. and the rest of the addon in general could use some very thorough testing

One of the main items I found which I'm not sure was considered is how to upgrade current users to the new version and convert their existing database, as it has changed quite a bit... or possibly the idea was going to be create a new metadata pack to download and delete the old DB, likely the easiest route to take

Then the merge back with the 'stable' branch might be a bit messy as well..

It would be nice to finally get this version pushed out and eliminate the need for all the different versions some are creating on their own.. my view is any effort spent on Icefilms should be put towards the official repo version rather than confusing users with so many different versions