+- XBMC Community Forum (http://forum.xbmc.org)
+-- Forum: Development (/forumdisplay.php?fid=32)
+--- Forum: Python Add-on Development (/forumdisplay.php?fid=26)
+--- Thread: Icefilms (Icefilms.info) Addon Development Thread (/showthread.php?tid=90315)
- Eldorado - 2011-11-15 22:41
edwinchester Wrote:Eldorado,
SSH'd into my Apple TV2 and implemented exactly the changes you posted, unfortunately to no avail.
Now ALL my Icefilms categories now get the script error message (didn't before), only Music, and whats worse my other addons, SportsDevil, FastPassTV are not working, script errors with those (all working before the change), the only add on that appears to be working is Vevo
debug log: http://pastebin.com/UdAnGuKh
sys log: http://pastebin.com/j20HhDcx
crash reporter http://pastebin.com/P567WYUN
Default py settings: http://pastebin.com/Rp6PnCyP
Not changed anything in Windows yet, and not able to play anything with Icefilms either.
Something went wrong somewhere.. the errors are right after the line that you edited
Just hold on until I put a copy up that you can download
- edwinchester - 2011-11-16 10:53
Eldorado
The first part of my post explained I did make an error on the first attempt:
I went back to check the change I made in default.py and I noticed I missed a space between " and width and thats what caused all the problems shown below, after correcting this it now it appears the music category is loading the video but not playing everytime(no script error), working icon bottom right hand corner appears briefly but doesn't play, tried many different ones, some take 2 or 3 attempts before they load,
also completed the change in Windows 7 ok, first video loaded and played correctly, not got time to test any more at the moment
Edit: and to be honest tried first 2 music videos today and both have loaded and played ok, so for now looks like problem is resolved, thanks very much for your help
- spoyser - 2011-11-16 12:02
Eldorado Wrote:I found I only needed to make the change in the xgoogle/search.py ... and things have changed somewhat in the master
Also this returns what appears to be many more results than the Icefilms site, eg. do a search on both for 'Harry Potter'.. the results are in a good way as it's also picking up the keywords in the description.. but I am noticing some duplicates
Anyone have some code for the download & watch?
The first change (the len < 180 bit) is necessary to provide any episode lists that match the search criteria.
Try the fix and then search for the Simpsons (say), you will notice that the first entry is the epsiode list (in much the same way the search does on the Icefilms site)
From looking at the code the search is done entirely different in the add-in to the IceFilms site, the site peforms a custom google search such as this:
Code:
http://www.google.com/custom?hl=en&client=google-coop&cof=FORID:9%3BAH:&cx=010591583107216882486:bafpv02vxuq&q=simpsonswhereas the add-in does a google search on:
Code:
site:http://www.icefilms.info/ip simpsonsHence why the results are slightly different.
The duplicates I believe are due to the rather crude way in which the add-in simply makes 3 requests and adds all the results to the list (wouldn't be too difficult to add a check at this point).
Not sure you will be able to implement a Download & Watch in Windows due to file locking
- Eldorado - 2011-11-16 18:05
I caught that shortly after I posted
Got master updated with the search working quite nice and with meta data!
If I'm understanding the code right, I think they call DoSearch 3 times to give/get multiple pages of results.. I'm thinking I will just leave it alone
I'm almost there.. meta data seems to be solid on all categories, watched status update working.. just want to finish up the refresh info stuff then I'll push my updates in for others to play with
From now on Icefilms 1.1.0 will need my metahandler library and t0mm0's common library
- Eldorado - 2011-11-16 18:07
edwinchester Wrote:Eldorado
The first part of my post explained I did make an error on the first attempt:
I went back to check the change I made in default.py and I noticed I missed a space between " and width and thats what caused all the problems shown below, after correcting this it now it appears the music category is loading the video but not playing everytime(no script error), working icon bottom right hand corner appears briefly but doesn't play, tried many different ones, some take 2 or 3 attempts before they load,
also completed the change in Windows 7 ok, first video loaded and played correctly, not got time to test any more at the moment
Edit: and to be honest tried first 2 music videos today and both have loaded and played ok, so for now looks like problem is resolved, thanks very much for your help
Good stuff, the videos that are not play are usually due to the source either missing or megaupload just acting up
Check your logs and see what msgs you get, typically you will see something like along the lines of not getting any data from the stream which means megaupload just did not start sending and xbmc stopped waiting
With this change in, can you give it some good testing.. test all tvshows, movies, music etc.. the change will affect everything
- spoyser - 2011-11-16 19:23
Eldorado Wrote:If I'm understanding the code right, I think they call DoSearch 3 times to give/get multiple pages of results..
That's how I read it too, the problem is if there are only say 10 items in total then each call will return the same 10 items (no big deal IMO)
Eldorado Wrote:I'm thinking I will just leave it alone
My thoughts exactly
- Eldorado - 2011-11-16 20:48
Ok I've pushed out updates
Master
For the time being I'm keeping my dev of the 'master' Icefilms branch or v1.1.0 in my repo, once it is complete I will push it back to Anarchintosh's official repo
Master repo - https://github.com/Eldorados/icefilms-addon
You will now need two libraries:
Metahandlers - http://forum.xbmc.org/showthread.php?tid=109725
t0mm0's common - http://forum.xbmc.org/showthread.php?tid=105707
What I've done:
- converted over to use metahandlers library, all movies, tvshows, episodes, music, standup now has detailed meta data
- cleaned up some messy code, there are still lots left to do in this area
- added a movie & tvshow fanart setting
- also rearranged some of the settings a bit, probably should do more
- updated search as per spoyser
- single item meta refresh for movie or tvshow - note the refresh info option currently shows for everything
- probably more.. can't remember it all now
TESTERS!!
I need testers on many different platforms! Try anything and everything!
Also, you will likely ALWAYS get prompted to download the old meta pack, just select 'Remind Me Later' for now, there is a bunch of work that needs to be done in this area
Ensure Meta Data is enabled, fanart 'backdrops' work
Meta cache DB is stored in - ..\userdata\addon_data\script.module.metahandler\meta_cache
There's many items on the to-do
One main issue I'm having is with the context menu's, mainly they need to be cleaned up and corrected to only show certain items when in certain categories
I'm getting a TypeError when I use the option replaceItems=True
Look at line 2079 and you will see I have commented out the line, and now it simply adds the menu items rather than replacing them
If someone can help debug this one it would be great, I'm getting a headache
Stable
I pushed out the two quick fixes which I may do for a quick 1.0.17 update
- spoyser search update
- added forward slash '/' to list of allowed characters for downloads
- fix for music section error
The stable branch is still in Anarchintosh's repo.. could use some testers on this as well to double check my changes, specifically need linux users to test the forward slash on downloads
Repo (ensure you select 'stable' branch)- https://github.com/icefilms-xbmc/icefilms-addon
- Eldorado - 2011-11-16 22:27
I should note.. when testing 1.1.0, initial scraping will take some time as each folder is usually 150 items long. After scraping is done the folders load up instantly
A new meta pack will not be created until just before release, and will likely be a good deal bigger than the original
- kfernandes29 - 2011-11-17 02:16
I downloaded the zip for eldorados github but when I try to install it in XBMC, I get an error saying the add-on doesn't have the correct structure.
Any idea what I'm doing wrong? Thanks in advance.
- Dixon Butz - 2011-11-17 03:41
kfernandes29 Wrote:I downloaded the zip for eldorados github but when I try to install it in XBMC, I get an error saying the add-on doesn't have the correct structure.
Any idea what I'm doing wrong? Thanks in advance.
You can't install from zip. Unzip it manually to the addon folder.
Inside the folder: Eldorados-icefilms-addon-8cc1e78
is the plugin.video.icefilms folder. Put that folder in addons.
Do the same with the libraries.