+- XBMC Community Forum (http://forum.xbmc.org)
+-- Forum: Development (/forumdisplay.php?fid=32)
+--- Forum: Python Add-on Development (/forumdisplay.php?fid=26)
+--- Thread: Icefilms (Icefilms.info) Addon Development Thread (/showthread.php?tid=90315)
- ndeshmukh - 2011-12-16 22:58
BTW the original icefilms code downloads the movie covers from tmdb at a very low quality. They seriously look bad on 42+ inch tvs, as compared to full quality ones.
- ndeshmukh - 2011-12-16 23:01
Eldorado Wrote:Very hacky!
I have one outstanding problem right now where if using video seeking option, and the file finishes downloading as you are watching it doesn't delete the file when you are done
On my issues list..
So what do you mean by video seeking here? Clicking on the video bar with the mouse? That doesn't work for me with D&W in my mod, I believe. Have you added special code to make it possible? Forward, rewind, 10+ min jumps works.
Well can't you delete the file in the derived player class. If it can mark the watched stuff I am sure it gets control to even delete the file after it finishes playing. Or you can choose not to bother about it, users can delete themselves, you can stick in an option in main menu to clear icefilms downloads.
- Eldorado - 2011-12-16 23:03
ndeshmukh Wrote:And whatever you do, you are going to get tons of complaints from ATV2 people. I would say put a disclaimer, not for ATV2 yet. And don't respond to those messages. They will not be able to fit the image pack. After a few months, you can try solving ATV2 problems.
I believe ATV2 might be slow to handle the xbmc image caching thread in the background, so there will be, it is too slow complaints. Feature requests for can I have fanart and covers in favorites only, or only covers but no fanart, or fanarts and covers for tv only not movies.
The less features you add at a time the better, I understand it might be difficult to pull them out right now, but it might be better to do so in the long run for your sanity's sake.
Yeah ATV2 users will lose out at least on the fanart packs, those will run upwards of over 3gigs, and will slow the system down to a crawl
I have set separate options to install TV and Movie fanart packs, the only things that are forced on enabling meta data is the DB and Movie/TV cover art.. equals about 800 megs
If we're not happy with D&W, we can just hide the options from the settings screen.. easy
ndeshmukh Wrote:So if the metahandler DB needs a change, will people lose their watched status?
That's what we want to try and avoid, I'm hoping the DB structure and fields we have are set and should be enough for majority use
If say we need to add a new table then that's no problem, a new table can easily be integrated without affecting the rest
Basically, if any changes to the DB are needed, will need to assess how to do it without compromising existing data.. but for the most part I'm pretty confident it can be done without much trouble
- Eldorado - 2011-12-16 23:07
ndeshmukh Wrote:BTW the original icefilms code downloads the movie covers from tmdb at a very low quality. They seriously look bad on 42+ inch tvs, as compared to full quality ones.
Well they are only approx. 20k each.. very low res, do you have a better source that can be tied with either IMDB or TMDB id's?
ndeshmukh Wrote:So what do you mean by video seeking here? Clicking on the video bar with the mouse? That doesn't work for me with D&W in my mod, I believe. Have you added special code to make it possible? Forward, rewind, 10+ min jumps works.
Well can't you delete the file in the derived player class. If it can mark the watched stuff I am sure it gets control to even delete the file after it finishes playing. Or you can choose not to bother about it, users can delete themselves, you can stick in an option in main menu to clear icefilms downloads.
Seeking is really just using D&W, giving the user ability to jump ahead and rewind.. of course can only jump ahead as much as you have downloaded, but many users would like to be able to rewind on free accounts
Don't get me wrong, I know I can delete the file.. just haven't gotten to that issue yet, still outstanding
- ndeshmukh - 2011-12-16 23:21
Eldorado Wrote:Well they are only approx. 20k each.. very low res, do you have a better source that can be tied with either IMDB or TMDB id's?
Seeking is really just using D&W, giving the user ability to jump ahead and rewind.. of course can only jump ahead as much as you have downloaded, but many users would like to be able to rewind on free accounts
Don't get me wrong, I know I can delete the file.. just haven't gotten to that issue yet, still outstanding
Very hacky is an understatement for my D&W code. I just added too many bad-aids and it started working, and so I was happy.
In the metahandler code just change this line...
Code:
if poster['image']['size'] == 'cover':Code:
if poster['image']['size'] == 'original':Then you should get better quality covers. about 60kb each. My movie covers folder is now 3GB.
- Eldorado - 2011-12-16 23:24
@zpanderson - that error with sources that have multiple categories exists in the current release of Icefilms, so bug has been around for awhile
Haven't been able to track anything down yet, nothing seems to make sense as to why it's returning a '3' instead of the actual sources page.. If I pull out the html request and run it in my python environment it returns fine..
Putting that error check stops the script error at least, but still left with a blank screen..
- ndeshmukh - 2011-12-16 23:27
ndeshmukh Wrote:Very hacky is an understatement for my D&W code. I just added too many bad-aids and it started working, and so I was happy.
In the metahandler code just change this line...
Code:
if poster['image']['size'] == 'cover':
Code:
if poster['image']['size'] == 'original':
Then you should get better quality covers. about 60kb each. My movie covers folder is now 3GB.
Actually some are even bigger... 300kb or so. Hence 3gb, for 11140 covers. I wonder how you have more than me, as per s sta you posted earlier in this thread. Did you supplement them from other than TMDB?
- Eldorado - 2011-12-16 23:35
ndeshmukh Wrote:Actually some are even bigger... 300kb or so. Hence 3gb, for 11140 covers. I wonder how you have more than me, as per s sta you posted earlier in this thread. Did you supplement them from other than TMDB?
Very nice, thanks! I might add a separate column for the higher quality posters in the DB
Yes, metahandlers first scrapes TMDB and uses IMDB as it's backup to fill in any holes
- rogerthis - 2011-12-17 13:18
ndeshmukh Wrote:I believe ATV2 might be slow to handle the xbmc image caching thread in the background, so there will be, it is too slow complaints. Feature requests for can I have fanart and covers in favorites only, or only covers but no fanart, or fanarts and covers for tv only not movies.
Fanart for favorites only would work so well on the ATV2 and any other low storage device. I could see the ATV3 only having 8gb aswell when that comes out. And I say that a most people coming to xbmc purely for icefilms will be using a apple tv because of the price.
The other problem that I was having with display view is more of a bug with Confluence, so I have logged it with a fix. http://trac.xbmc.org/ticket/12294
All the same, the default image for a TV Show is a banner, getting people to change the setting in System is an option. But what about banners? I have them for all my TV Shows, because that's what looked best for me when I was configuring my library a few years ago.
- Eldorado - 2011-12-17 18:49
Yep, I'm going to look at the banners option for TV Shows.. I believe metahandlers is getting the url's for them, so maybe we can add an option to the addon settings to use banners for TV Shows