[PacRat]

Using:
Windows 10 x64
Kodi 19.1 (fresh install)
NextPVR 5.1.3
Comskip 0.82.010

Issue:
Kodi crashes when trying to play a recorded TV show.

Log file:
https://paste.kodi.tv/umelikayoy.kodi

I've been using NextPVR to record episodes of the Olypics. The episodes are then processed by Comskip to create EDL files.
On a few of the episodes, Kodi crashes right after selecting Play; the log file stops right after Kodi requests the media from NextPVR.

These are very long episodes and the EDL files contain more than 32 entries (34 to be exact). If I manually edit an EDL file and limit it to 32 entries, either by removing the entry or commenting it out, Kodi is able to start playing the episode without crashing. If I go back and add an entry to the EDL, making a total of 33 entries, Kodi crashes again.

Is this a known issue or have I found something new?

[emveepee]

Can you confirm that the XML from NextPVR is OK by running this in a browser


http://192.168.3.15:8866/service?method=...7a0ee3921d

Martin

[PacRat]

Can you confirm that the XML from NextPVR is OK by running this in a browser


http://192.168.3.15:8866/service?method=...7a0ee3921d

Martin

Initially reported "invalid session", but got the full sid from the log. Returned "ok" with the full list of commercial breaks.
https://paste.kodi.tv/jezivezadu

Thanks.

[emveepee]

Thanks for confirming that.  Note you would need to click the link, not copy it,  forum software shortens the display URL.

There is no internal table in pvr.nextpvr it seems to be a core issue.  @ksooo and @phunkyfish , I just checked the code and PVR_ADDON_EDL_LENGTH is defined at 32  https://github.com/xbmc/xbmc/blob/master...ines.h#L31


Martin

[emveepee]

@PacRat I created a PR to limit pvr.nextpvr to the defined number of EDLs.  If you want to update your addon to the zip from the PR build here https://jenkins.kodi.tv/blue/organizatio.../artifacts  

You will only get 32 breaks, but at least you can watch the Olympics.  You probably are skipping around more than watching straight through anyway.

Edit this PR should now be making it's way through distribution in v 8.2.6 let me know if the problem in pvr.nextpvr continues after the addon is updated.


Martin

[PacRat]

Thanks for the update. If I install from zip, will the addon still auto-update from the repository when a new version is available there?

Got a workaround in place for now... I created a script to edit the edl files and comment out any entries over the limit; added it to my recoding process.

And yes... a lot of skipping when it comes to watching the Olympics. Being unable to auto-skip a few commercials isn't a big deal.

Thanks again!

[PacRat]

Thanks for the update. If I install from zip, will the addon still auto-update from the repository when a new version is available there?

Got a workaround in place for now... I created a script to edit the edl files and comment out any entries over the limit; added it to my recoding process.

And yes... a lot of skipping when it comes to watching the Olympics. Being unable to auto-skip a few commercials isn't a big deal.

Thanks again!

Just saw your edit and will catch the update from the repo and let you know.

[emveepee]

Good question I don't know what happens if you have a local 8.2.6 and then 8.2.6 comes out officially.  I know you can select versions from the addon information

@howie-f @phunkyfish do you know if that will that work?  If not there might be problems getting the automated translations that are now coming out.

Martin

[phunkyfish]

Good question I don't know what happens if you have a local 8.2.6 and then 8.2.6 comes out officially.  I know you can select versions from the addon information

@howie-f @phunkyfish do you know if that will that work?  If not there might be problems getting the automated translations that are now coming out.

Martin

You would need to manually update once the next version comes out. But after that auto update will function again.

It works like this so users can keep a specific version if they have installed from a zipped test build.

[PacRat]

Just waited for the new version in the repo, updated and things are working as expected now. Noticed the "Maximum EDL entries reached" in the log, nice.

Thanks again for the help.