2011-08-17, 08:23
@jonathan
I backed off the <constant> stuff - I wasn't aware we have something like this already <- shame on me
If we plan to move to push-based soon enough that surely I can drop that flag specyfing when it should be evaulated. Good point.
If someone want multiple onclicks he can use non-conditional include (if he want to reuse it) + (not yet in) conditional onclicks - I think so there is no need to mix skin variables here.
Thanks for input! and sorry for little technical talk with Jonathan (we live in completely different timezones - GMT+1/+2 vs GMT+12/+13 so hard to consult this on irc)
I backed off the <constant> stuff - I wasn't aware we have something like this already <- shame on me
If we plan to move to push-based soon enough that surely I can drop that flag specyfing when it should be evaulated. Good point.
jmarshall Wrote:Lastly, if we want to consider aligning <onclick> stuff with this, then we'd have a "multiple variable" approach which instead of returning the first item returns all items that match. That's something to consider after the single return is implemented.I don't think I want to handle that with skin vars? I see skin variable as way to define reusable dynamicly generated text (string), condition (bool) (or even color) and changes should affect mostly GUIInfoManager, CGUIInfoLabel/CGUIInfoBool/CGUIInfoColor and not affect anything else (hard to tell for sure yet - but that way I see it).
If someone want multiple onclicks he can use non-conditional include (if he want to reuse it) + (not yet in) conditional onclicks - I think so there is no need to mix skin variables here.
wyrm Wrote:Skin.SetVariable(variable-name,variable-value) and then access the the variable elsewhere in the skin with $VAR[variable-name]. Probably we would need to expand the checks against the variable as well, so something like IsEqual($VAR[variable-name],some-value). The other checks that would be handy would be IsNotEqual, IsGreaterThan, IsLessThan. Once again, just throwing the idea out there.I didn't think of SetVariable builtin - You already have Skin.SetString for this - why do You want to double this functionality? As for checks - You will be able to use existing checks - SubString, StringCompare, IntegerGreaterThan. If You need more You should request new feature because this is not really concern of skin variables.
Thanks for input! and sorry for little technical talk with Jonathan (we live in completely different timezones - GMT+1/+2 vs GMT+12/+13 so hard to consult this on irc)