Boolean conditions for skins to determine if it's a pvr build

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
BigNoid Offline
Team-XBMC Member
Posts: 2,925
Joined: Jul 2010
Reputation: 90
Location: Below sea level
Post: #1
Is it possible to get a boolean for skins to use if the xbmc build is a pvr build. I want to use it to hide the livetv settings for regular xbmc builds while maintaining the pvr xml's in the skin.
I know I can use a skin setting for that, but imo that would make no sense to put it somewhere in the skinsettings to enable livetv.
find quote
mad-max Offline
Posting Freak
Posts: 1,476
Joined: Jul 2010
Reputation: 55
Location: Germany
Post: #2
+1 for this

Makes sense to me and would be a worthwile addition!

mad-max

[Image: obi3o55x.jpg]
[Image: 7c8w3bu8.png]

- - - Tribute to Metallica - - -

If I managed to help you, please click my reputation
find quote
salora Offline
Member
Posts: 78
Joined: Jan 2012
Reputation: 0
Post: #3
maybe you can just add the option to activate livetv or not in the parameters?
like confluence or influence do
find quote
BigNoid Offline
Team-XBMC Member
Posts: 2,925
Joined: Jul 2010
Reputation: 90
Location: Below sea level
Post: #4
Confluence has separate skins for pvr and non-pvr and can do this because it's delivered with the program build itself, something not yet possible for other skins because there's no separate pvr addon branch. I don't know influence, but if by parameters you mean skin settings I think I already explained myself in the first post for that.
find quote
Hitcher Offline
Skilled Skinner
Posts: 10,288
Joined: Aug 2007
Reputation: 80
Location: Eastleigh, UK
Post: #5
I used <visible>System.GetBool(pvrmanager.enabled)</visible> for XeeBo which has PVR in the main skin.
(This post was last modified: 2012-03-16 16:27 by Hitcher.)
find quote
BigNoid Offline
Team-XBMC Member
Posts: 2,925
Joined: Jul 2010
Reputation: 90
Location: Below sea level
Post: #6
(2012-03-16 16:26)Hitcher Wrote:  <visible>System.GetBool(pvrmanager.enabled)</visible>

Does not work to hide the settings, because that boolean is set in the settings for live tv Wink
find quote
Jezz_X Offline
Team-XBMC Skinner
Posts: 5,284
Joined: Jun 2006
Reputation: 57
Location: Earth
Post: #7
Nothing will probably work unless it's also back ported to the main branch. Because the condition will always fail on the normal builds
find quote
Hitcher Offline
Skilled Skinner
Posts: 10,288
Joined: Aug 2007
Reputation: 80
Location: Eastleigh, UK
Post: #8
It fails thus it's not true and any PVR stuff remains hidden, no?
find quote
BigNoid Offline
Team-XBMC Member
Posts: 2,925
Joined: Jul 2010
Reputation: 90
Location: Below sea level
Post: #9
It will generate a error in the normal builds, but will never return true, so it will do what we want. And as long as you don't use it as a visible condition, but only with conditional includes, the log won't be spammed with errors.
find quote
jmarshall Online
Team-XBMC Developer
Posts: 25,694
Joined: Oct 2003
Reputation: 169
Post: #10
I think we've well-lost the usefulness of the "error" in the log - your thoughts?

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
BigNoid Offline
Team-XBMC Member
Posts: 2,925
Joined: Jul 2010
Reputation: 90
Location: Below sea level
Post: #11
Could be useful if you made a typo, but with PVR builds in mind I'd rather see it go. Then again, if there was a System.PVR in both pvr and normal builds we could use that instead of reading guisettings. All other pvr related settings are normally loaded in pvr xml's and are never loaded in regular builds, so no errors will be generated. In that case the error logging could stay.
find quote
jmarshall Online
Team-XBMC Developer
Posts: 25,694
Joined: Oct 2003
Reputation: 169
Post: #12
I'll make pvrmanager.enabled a valid setting in Eden (returning false, ofcourse). Sound good?

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
BigNoid Offline
Team-XBMC Member
Posts: 2,925
Joined: Jul 2010
Reputation: 90
Location: Below sea level
Post: #13
That doesn't work to hide the LiveTV settings in regular builds (otherwise the settings will be hidden for everybody, because the setting to set pvrmanager.enabled to true is in the livetv settings), but could be useful for skins that have that as a visiblitiy condition in the home window.
find quote
jmarshall Online
Team-XBMC Developer
Posts: 25,694
Joined: Oct 2003
Reputation: 169
Post: #14
Right, you mean a settings category on the main settings screen - will discuss with opdenkamp.

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
jmarshall Online
Team-XBMC Developer
Posts: 25,694
Joined: Oct 2003
Reputation: 169
Post: #15
Ok, the setting pvrmanager.enabled will return false (and not spam the log) in Eden.

Also, system.haspvr is now available (infobool) in Eden for switching items off that don't belong.

6e91544 has the goodies.

Cheers,
Jonathan

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
Post Reply