[RELEASE] Artwork Downloader - Skin support

  Thread Rating:
  • 3 Votes - 4.67 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
jfcarroll Offline
Team-XBMC Developer
Posts: 447
Joined: Dec 2006
Reputation: 3
Location: Philadelphia area, US
Post: #271
Sorry guys. JMarshall just pointed out that my fix wasn't quite right. Here it is again. This one might prove better:

https://github.com/jimfcarroll/xbmc/comm...488fcf599d

It's also now the PR: https://github.com/xbmc/xbmc/pull/790
find quote
mikebzh44 Offline
Posting Freak
Posts: 1,559
Joined: Nov 2011
Reputation: 39
Location: Nantes - France
Post: #272
Script some times abort :

http://paste.ubuntu.com/892740/

Due to movie french name ?

Sorry for my english, but, you know, I'm French so ...

find quote
Martijn Offline
Team-XBMC
Posts: 10,307
Joined: Jul 2011
Reputation: 154
Location: Dawn of time
Post: #273
(2012-03-20 22:12)mikebzh44 Wrote:  Script some times abort :

http://paste.ubuntu.com/892740/

Due to movie french name ?

Well that shouldn't matter.

can you change line 311 of default.py from:
PHP Code:
if itemname in currentitem["name"]: 
to
PHP Code:
if normalize_string(itemname) == normalize_string(currentitem["name"]): 
and see if that helps?

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2012-03-20 22:30 by Martijn.)
find quote
Wanilton Online
Posting Freak
Posts: 1,085
Joined: Jun 2010
Reputation: 24
Location: Florianópolis - Brazil
Post: #274
Now strings ok portuguese (Brazil), sorry, download here:
http://dl.dropbox.com/u/25170804/Artwork...trings.xml

thanks.

http://www.xbmcbrasil.net
XBMC Brazilian Community Forum - Admin
Windows 8.1 - XBMC Gotham - Aeon MQ 5
My Room Entertaiment´s
About me
find quote
mikebzh44 Offline
Posting Freak
Posts: 1,559
Joined: Nov 2011
Reputation: 39
Location: Nantes - France
Post: #275
(2012-03-20 22:24)Martijn Wrote:  Well that shouldn't matter.

can you change line 311 of default.py from:
PHP Code:
if itemname in currentitem["name"]: 
to
PHP Code:
if normalize_string(itemname) == normalize_string(currentitem["name"]): 
and see if that helps?
Everything work fine with this modification.

Sorry for my english, but, you know, I'm French so ...

find quote
Martijn Offline
Team-XBMC
Posts: 10,307
Joined: Jul 2011
Reputation: 154
Location: Dawn of time
Post: #276
(2012-03-21 00:10)mikebzh44 Wrote:  
(2012-03-20 22:24)Martijn Wrote:  Well that shouldn't matter.

can you change line 311 of default.py from:
PHP Code:
if itemname in currentitem["name"]: 
to
PHP Code:
if normalize_string(itemname) == normalize_string(currentitem["name"]): 
and see if that helps?
Everything work fine with this modification.

Thanks. Thought so.
And I just did a repo update. Now they're gonna kill me if I do another.... Sad
So I'll wait some more days before doing that

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
Martijn Offline
Team-XBMC
Posts: 10,307
Joined: Jul 2011
Reputation: 154
Location: Dawn of time
Post: #277
(2012-03-20 18:49)mikebzh44 Wrote:  2 - When using mode=gui, is it possible to display only valid items for the movie instead of default list :

Poster
Fanart
Logo
Clearart
Disc art

For exemple, when using Artwork Downloader in GUI mode on Avatar movie, you can only download 3 items for the moment (1 clearlogo and 2 cdart) so items list should be :

Logo
Disc art

That was actually much easier than I thought

Could you try it?
https://github.com/paddycarey/script.art.../downloads

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2012-03-21 01:36 by Martijn.)
find quote
mikebzh44 Offline
Posting Freak
Posts: 1,559
Joined: Nov 2011
Reputation: 39
Location: Nantes - France
Post: #278
It's OK, for Avatar, list items display only 2 items and for movies with only 1 item ("King's speech" or "Driven"), no more list and item is directly shown.

Great job.

Sorry for my english, but, you know, I'm French so ...

find quote
BigNoid Offline
Team-XBMC Member
Posts: 2,925
Joined: Jul 2010
Reputation: 90
Location: Below sea level
Post: #279
Works great. Much better now that you know what's available. Did not notice any slowdowns compared to previous version either.
So can we expect an update in the repo tonight Big Grin
(This post was last modified: 2012-03-21 15:16 by BigNoid.)
find quote
Martijn Offline
Team-XBMC
Posts: 10,307
Joined: Jul 2011
Reputation: 154
Location: Dawn of time
Post: #280
(2012-03-21 15:14)Big_Noid Wrote:  Works great. Much better now that you know what's available. Did not notice any slowdowns compared to previous version either.
So can we expect an update in the repo tonight Big Grin

hehe no. probably this weekend Wink
Need to make sure there are no other issues popping up.

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2012-03-21 15:45 by Martijn.)
find quote
Ghostdivision Offline
Posting Freak
Posts: 751
Joined: Jan 2012
Reputation: 0
Post: #281
So after i raised the limiter to 4, it seems to go in according to the log and deleting fanart rated to low? So is this an easy way to remove that art which was below the limiter...the program automatically does it?


Just an example in the log


Artwork Downloader: [Goodfellas] Deleted (Rating too low: 3.5): M:\Blu-Ray\Goodfellas.bluray\BDMV/extrafanart/6wPqONb9wMDeEwTHYLbnxuUU1eA.jpg
15:59:00 T:3980 NOTICE: Artwork Downloader: [Goodfellas] Deleted (Rating too low: 0.5): M:\Blu-Ray\Goodfellas.bluray\BDMV/extrafanart/uwKvcYsxAkJZm3gKgYrFodoRJyP.jpg

Theres only a few of these entries though...

Also i went in and deleted all the fan art and put the limiter back to 4... yet im seeing it is still grabbing artwork that is rated 0 or has no votes?
(This post was last modified: 2012-03-22 00:11 by Ghostdivision.)
find quote
Martijn Offline
Team-XBMC
Posts: 10,307
Joined: Jul 2011
Reputation: 154
Location: Dawn of time
Post: #282
(2012-03-22 00:03)Ghostdivision Wrote:  So after i raised the limiter to 4, it seems to go in according to the log and deleting fanart rated to low? So is this an easy way to remove that art which was below the limiter...the program automatically does it?


Just an example in the log


Artwork Downloader: [Goodfellas] Deleted (Rating too low: 3.5): M:\Blu-Ray\Goodfellas.bluray\BDMV/extrafanart/6wPqONb9wMDeEwTHYLbnxuUU1eA.jpg
15:59:00 T:3980 NOTICE: Artwork Downloader: [Goodfellas] Deleted (Rating too low: 0.5): M:\Blu-Ray\Goodfellas.bluray\BDMV/extrafanart/uwKvcYsxAkJZm3gKgYrFodoRJyP.jpg

Theres only a few of these entries though...

Also i went in and deleted all the fan art and put the limiter back to 4... yet im seeing it is still grabbing artwork that is rated 0 or has no votes?
Same answer as before...


That's a reason to go voting on artwork..
If the none rated aren't included you wouldn't get anything

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
Martijn Offline
Team-XBMC
Posts: 10,307
Joined: Jul 2011
Reputation: 154
Location: Dawn of time
Post: #283
(2012-03-21 15:45)Martijn Wrote:  
(2012-03-21 15:14)Big_Noid Wrote:  Works great. Much better now that you know what's available. Did not notice any slowdowns compared to previous version either.
So can we expect an update in the repo tonight Big Grin

hehe no. probably this weekend Wink
Need to make sure there are no other issues popping up.

Had to push the new version to repo because it took the http://fanart.tv server offline because of the API calls it made.
API data is now cached 96 hours and API calls to the fanart site have 2 second interval.
Hopefully when things are sorted this will be brought back to an acceptable minimum.

The smart dialog is added.

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
Martijn Offline
Team-XBMC
Posts: 10,307
Joined: Jul 2011
Reputation: 154
Location: Dawn of time
Exclamation  The reason why you can't download anything......
Post: #284
The reason why you can't download anything from http://fanart.tv:

http://forum.xbmc.org/showthread.php?tid...pid1053539

or read their newsletter

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2012-03-25 22:11 by Martijn.)
find quote
Ghostdivision Offline
Posting Freak
Posts: 751
Joined: Jan 2012
Reputation: 0
Post: #285
(2012-03-22 00:15)Martijn Wrote:  
(2012-03-22 00:03)Ghostdivision Wrote:  So after i raised the limiter to 4, it seems to go in according to the log and deleting fanart rated to low? So is this an easy way to remove that art which was below the limiter...the program automatically does it?


Just an example in the log


Artwork Downloader: [Goodfellas] Deleted (Rating too low: 3.5): M:\Blu-Ray\Goodfellas.bluray\BDMV/extrafanart/6wPqONb9wMDeEwTHYLbnxuUU1eA.jpg
15:59:00 T:3980 NOTICE: Artwork Downloader: [Goodfellas] Deleted (Rating too low: 0.5): M:\Blu-Ray\Goodfellas.bluray\BDMV/extrafanart/uwKvcYsxAkJZm3gKgYrFodoRJyP.jpg

Theres only a few of these entries though...

Also i went in and deleted all the fan art and put the limiter back to 4... yet im seeing it is still grabbing artwork that is rated 0 or has no votes?
Same answer as before...


That's a reason to go voting on artwork..
If the none rated aren't included you wouldn't get anything

Just curious what you mean if the none rated arent included you wouldnt get anything?

I see lots of artwork for various movies that are rated.
find quote
Post Reply