Metropolis Development

Quote:Steveb, if you made a proper fork of Stoli's repo and used branches for your patches, you'd have a much better chance of getting your changes included in the official skin via pull requests as Stoli mentioned.

I'll go through what you've done now to try to get it into the official repo, but you're going to have a hard time keeping up with changes to the official repo this way, which inevitably will lead to conflicts with other patches as time goes on. Rather a lot has already happened since you cloned the repo on Apr 17, making it so I have to go through your patches by hand to make sure they don't squash other fixes.

Of course, if you just want to maintain your own version of the skin, that's fine as well. IMHO it's best not to bifurcate the user-base, but it's your prerogative of course.

I created the repo for my friends and family to keep up with my mod. I posted it mainly to share/introduce stoli to some ideas I had come up with. Pushing so many patches can become difficult for the developer to review properly and make sure it is the best practice. and the way I have gone about certain things is totally different.
For example the way hidden views has been implemented. The fixedlist/panel/wraplist is hidden within the view in metropolis, I have disabled the whole view from the MyVideoNav.xml.
No disrespect intended but I think I'll just plod along with my own mod, My build is much older than you might think (its from when Amra first made his repo available) with some of stoli's patches added.
Like I said previous I was meaning to share some ideas, so feel free to use any you like.

(2012-05-04 01:24)Steveb Wrote:  I created the repo for my friends and family to keep up with my mod. I posted it mainly to share/introduce stoli to some ideas I had come up with. Pushing so many patches can become difficult for the developer to review properly and make sure it is the best practice. and the way I have gone about certain things is totally different.
For example the way hidden views has been implemented. The fixedlist/panel/wraplist is hidden within the view in metropolis, I have disabled the whole view from the MyVideoNav.xml.

I understand now, but you're posting in a thread that is about Metropolis development, not Megalopolis development. If you want to fork the skin, you're free to do so, but by posting it here and offering it to users you're just bifurcating the userbase of Stoli's skin.

It wasn't clear at all from your original post that you weren't working off of Stoli's repo.

(2012-05-04 01:24)Steveb Wrote:  No disrespect intended but I think I'll just plod along with my own mod, My build is much older than you might think (its from when Amra first made his repo available) with some of stoli's patches added.
Like I said previous I was meaning to share some ideas, so feel free to use any you like.

Most or all of these ideas are already listed as Issues on his github repo and people like myself are working to correct/add them to Metropolis. By selecting the most-desired issues and forking the skin you're simply going to attract users to your fork which IMHO isn't fair to Stoli.

(2012-05-04 02:49)jingai Wrote:  

(2012-05-04 01:24)Steveb Wrote:  I created the repo for my friends and family to keep up with my mod. I posted it mainly to share/introduce stoli to some ideas I had come up with. Pushing so many patches can become difficult for the developer to review properly and make sure it is the best practice. and the way I have gone about certain things is totally different.
For example the way hidden views has been implemented. The fixedlist/panel/wraplist is hidden within the view in metropolis, I have disabled the whole view from the MyVideoNav.xml.

I understand now, but you're posting in a thread that is about Metropolis development, not Megalopolis development. If you want to fork the skin, you're free to do so, but by posting it here and offering it to users you're just bifurcating the userbase of Stoli's skin.

It wasn't clear at all from your original post that you weren't working off of Stoli's repo.

(2012-05-04 01:24)Steveb Wrote:  No disrespect intended but I think I'll just plod along with my own mod, My build is much older than you might think (its from when Amra first made his repo available) with some of stoli's patches added.
Like I said previous I was meaning to share some ideas, so feel free to use any you like.

Most or all of these ideas are already listed as Issues on his github repo and people like myself are working to correct/add them to Metropolis. By selecting the most-desired issues and forking the skin you're simply going to attract users to your fork which IMHO isn't fair to Stoli.

I was trying to help Metropolis development by sharing some of my mods and ideas, if you don't like that, that's fair enough, don't use them! As far as bifurcating the user-base, I've only mentioned my build Megalopolis once in all the time stoli has been developing the skin and that was because of the size of the mods in question. My build is not officially posted anywhere on this forum and If your worried about people using my mod, that's pretty petty and I'm sorry you feel that way.

(2012-05-04 03:28)Steveb Wrote:  I was trying to help Metropolis development by sharing some of my mods and ideas, if you don't like that, that's fair enough, don't use them!

Nobody said anyone didn't like that. It's that it's very difficult to use your mods in the official repo as they are because you're not collaborating with other developers of the skin.

(2012-05-04 03:28)Steveb Wrote:  As far as bifurcating the user-base, I've only mentioned my build Megalopolis once in all the time stoli has been developing the skin and that was because of the size of the mods in question. My build is not officially posted anywhere on this forum and If your worried about people using my mod, that's pretty petty and I'm sorry you feel that way.

I'm really not trying to be rude. It's exactly the size of your mods and the fact that we can't properly diff against the official repo that is the issue. I can't use your patches directly because you're working off of some version of the code that you're not disclosing.

Again, if you want to publicly maintain your own fork that is your prerogative. I don't have to agree with that, though. I personally think it's better to push changes upstream so everyone is on the same page.

You shared your fork on this thread -- the Metropolis Development thread -- so I think on some level that means you want people to use it. I don't think this is the right thread to do that on, is all.

Just sent a pull request to Stoli. I've added a new toggle option in the settings that will allow the use of the Realistic Weather icons instead of the default Metropolis weather icons.

If my mention of the forked skin is the cause of this latest discussion, I apologize to everyone involved. (That was not my intention!)

I thinkk Steveb mods are great and he has done a great job doing them. I wish he would agree to work together on this skin to make it a even better skin instead of having is own fork. If not then let it be.


All in all this skin is coming out great. Looks great on the big screen!

(2012-05-04 01:24)Steveb Wrote:  I created the repo for my friends and family to keep up with my mod. I posted it mainly to share/introduce stoli to some ideas I had come up with. Pushing so many patches can become difficult for the developer to review properly and make sure it is the best practice. and the way I have gone about certain things is totally different.
For example the way hidden views has been implemented. The fixedlist/panel/wraplist is hidden within the view in metropolis, I have disabled the whole view from the MyVideoNav.xml.
No disrespect intended but I think I'll just plod along with my own mod, My build is much older than you might think (its from when Amra first made his repo available) with some of stoli's patches added.
Like I said previous I was meaning to share some ideas, so feel free to use any you like.

Thank Steve - I'll pick through your code and see how you have implemented features I want.

Regards,

More cool stuff to do with the weather display...

You can replace the weather folder with one of the "weather packs" found at http://xbmc.exstatic.org/weather_fanart/

Just rename the downloaded folder to "weather" and replace the default folder under the "extras" folder.

Makes the "Home" screen look very nice....:

(2012-05-06 03:40)thewarm Wrote:  More cool stuff to do with the weather display...

You can replace the weather folder with one of the "weather packs" found at http://xbmc.exstatic.org/weather_fanart/

Just rename the downloaded folder to "weather" and replace the default folder under the "extras" folder.

Makes the "Home" screen look very nice....:

any screen pics to show it off?