Testing help needed for Myth 0.25 support

  Thread Rating:
  • 1 Votes - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
dteirney Offline
Team-XBMC Developer
Posts: 830
Joined: Jul 2007
Reputation: 6
Location: New Zealand
Post: #106
(2012-05-07 13:57)rdoac Wrote:  Wanted to report back, we watched a recording last night using Mythbox git, which used cmyth for playback. The commercial skips were firing in the wrong place and jumping 7 mins. I am going to apply the patch and see if it's better. (No Commercial Skip would be better). Commercial skip fired if we clicked play or play+skip.

I'd need a log and more detail about what the wrong place means. Note that there are some advanced EDL settings that can be configured in XBMC to help clean up the sometimes dubious commercial breaks that are detected by mythcommflag (depending on the algorithm configured). I use Logo Detection only for DVB-T recordings in NZ and found that to be the most reliable for the content broadcast over here. I strongly recommend testing the different options if you have the patience. Curiously the "All available methods" algorithm was the worst performing option based on the testing I did.

For more detail see http://wiki.xbmc.org/index.php?title=Use...#.3Cedl.3E

7 minutes sounds curiously like twice the typical 3:30 commercial breaks we get over here so it's possible the frame rate for content was being guessed at half the rate when it perhaps shouldn't be. There are some heuristics applied to determine what frame rate to use to obtain the time markers from the frame markers stored in mythbackend. If the frame rate was guessed incorrectly then the positioning would be off by a factor of 2 as well. Would need a log file to see if the heuristics need adjusting.

You can find the heuristics and the log messages that should appear in the log file in the ReadEditDecisionLists() method at https://github.com/xbmc/xbmc/blob/master...er/Edl.cpp

Use MythTV for recording TV? Try the integrated MythTV support in XBMC Media Center. Now with commercial skip support built-in and integration with the Movie database!
(This post was last modified: 2012-05-07 14:35 by dteirney.)
find quote
fiveisalive Offline
Fan
Posts: 365
Joined: Jul 2009
Reputation: 0
Location: United States
Post: #107
(2012-05-07 13:57)rdoac Wrote:  Wanted to report back, we watched a recording last night using Mythbox git, which used cmyth for playback. The commercial skips were firing in the wrong place and jumping 7 mins. I am going to apply the patch and see if it's better. (No Commercial Skip would be better). Commercial skip fired if we clicked play or play+skip.

I had the same problem with MythBox (skipping regardless of "Play" or "Play+Skip") and incorrect jumps in some shows. This was when I had set the MythBox options to use "streaming", but when I disabled streaming and set the local recordings directory, all was well. So there seems to be some issues with streaming vs. local recordings, I found this out in the MythBox thread: http://forum.xbmc.org/showthread.php?tid...#pid850552 It seems that the issues are with xbmc's myth:// commercial skipping code vs. the commercial skip points supplied by mythtv itself.
find quote
rdoac Offline
Senior Member
Posts: 163
Joined: May 2009
Reputation: 0
Post: #108
The commercial skip normally works fine in mythfrontend, this leads me to believe that it was xbmc/mythbox not reading the timings correctly.
find quote
dteirney Offline
Team-XBMC Developer
Posts: 830
Joined: Jul 2007
Reputation: 6
Location: New Zealand
Post: #109
If anyone has a USB tuner that's not working with Live TV, I've resurrected some old patches that need testing. Details at http://forum.xbmc.org/showthread.php?tid=131011

Would be great if someone happens to have a USB tuner, e.g. HDPVR, and could check if the changes are still working with a Myth 0.25 backend. The submitted patch was originally against Myth 0.24.

Use MythTV for recording TV? Try the integrated MythTV support in XBMC Media Center. Now with commercial skip support built-in and integration with the Movie database!
find quote
dteirney Offline
Team-XBMC Developer
Posts: 830
Joined: Jul 2007
Reputation: 6
Location: New Zealand
Post: #110
I've created a new thread to track commercial skip problems as well. http://forum.xbmc.org/showthread.php?tid=131016

Use MythTV for recording TV? Try the integrated MythTV support in XBMC Media Center. Now with commercial skip support built-in and integration with the Movie database!
find quote
fiveisalive Offline
Fan
Posts: 365
Joined: Jul 2009
Reputation: 0
Location: United States
Post: #111
I'd like to try to apply the changes in the myth-0.25 branch back to tsp's cmyth add-on to try to test myth 0.25 with this add-on, while I'm waiting on them to trickle down via dushmaniac's branch. My git-fu is not yet strong enough to know how to do this easily. I assume I can try cherry-picking the commits on https://github.com/dteirney/xbmc/commits/myth-0.25 from April 16 onwards and apply them back to tsp branch (I don't think tsp has modified those sections since). Can anyone guide me on the best practice for doing this via github?

Update:

I think I managed to figure out a (possibly suboptimal) way to do this. For others who are interested, here's what I did (also please point out any errors that this might introduce and/or better ways to do this):

Code:
mkdir dteirney
mkdir tsp
cd dteirney
git clone --branch myth-0.25 https://github.com/dteirney/xbmc.git
cd xbmc
git diff 00e6c1c559fc3a22e059197b6f1aa7879a39939b > ../xbmc-myth-0.25.patch
cd ../tsp
git clone https://github.com/tsp/xbmc.git  (assuming you haven't already checked this out)
patch -p1 < ../../dteirney/xbmc-myth-0.25.patch

I found that there were 2 hunks that failed to apply in the file connection.c. I loaded the connection.c.rej file:

Code:
--- lib/cmyth/libcmyth/connection.c
+++ lib/cmyth/libcmyth/connection.c
@@ -731,6 +746,12 @@
                          __FUNCTION__, host, port, buflen);
                goto shut;
        }
+       /*
+        * Explicitly set the conn version to the control version as cmyth_connect() doesn't and some of
+        * the cmyth_rcv_* functions expect it to be the same as the protocol version used by mythbackend.
+        */
+       conn->conn_version = control->conn_version;
+
        ann_size += strlen(path) + strlen(my_hostname);
        announcement = malloc(ann_size);
        if (!announcement) {
@@ -740,7 +761,7 @@
                goto shut;
        }
        if (control->conn_version >= 44) {
-               sprintf(announcement, "ANN FileTransfer %s[]:[]%s[]:[]",
+               sprintf(announcement, "ANN FileTransfer %s 0[]:[]%s[]:[]",  // write = false
                          my_hostname, path);
        }
        else {

And manually applied the first hunk to connection.c (the second seemed to be not relevant anymore, because of changes in tsp's branch).
(This post was last modified: 2012-05-08 19:47 by fiveisalive.)
find quote
philr Offline
Junior Member
Posts: 2
Joined: May 2012
Reputation: 0
Post: #112
I know this is a newbie question... But...

Having read the entire thread (several times) and followed the commands in post #35 (several times) I still don't see how to get "Live TV" or "PVR Addons" to show in the GUI.

Could someone be terribly kind and point me in the right direction?
find quote
ixian Offline
Donor
Posts: 95
Joined: May 2008
Reputation: 2
Post: #113
(2012-05-09 00:45)philr Wrote:  I know this is a newbie question... But...

Having read the entire thread (several times) and followed the commands in post #35 (several times) I still don't see how to get "Live TV" or "PVR Addons" to show in the GUI.

Could someone be terribly kind and point me in the right direction?

If I'm not mistaken this particular test was using a non-PVR build of XBMC. You need a PVR build; however that's outside the scope of this thread.

If you are just looking to get a PVR going with Myth this is the wrong thread entirely Smile
find quote
fiveisalive Offline
Fan
Posts: 365
Joined: Jul 2009
Reputation: 0
Location: United States
Post: #114
(2012-05-09 00:59)ixian Wrote:  
(2012-05-09 00:45)philr Wrote:  I know this is a newbie question... But...

Having read the entire thread (several times) and followed the commands in post #35 (several times) I still don't see how to get "Live TV" or "PVR Addons" to show in the GUI.

Could someone be terribly kind and point me in the right direction?

If I'm not mistaken this particular test was using a non-PVR build of XBMC. You need a PVR build; however that's outside the scope of this thread.

If you are just looking to get a PVR going with Myth this is the wrong thread entirely Smile

Indeed. If you want a PVR build that can access MythTV <= 0.24 (if you're running Linux you'll need to compile it yourself), see the cmyth add-on created by tsp42: here: http://forum.xbmc.org/showthread.php?tid=110694.

If you have MythTV >= 0.25, you'll need to get the same code for tsp42's add-on, but before building apply a patch to get the MythTV 0.25 support. That's what I managed to do in post 111, above: http://forum.xbmc.org/showthread.php?tid...pid1098065 (but it's not for the faint of heart).

The instructions in post 35 are only for a build that doesn't use the PVR functionality, only the original built-in myth:/// protocol support. The Myth 0.25 support is now in the upstream master, but it will take a while to trickle down to the PVR add-on, because it needs to be pulled in by dushmaniac's branch, and then by tsp's add-on.
(This post was last modified: 2012-05-09 01:17 by fiveisalive.)
find quote
philr Offline
Junior Member
Posts: 2
Joined: May 2012
Reputation: 0
Post: #115
Thanks, both. I'll give up for now...
find quote
snowbie Offline
Junior Member
Posts: 1
Joined: Jan 2009
Reputation: 0
Post: #116
I finally got my Mythbuntu box up and running on 0.25 and now see that it isn't support in the base Eden code. I really got lost in the explanation about around piecing together a build based upon various git structures. I don't normally shy away from a little hard work but this intimidated me. I should also mention that I normally don't do my own builds. How would someone like me get MythTV 0.25 working in Eden? (Using both windows and iOS XBMC systems).
find quote
PhoenixMage Offline
Junior Member
Posts: 19
Joined: Feb 2012
Reputation: 0
Post: #117
(2012-06-27 05:39)snowbie Wrote:  I finally got my Mythbuntu box up and running on 0.25 and now see that it isn't support in the base Eden code. I really got lost in the explanation about around piecing together a build based upon various git structures. I don't normally shy away from a little hard work but this intimidated me. I should also mention that I normally don't do my own builds. How would someone like me get MythTV 0.25 working in Eden? (Using both windows and iOS XBMC systems).

The latest windows build at the start of this thread works on 0.25. Cant speak for iOS.
find quote
jaygardner Offline
Member
Posts: 50
Joined: Dec 2009
Reputation: 0
Location: Colorado
Post: #118
just trying to catch up here... the repository in 1st post: https://github.com/dteirney/xbmc/tree/myth-0.25 is not found.. i tried using the clone line in post 111 above, which works, but returns a warning: "warning: Remote branch myth-0.25 not found in upstream origin, using HEAD instead"

and when i try and follow instructions to build - starting with bootstrap: ./bootstrap, i get this error:
./bootstrap: 5: ./bootstrap: autoreconf: not found

is support for myth 0.25 in xbmc located somewhere else now?

thanks, jay
find quote
jaygardner Offline
Member
Posts: 50
Joined: Dec 2009
Reputation: 0
Location: Colorado
Post: #119
ah, i forgot to install the build dependencies...

never mind the bootstrap related question in previous post.
find quote
Post Reply