2017-06-30, 18:58
If anyone wants it here is my 17.3 windows build w/ the OrderedChapter commits from Moritz:
http://www.mediafire.com/file/a6vvp1zuea...OC-x86.exe
http://www.mediafire.com/file/a6vvp1zuea...OC-x86.exe
(2017-06-30, 18:58)garretn Wrote: If anyone wants it here is my 17.3 windows build w/ the OrderedChapter commits from Moritz:
http://www.mediafire.com/file/a6vvp1zuea...OC-x86.exe
(2017-07-24, 00:31)EGOvoruhk Wrote:(2017-06-30, 18:58)garretn Wrote: If anyone wants it here is my 17.3 windows build w/ the OrderedChapter commits from Moritz:
http://www.mediafire.com/file/a6vvp1zuea...OC-x86.exe
Is this only for external linking, or would it work for choosing an edition from a 2in1 file created with Xin1generator? (eg single file with Theatrical and Director's Cut)
xbmc/cores/VideoPlayer/DVDDemuxers/DemuxTimeline.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xbmc/cores/VideoPlayer/DVDDemuxers/DemuxTimeline.cpp b/xbmc/cores/VideoPlayer/DVDDemuxers/DemuxTimeline.cpp
index 5c7d0cb5f2..95b032655e 100644
--- a/xbmc/cores/VideoPlayer/DVDDemuxers/DemuxTimeline.cpp
+++ b/xbmc/cores/VideoPlayer/DVDDemuxers/DemuxTimeline.cpp
@@ -218,7 +218,7 @@ CDemuxTimeline* CDemuxTimeline::CreateTimeline(CDVDDemux *primaryDemuxer)
// collect needed segment uids
std::set<MatroskaSegmentUID> neededSegmentUIDs;
for (auto &chapter : edition.chapterAtoms)
- if (chapter.segUid.size() != 0 && chapter.segUid != mkv.segment.infos.uid)
+ if (chapter.segUid.size() != 0 && chapter.segUid != mkv.segment.infos.uid && !chapter.flagHidden)
neededSegmentUIDs.insert(chapter.segUid);
// find linked segments
(2017-09-04, 21:24)vertigo220 Wrote: FFmpeg issue #3123 appears to be the critical step everyone is waiting for, so it would be a good idea for everyone wanting this functionality in Kodi to go upvote it.
(2017-09-06, 18:07)vertigo220 Wrote: Unfortunately, your build wouldn't help me, since I run Kodi on my Shield TV.Thats right, my build is Windows only, but the patches should work on all platforms, if you compile yourself or find someone who will compile for you. Unfortunately, I don't have the required Linux build environment for an Android build, so I can't be of help here.
(2017-09-06, 18:20)garretn Wrote: Neato. It'd be cool to select edition via a Simple Menu, like how they're implemented for blu-rays.That would require actual work, including Kodi GUI work, so don't expect that from my side ;-)
(2017-12-11, 10:11)da-anda Wrote: if I'm not mistaken Kodi now does support multiple video streams you can choose from in the videosettings OSD during playback. Maybe this will help you guys to come up with an acceptable patch now? And with inputstream at hand, it might be possible to add a custom demuxer on top of whatever ffmpeg does - as the MPEG DASH stuff is also not part of ffmpeg and handled by inputstream.adaptive. So if you take inputstream.adaptive as an example and base your work on it, chances might be good to finally get your desired feature in. Hope that does help you guys in some way.
(2017-12-11, 10:11)da-anda Wrote: if I'm not mistaken Kodi now does support multiple video streams you can choose from in the videosettings OSD during playback. Maybe this will help you guys to come up with an acceptable patch now? And with inputstream at hand, it might be possible to add a custom demuxer on top of whatever ffmpeg does - as the MPEG DASH stuff is also not part of ffmpeg and handled by inputstream.adaptive. So if you take inputstream.adaptive as an example and base your work on it, chances might be good to finally get your desired feature in. Hope that does help you guys in some way.Just tried on one of my videos made with xin1 and it only showed one available stream and wouldn't even let me select the option, presumably since there was nothing to change. So maybe this works if two completely separate streams are present (which I don't even know what the purpose of that would be) but not where only parts are different, as with a file made with xin1. This is on the Shield TV and my phone (latest version of Kodi on both, Shield and phone both up to date with phone on Nougat).
(2017-12-15, 11:06)hainguyen1993 Wrote: I think it's fair to say that the devs aren't interested, certainly not without knowing for sure whether it's a matroska "feature" or whether it's something someone else has hacked on.