Posts: 211
Joined: Apr 2010
Reputation:
3
What do you think about removing folder.jpg support ? There's no point in having: poster.jpg, movie.tbn, folder.jpg just for the sake of tring to catch all default possibilities. I never used them, they not hard to maintain but the support is irregular between views...
- Should we only support poster.jpg ?
- Should we remove folderr.jpg (For example the logo downloader downloads a folder.jpg file which is displayed on top of the tvdb scrapped poster for some of my tv show, which is irritating.
Any ideas ?
Posts: 2,710
Joined: Feb 2009
Reputation:
12
ppic
Skilled Python Coder
Posts: 2,710
folder.jpg is the default for xbmc, how would you remove this?
Posts: 1,234
Joined: Nov 2008
Reputation:
5
2010-09-01, 22:31
(This post was last modified: 2010-09-01, 22:33 by ekim232.)
If you are going to remove anything it should be the other naming conventions. Keeping skins in line with xbmc defaults should be a common practice. Once you get into outside naming everyone gets confused and you end up with countless posts about how to make a skin work.
As far as I know poster.jpg isn't an xbmc naming scheme. It was created within Aeon.
Your code above can be removed. Simply use <texture>listitem.thumb</texture> It makes no sense at all to have that.....
Posts: 1,234
Joined: Nov 2008
Reputation:
5
Correct
I don't know any other skin that those work with. I always try to keep things in line with xbmc standards. That way, skins will work right out of the box, so to say.
Posts: 211
Joined: Apr 2010
Reputation:
3
Ok, I always thought poster.jpg was somehow typical of Aeon but I may be wrong.
Posts: 3,379
Joined: Feb 2009
Reputation:
15
mcborzu
Skilled Skinner
Posts: 3,379
I think it was a minor thing for users to use. The way <texture>$INFO[ListItem.path]folder.jpg</texture> is used in Aeon is only for the Info screen, I believe, unlike 'extrathumbs' which is an extra for users but have a cool purpose, and can be used in different ways.
And like phil65 said with the advancedsettings you can now specify a bigger thumb size if you'd like...
Check out Night - A Skin For XBMC
Posts: 6,684
Joined: Mar 2009
Reputation:
147
phil65
Retired Team-Kodi Member
Posts: 6,684
2010-09-01, 23:38
(This post was last modified: 2010-09-01, 23:40 by phil65.)
But you would lose the possiblity to show the thumbs in full quality... i have them in full quality by using ember media manager, and i don´t want to lose that. if movie.tbn doesn´t have the full resolution (I don´t know how the caching/extracting works in xbmc) we should use another file, but we should have defintely a way to display them larger than the standard 512 x 512. DJH included this with a reason some time ago.
people who don´t want to use it won´t have that files, so it doesn´t really matter if it is included, isn´t it? they should be simply be shown in front of the cover, if you want we can do that with includes. (apart from that, i don´t think that we should work too much with includes, at least across the viewtypes.. can be very irritating sometimes and Aeon has, in Comparison to Confluence, already now 15 times more includes (50 against 750 i think)