[REQUEST] Tweens for lists

jmarshall Wrote:(On that count, I presume the scroll class thingee will be doxy'd up?)

Once skinners will be pleased with results (will they ever be? ), yes.

Also I will do proper code refactoring and git rebasing when functionality will be ready - currently this is moving target, so can't really design it properly without knowing how it should work

I think I didn't describe what scroll correction actualy does and thus there might be some confussion about it.

So I need to add some terms that will help explaining it:



Container RenderArea - red rectangle on picture
ScrollOffset - this is distance (measured in pixels) between left/top edge of container renderarea and left/top edge of first item in container (length of green arrow on picture)

When we change selection in containers that initiate scrolling, container tries to correct ScrollOffset so selected item stays visible for the user - so this happens only when You press key (it won't try to correct ScrollOffset during scrolling if You're not holding key)

---

Presentation of different scroll correction methods using slightly changed view in confluence:

• DEFAULT - http://www.youtube.com/watch?v=cyLEVLk25k8
  this is what is used in dharma/master now - scrolling is done on limited distance
• AGGRESIVE - http://www.youtube.com/watch?v=iehTooQ6U-Y
  we only ensure that focused item is kept in container RenderArea - in video focused item is aligned to right border of container when holding key
• LOOSE- http://www.youtube.com/watch?v=Q1JtcQ3pGqM
  we only ensure that previously focused item is kept in container RenderArea subtracted by size of single item on both ends (it's marked by blue lines on picture) - so if we are scrolling by holding up/down/left/right - it will keep selected item in RenderArea (same as aggresive), but if we use page up/down / scroll to top/bottom - it won't correct scroll offset presenting some nice effect
• DISABLED - http://www.youtube.com/watch?v=PbDHTU6Ev7s
  as tittle say - we don't do any scroll correction - selected item can go out of RenderArea
  

PS. Yes I can see that weird things going on screen - this is dirty region related and I will need to check that later

The videos are great at showing the difference. Personally I prefer aggressive, but have no issues with Loose should that be preferred in general.

Default and Disabled are too extreme in either direction.

I'm leaning toward aggressive mode too - if noone will be againast it - I'll prepare PR in few days.

I prefer disabled over aggressive because with aggressive there's absolutely no scroll out if I scroll left in my list (focused item is left aligned), stops immediately. Right is less than with disabled but I could live with that. Maybe you should left the options.

`Black: You mean if you scroll to the right, because the focused item is aligned on the left it never has the ramp down effect? If you scroll to the left, the focused item will move a bit off the left and ramp back to the left on finish? The problem isn't with the restriction, it's just the restriction doesn't make sense when the focused item is hard on the left or right (as there's no looseness there).

A video might be useful

Cheers,
Jonathan

Maybe my explantation wasn't the best, will do a video.

do You mean that if <focusposition> is set to 0 and we go left - it will instatly select previous item without scrolling? this may not look good but this fits logic behind aggresive/loose scroll correction.

what is Your proposition to handle it? extend "no correction area" so focused item can be "just outside" of container renderarea? (actually list and panel is doing it that way in aggressive mode)

Yes, focusposition is set to 0. If you scroll 1 item, it's ok but if your scrolling many items, there's no extra pagescrolltime as with disabled. I get why because the focused item doesn't get out of the container and stays left so it stops immediately... so I prefer disabled because there's no big difference in my view. Here are the videos:

Disabled
Aggressive

Maybe it's just me but I prefer the aggressive video personally.