[PATCH] Hardware deinterlacing for both software and DXVA2 decoded material

Ok, will try the things you asked for. Just finished testing the solution that voyager posted, unfortunately it didnt make any difference.

Furthermore, I switched of DXVA2 in the system menu, that didn't make any difference, but I guess that was to be expected. When I startup the video, it uses DXVA deinterlacing anyway and that's the problem. More precise:

15:13:20 T:3256 M:704425984 ERROR: DXVA - failed executing m_process->VideoProcessBlt(target, &blt, samples.get(), count, NULL) at line 1362 with error 80070057
15:13:31 T:3256 M:706027520 ERROR: Previous line repeats 444 times.

It's not the decoding, it's the rendering (processblt), so that's why it doesnt matter that I switch off DXVA2 in the system menu.

Will try the things you asked for now.

BTW, even when I switch interlaced to none, in your build, and I see that the framerate isnt' doubled, I still only have a black picture ! It's still set to DXVA scaling, but I can't turn that off, might that be the problem ?

I'll now check a11559's patch.

LOL, I know what it is

The thing is, that your patch tries to invoke DXVA stuff when playing a regular DVD. The a11559's patch doesn't even show any trace at all of DXVA when playing such a DVD.

If I try to play a 1080i mpg, THEN both of your patches use dxva deinterlacing correctly.

I should formulate it better: the problem is ISO

The a11559 patch doesn't use DXVA2 for ISO's, yours does and that's where it goes wrong.

Hmmm, actually, it's not even that it seems .... I just found an ISO that doesnt play on a11559's patch AND now I just even found a regular .vob that doesnt play on his patch .....

I'll try on my other system and I'll also see if I can cut out some part of the VOB to post it here.
*EDIT* weird stuff, I found that the VOB plays fine on a11559's patch, but there is one of my iso's that problematic on his patch as well and if I play that iso first and THEN any other VOB, THEN none of the VOB's play anymore ... So it does seem it definately has to do something with iSO.

Furthermore, with some DVD ISO's his patch *does* use dxva decoding and for others it doesnt, that's weird anyway isnt it ?

It's getting even weirder ! the ISO's that used DXVA2 before on his patch didnt after the last reboot ! I then tried an MKV and I just got a black screen on that ! I couldnt even quit the video anymore ...

Going to delve deeper into this, wtf ....

Ok, I know a little more. I reverted back to Dharma 10.1 and guess what, that ISO still didnt play ! It then popped into my mind that I had changed some DVD options and yep, that was it I deselected 'attempt to skip introduction before DVD menu' and the video played ! Pfffff... that sh*t was messing up my tests

Now, going to try yours and a11559' patches again

Ok, still on Dharma10.1 I tried to play ISO's again. At least, after deselecting that DVD option, they all play. However (!!) I don't get any DXVA2 acceleration ! The debug log:

http://pastebin.com/4K6zqEs2

ProcessBlt fails !?!

Hmmm ... I installed the new catalyst (11.6) yesterday, maybe that's the problem here .... Going to revert to good old 11.4 and see if that changes anything .... But then again, thinking of it, I dont think I even checked before while playing DVD's if it was DXVA2 accelerated, so it might not even be a driver issue ... going to do some more testing

Anyway, it seems all this isn't even related to your patches, sorry for cluttering up your thread, lol Will let you guys know once I find out more.

*EDIT* Same issue on catalyst 11.4 ... seems like a bug in the official Dharma release (and later), going to investigate more ...
*EDIT2* No it's not the *same* issue on 11.4. On 11.4 XBMC doesnt even attempt to use DXVA for DVD's !?!? Again, investigating more ..

Ok, There were several issue's here:

1) That option in the system/video/dvd menu that tries to skip intro's, that's definately buggy, should be switched off
2) catalyst 11.6 gives me process blt errors, 11.4 is fine
3) There's no DXVA2 decoding support for DVD ISO's it seems. It just doesnt even try to select it, so I think there's a bug there

Then, your patches:
There's still an issue with your patch, isidrogar. When I try to play a certain ISO and I have the deinterlace default to 'best available', i get the black screen. When I then switch while playing the video, to bob etc, and then back to 'best available', it works *EDIT* nope, it still doesnt work that way*! This issue doesnt seem to happen when I try to play VOB files, so I think it might be correlated with that above issue in ISO's ....

Will investigate more