Cleaning up condition syntax

**topfs2** · 2011-07-09 16:12

Jeroen Wrote:Sounds good, as long as we'd could still make things like

$INFO[ListItem.Year,, - ]$INFO[ListItem.Duration,, $LOCALIZE[12391]]$INFO[ListItem.Genre, - ]

work to show prefixes or suffixes only if they're available.

Hmm, did not think of that. To me it sounds like a helper function almost
suffix(ListItem.Year, "-") which returns ListItem.Year+"-" if ListItem.Year resolves to true perhaps?

So your case would be

Code:

suffix(ListItem.Year, "-") + suffix(Listitem.Duration, Localize(12391)) + prefix(Listitem.Genre, "-")

Would make it closer to scripting almost

Big_Noid · 2011-07-09 16:45

topfs2 Wrote:Another thing I've been pondering which might be worth discussing? is the inconsistency between conditionals and just text.

In conditional you write Player.Something but in text you need to do $INFO[Player.Something] if you wish to get it, would it make sense to unify this and always assume it being more programmer oriented?

i.e. you need to write "something" instead of something in text stuff, and instead of $INFO[Player.Something] you can just write Player.Something as it will be interpreted as an info always.

Benefit with this would be same code all over and perhaps easier parsing. Downside is that its a giant change for skinners, even if we can do some backwards compat regarding it.

So if you want to combine strings in text you'd need to do "Currently playing: " + Player.WhateverNeededToGetTrack + " and it rocks!".

Benefit is that this would enforce some form of implicit typing in core which might be nice no matter. Would allow to do <visible>Player.TrackArtist</visible> as the string "" is resolved to false.

EDIT: It would probably include using something like Localize(1234) for non-hardcoded strings

thoughts?

Isn't that what the <info> tag is for? I believe the $INFO tag is for advanced label formatting?

**topfs2** · 2011-07-09 16:48

Big_Noid Wrote:Isn't that what the <info> tag is for? I believe the $INFO tag is for advanced label formatting?

Yeah for sure, I was mostly talking about combining them. so same way to do advanced as with simple.

I've always found it a bit confusing (the little skinning I've done) that you have both info and advanced label formatting Smile

So old <info>TheInfo</info> would become <label>TheInfo</label> and if you want it advanced you just start adding stuff, i.e. <label>TheInfo + " and I rock!"</label>. Might make it more understandable for new skinners, and more maintainable for old?

Big_Noid · 2011-07-09 17:07

I don't think the amount of effort this will take to implement outweigh the benefits plus personally I'm actually quite happy with the way things are now.

mcborzu · 2011-07-09 18:04

I taught myself atleast the basics of some languages and XBMC is definably easiest to learn. I hate to get too complicated and lose the ease of use XBMC coding has at the moment...

@topsf2

So in those example all regular text would need to be enclosed in quotations?

**ronie** · 2011-07-09 18:10

personally i don't see how changing (what we currently have):

PHP Code:

<label>[b]some text[/b]</label> 

to:

PHP Code:

<label>[b] + "some text" + [/b]</label> 

would make things more understandable for anyone?

but if there are any advantages (speed / code maintainability) it should be considered of course.

topfs2 Wrote:suffix(Listitem.Duration, Localize(12391))

if we drop the $INFO bit, then we might as well drop the need for $LOCALIZE ?

Code:

suffix(Listitem.Duration, 12391)

should work just as well, correct?

pecinko · 2011-07-09 18:25

Guys, you're going way too far.. :-)

@ronie

in this example

Code:

suffix(Listitem.Duration, 12391)

we would probably have a problem with info & non info strings mixtures?

I would vote for changes that would lead to:

Code:

a) ListItem.Duration(X)

b) ListItem.Duration(XL)

c) ListItem.Duration(DELUXE)

giving us

Code:

a) 124

b) 2:04:15

c) 124 Minutes       *Minutes being localized label*

and eliminating non necessary use of prefixes/ suffixes

The same goes for

Code:

ListItem.Description

returning us content based description - Plots, Album info etc.. with nice localized fallback label "No description available" included.

In other words - I would love to use design, not programing skills for skinning.

**topfs2** · 2011-07-09 22:49

@mcborzu

I'm c++ dev so anything closer to that paradigm I feel is easier, which is also why I might very well be clouded Smile

So why I only suggest it and would love skinners view on it Smile

I think it would be easier but that may in no way be true for those using it Smile

and yes, anything non-localized and hardcoded text (which should be baaaad in official repo Smile

" related would need " encapsulation.

@ronie

Not sure we can drop the localize bit as then its impossible to deal with int types, i.e. say I want to do <label>Player.Artist + " I rock" + 1 + "!!!!"</label> redicoulus example I know but the 1 there should be a number 1 and not localized 1. So IMO better to be explicit?

Regarding the [b], I did not think of that at all. That doesn't fit into the thing I suggested one bit. The best way to do that consistently in how I suggested would be

Code:

bold("my awesome text " + Player.Artist + " : " Localize(1234))

@All
My suggestion was only something worth discussing, I personally think it might clean it up but that in no way reflect what jonathan and you guys may think, I just wanted to put it out there as I would be willing to put in some work and make it that way if there is interest for it Smile

Cheers,
Tobias

Hitcher · 2011-07-10 00:13

I think the current labelling system -

PHP Code:

$INFO[], $LOCALIZE[], [b][/b], [color=][/color] 

- is fine and fairly understandable but the actual info could definitely do with a tidy up.

I think black was along the right lines of what Jonathan's suggesting -

Control(id).IsVisible
Window(id).IsVisible
ControlGroup(id).Item(id).HasFocus

**Jezz_X** · 2011-07-10 11:02

I got to agree with hitcher on this one the Layout stuff that is like a forums option is super easy to understand and powerful enough and the suffix and prefix stuff already works and works fine the only real changes to that I would like is to allow other infolabels to be a suffix or prefix for another
eg: $INFO[MusicPlayer.Artist,,- $INFO[MusicPlayer.Album]] will not work currently

Big_Noid Skilled Skinner Posts: 2,627 Joined: Jul 2010 Reputation: 68 Location: Below sea level	2011-07-09 17:07 Post: #24 I don't think the amount of effort this will take to implement outweigh the benefits plus personally I'm actually quite happy with the way things are now. Aeon Nox 4.0 Droid
	find quote

Hitcher Skilled Skinner Posts: 9,942 Joined: Aug 2007 Reputation: 67 Location: Eastleigh, UK	2011-07-10 00:13 Post: #29 I think the current labelling system - PHP Code: `$INFO[], $LOCALIZE[], [b][/b], [color=][/color]` - is fine and fairly understandable but the actual info could definitely do with a tidy up. I think black was along the right lines of what Jonathan's suggesting - Control(id).IsVisible Window(id).IsVisible ControlGroup(id).Item(id).HasFocus
	find quote